* [dunfell/master][PATCH] ti-test: fix string expansion
@ 2021-04-16 19:30 Gowtham Tammana
2021-04-16 19:46 ` Denys Dmytriyenko
0 siblings, 1 reply; 2+ messages in thread
From: Gowtham Tammana @ 2021-04-16 19:30 UTC (permalink / raw)
To: meta-arago, Praneeth Bajjuri, denys
bb conditional util expansion was done in '' causing the below error
```
bb.data_smart.ExpansionError: Failure expanding variable ARAGO_TI_TEST, expression was ... ${@bb.utils.contains('MACHINE_FEATURES', 'mmip', 'omapdrmtest', '', d)} cmem-test ', d)}
which triggered exception SyntaxError: invalid syntax (Var <ARAGO_TI_TEST>, line 1)
```
fixed the expansion to within "".
Signed-off-by: Gowtham Tammana <g-tammana@ti.com>
---
meta-arago-distro/recipes-core/packagegroups/ti-test.bb | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta-arago-distro/recipes-core/packagegroups/ti-test.bb b/meta-arago-distro/recipes-core/packagegroups/ti-test.bb
index 5b04d85c..cbc246d5 100644
--- a/meta-arago-distro/recipes-core/packagegroups/ti-test.bb
+++ b/meta-arago-distro/recipes-core/packagegroups/ti-test.bb
@@ -68,11 +68,11 @@ ARAGO_TI_TEST_append_ti43x = " \
ARAGO_TI_TEST_append_omap-a15 = " \
omapconf \
- ${@oe.utils.conditional('ARAGO_BRAND', 'mainline', '', ' \
+ ${@oe.utils.conditional('ARAGO_BRAND', 'mainline', '', " \
ti-ipc-test \
${@bb.utils.contains('MACHINE_FEATURES', 'mmip', 'omapdrmtest', '', d)} \
cmem-test \
- ', d)} \
+ ", d)} \
"
ARAGO_TI_TEST_append_k3 = " \
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [dunfell/master][PATCH] ti-test: fix string expansion
2021-04-16 19:30 [dunfell/master][PATCH] ti-test: fix string expansion Gowtham Tammana
@ 2021-04-16 19:46 ` Denys Dmytriyenko
0 siblings, 0 replies; 2+ messages in thread
From: Denys Dmytriyenko @ 2021-04-16 19:46 UTC (permalink / raw)
To: Gowtham Tammana; +Cc: meta-arago, denys
On Fri, Apr 16, 2021 at 02:30:53PM -0500, Gowtham Tammana wrote:
> bb conditional util expansion was done in '' causing the below error
>
> ```
> bb.data_smart.ExpansionError: Failure expanding variable ARAGO_TI_TEST, expression was ... ${@bb.utils.contains('MACHINE_FEATURES', 'mmip', 'omapdrmtest', '', d)} cmem-test ', d)}
> which triggered exception SyntaxError: invalid syntax (Var <ARAGO_TI_TEST>, line 1)
> ```
>
> fixed the expansion to within "".
Seems to have no issues in master, but yeah, good catch.
> Signed-off-by: Gowtham Tammana <g-tammana@ti.com>
Reviewed-by: Denys Dmytriyenko <denys@konsulko.com>
> ---
> meta-arago-distro/recipes-core/packagegroups/ti-test.bb | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta-arago-distro/recipes-core/packagegroups/ti-test.bb b/meta-arago-distro/recipes-core/packagegroups/ti-test.bb
> index 5b04d85c..cbc246d5 100644
> --- a/meta-arago-distro/recipes-core/packagegroups/ti-test.bb
> +++ b/meta-arago-distro/recipes-core/packagegroups/ti-test.bb
> @@ -68,11 +68,11 @@ ARAGO_TI_TEST_append_ti43x = " \
>
> ARAGO_TI_TEST_append_omap-a15 = " \
> omapconf \
> - ${@oe.utils.conditional('ARAGO_BRAND', 'mainline', '', ' \
> + ${@oe.utils.conditional('ARAGO_BRAND', 'mainline', '', " \
> ti-ipc-test \
> ${@bb.utils.contains('MACHINE_FEATURES', 'mmip', 'omapdrmtest', '', d)} \
> cmem-test \
> - ', d)} \
> + ", d)} \
> "
>
> ARAGO_TI_TEST_append_k3 = " \
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-16 19:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-16 19:30 [dunfell/master][PATCH] ti-test: fix string expansion Gowtham Tammana
2021-04-16 19:46 ` Denys Dmytriyenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.