* [chrome-os:chromeos-5.4 56/243] drivers/media/platform/mtk-vcodec/vdec/vdec_vp9_req_lat_if.c:751:10: warning: Expression is always false because 'else if' condition matches previous condition at line 749. [multiCondition]
@ 2021-04-17 9:51 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-04-17 9:51 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 5489 bytes --]
CC: kbuild-all(a)lists.01.org
TO: cros-kernel-buildreports(a)googlegroups.com
TO: Guenter Roeck <groeck@google.com>
tree: https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-5.4
head: 52d269f32500581166246e0e494b2b62d979dba6
commit: bc0b0ae994e6bb17b12bfd882c2eb837eb29c078 [56/243] CHROMIUM: media: mtk-vcodec: Add vp9 slice api driver for mt8192
:::::: branch date: 5 hours ago
:::::: commit date: 34 hours ago
compiler: hppa-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
>> drivers/media/platform/mtk-vcodec/vdec/vdec_vp9_req_lat_if.c:751:10: warning: Expression is always false because 'else if' condition matches previous condition at line 749. [multiCondition]
else if (hdr->reset_frame_context == V4L2_VP9_RESET_FRAME_CTX_SPEC)
^
vim +751 drivers/media/platform/mtk-vcodec/vdec/vdec_vp9_req_lat_if.c
bc0b0ae994e6bb Yunfei Dong 2021-01-21 729
bc0b0ae994e6bb Yunfei Dong 2021-01-21 730 static void vdec_vp9_slice_setup_hdr(
bc0b0ae994e6bb Yunfei Dong 2021-01-21 731 struct vdec_vp9_slice_instance *instance,
bc0b0ae994e6bb Yunfei Dong 2021-01-21 732 struct vdec_vp9_slice_uncompressed_header *uh,
bc0b0ae994e6bb Yunfei Dong 2021-01-21 733 struct v4l2_ctrl_vp9_frame_decode_params *hdr)
bc0b0ae994e6bb Yunfei Dong 2021-01-21 734 {
bc0b0ae994e6bb Yunfei Dong 2021-01-21 735 int i;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 736
bc0b0ae994e6bb Yunfei Dong 2021-01-21 737 uh->profile = hdr->profile;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 738 uh->last_frame_type = instance->frame_type;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 739 uh->frame_type = !HDR_FLAG(KEY_FRAME);
bc0b0ae994e6bb Yunfei Dong 2021-01-21 740 uh->last_show_frame = instance->show_frame;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 741 uh->show_frame = HDR_FLAG(SHOW_FRAME);
bc0b0ae994e6bb Yunfei Dong 2021-01-21 742 uh->error_resilient_mode = HDR_FLAG(ERROR_RESILIENT);
bc0b0ae994e6bb Yunfei Dong 2021-01-21 743 uh->bit_depth = hdr->bit_depth;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 744 uh->last_frame_width = instance->width;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 745 uh->last_frame_height = instance->height;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 746 uh->frame_width = hdr->frame_width_minus_1 + 1;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 747 uh->frame_height = hdr->frame_height_minus_1 + 1;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 748 uh->intra_only = HDR_FLAG(INTRA_ONLY);
bc0b0ae994e6bb Yunfei Dong 2021-01-21 @749 if (hdr->reset_frame_context == V4L2_VP9_RESET_FRAME_CTX_SPEC)
bc0b0ae994e6bb Yunfei Dong 2021-01-21 750 uh->reset_frame_context = 2;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 @751 else if (hdr->reset_frame_context == V4L2_VP9_RESET_FRAME_CTX_SPEC)
bc0b0ae994e6bb Yunfei Dong 2021-01-21 752 uh->reset_frame_context = 3;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 753 else
bc0b0ae994e6bb Yunfei Dong 2021-01-21 754 uh->reset_frame_context = 0;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 755 /*
bc0b0ae994e6bb Yunfei Dong 2021-01-21 756 * ref_frame_sign_bias specifies the intended direction
bc0b0ae994e6bb Yunfei Dong 2021-01-21 757 * of the motion vector in time for each reference frame.
bc0b0ae994e6bb Yunfei Dong 2021-01-21 758 * - INTRA_FRAME = 0,
bc0b0ae994e6bb Yunfei Dong 2021-01-21 759 * - LAST_FRAME = 1,
bc0b0ae994e6bb Yunfei Dong 2021-01-21 760 * - GOLDEN_FRAME = 2,
bc0b0ae994e6bb Yunfei Dong 2021-01-21 761 * - ALTREF_FRAME = 3,
bc0b0ae994e6bb Yunfei Dong 2021-01-21 762 * ref_frame_sign_biases[INTRA_FRAME] is always 0
bc0b0ae994e6bb Yunfei Dong 2021-01-21 763 * and VDA only passes another 3 directions
bc0b0ae994e6bb Yunfei Dong 2021-01-21 764 */
bc0b0ae994e6bb Yunfei Dong 2021-01-21 765 uh->ref_frame_sign_bias[0] = 0;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 766 for (i = 0; i < 3; i++)
bc0b0ae994e6bb Yunfei Dong 2021-01-21 767 uh->ref_frame_sign_bias[i + 1] =
bc0b0ae994e6bb Yunfei Dong 2021-01-21 768 !!(hdr->ref_frame_sign_biases & (1 << i));
bc0b0ae994e6bb Yunfei Dong 2021-01-21 769 uh->allow_high_precision_mv = HDR_FLAG(ALLOW_HIGH_PREC_MV);
bc0b0ae994e6bb Yunfei Dong 2021-01-21 770 uh->interpolation_filter = hdr->interpolation_filter;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 771 uh->refresh_frame_context = HDR_FLAG(REFRESH_FRAME_CTX);
bc0b0ae994e6bb Yunfei Dong 2021-01-21 772 uh->frame_parallel_decoding_mode = HDR_FLAG(PARALLEL_DEC_MODE);
bc0b0ae994e6bb Yunfei Dong 2021-01-21 773 uh->frame_context_idx = hdr->frame_context_idx;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 774
bc0b0ae994e6bb Yunfei Dong 2021-01-21 775 /* tile info */
bc0b0ae994e6bb Yunfei Dong 2021-01-21 776 uh->tile_cols_log2 = hdr->tile_cols_log2;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 777 uh->tile_rows_log2 = hdr->tile_rows_log2;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 778
bc0b0ae994e6bb Yunfei Dong 2021-01-21 779 uh->uncompressed_header_size = hdr->uncompressed_header_size;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 780 uh->header_size_in_bytes = hdr->compressed_header_size;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 781 }
bc0b0ae994e6bb Yunfei Dong 2021-01-21 782
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 2+ messages in thread
* [chrome-os:chromeos-5.4 56/243] drivers/media/platform/mtk-vcodec/vdec/vdec_vp9_req_lat_if.c:751:10: warning: Expression is always false because 'else if' condition matches previous condition at line 749. [multiCondition]
@ 2021-04-20 8:34 Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2021-04-20 8:34 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 5608 bytes --]
tree: https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-5.4
head: 52d269f32500581166246e0e494b2b62d979dba6
commit: bc0b0ae994e6bb17b12bfd882c2eb837eb29c078 [56/243] CHROMIUM: media: mtk-vcodec: Add vp9 slice api driver for mt8192
compiler: hppa-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
>> drivers/media/platform/mtk-vcodec/vdec/vdec_vp9_req_lat_if.c:751:10: warning: Expression is always false because 'else if' condition matches previous condition at line 749. [multiCondition]
else if (hdr->reset_frame_context == V4L2_VP9_RESET_FRAME_CTX_SPEC)
^
vim +751 drivers/media/platform/mtk-vcodec/vdec/vdec_vp9_req_lat_if.c
bc0b0ae994e6bb Yunfei Dong 2021-01-21 730 static void vdec_vp9_slice_setup_hdr(
bc0b0ae994e6bb Yunfei Dong 2021-01-21 731 struct vdec_vp9_slice_instance *instance,
bc0b0ae994e6bb Yunfei Dong 2021-01-21 732 struct vdec_vp9_slice_uncompressed_header *uh,
bc0b0ae994e6bb Yunfei Dong 2021-01-21 733 struct v4l2_ctrl_vp9_frame_decode_params *hdr)
bc0b0ae994e6bb Yunfei Dong 2021-01-21 734 {
bc0b0ae994e6bb Yunfei Dong 2021-01-21 735 int i;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 736
bc0b0ae994e6bb Yunfei Dong 2021-01-21 737 uh->profile = hdr->profile;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 738 uh->last_frame_type = instance->frame_type;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 739 uh->frame_type = !HDR_FLAG(KEY_FRAME);
bc0b0ae994e6bb Yunfei Dong 2021-01-21 740 uh->last_show_frame = instance->show_frame;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 741 uh->show_frame = HDR_FLAG(SHOW_FRAME);
bc0b0ae994e6bb Yunfei Dong 2021-01-21 742 uh->error_resilient_mode = HDR_FLAG(ERROR_RESILIENT);
bc0b0ae994e6bb Yunfei Dong 2021-01-21 743 uh->bit_depth = hdr->bit_depth;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 744 uh->last_frame_width = instance->width;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 745 uh->last_frame_height = instance->height;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 746 uh->frame_width = hdr->frame_width_minus_1 + 1;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 747 uh->frame_height = hdr->frame_height_minus_1 + 1;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 748 uh->intra_only = HDR_FLAG(INTRA_ONLY);
bc0b0ae994e6bb Yunfei Dong 2021-01-21 @749 if (hdr->reset_frame_context == V4L2_VP9_RESET_FRAME_CTX_SPEC)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
bc0b0ae994e6bb Yunfei Dong 2021-01-21 750 uh->reset_frame_context = 2;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 @751 else if (hdr->reset_frame_context == V4L2_VP9_RESET_FRAME_CTX_SPEC)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Same same.
bc0b0ae994e6bb Yunfei Dong 2021-01-21 752 uh->reset_frame_context = 3;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 753 else
bc0b0ae994e6bb Yunfei Dong 2021-01-21 754 uh->reset_frame_context = 0;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 755 /*
bc0b0ae994e6bb Yunfei Dong 2021-01-21 756 * ref_frame_sign_bias specifies the intended direction
bc0b0ae994e6bb Yunfei Dong 2021-01-21 757 * of the motion vector in time for each reference frame.
bc0b0ae994e6bb Yunfei Dong 2021-01-21 758 * - INTRA_FRAME = 0,
bc0b0ae994e6bb Yunfei Dong 2021-01-21 759 * - LAST_FRAME = 1,
bc0b0ae994e6bb Yunfei Dong 2021-01-21 760 * - GOLDEN_FRAME = 2,
bc0b0ae994e6bb Yunfei Dong 2021-01-21 761 * - ALTREF_FRAME = 3,
bc0b0ae994e6bb Yunfei Dong 2021-01-21 762 * ref_frame_sign_biases[INTRA_FRAME] is always 0
bc0b0ae994e6bb Yunfei Dong 2021-01-21 763 * and VDA only passes another 3 directions
bc0b0ae994e6bb Yunfei Dong 2021-01-21 764 */
bc0b0ae994e6bb Yunfei Dong 2021-01-21 765 uh->ref_frame_sign_bias[0] = 0;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 766 for (i = 0; i < 3; i++)
bc0b0ae994e6bb Yunfei Dong 2021-01-21 767 uh->ref_frame_sign_bias[i + 1] =
bc0b0ae994e6bb Yunfei Dong 2021-01-21 768 !!(hdr->ref_frame_sign_biases & (1 << i));
bc0b0ae994e6bb Yunfei Dong 2021-01-21 769 uh->allow_high_precision_mv = HDR_FLAG(ALLOW_HIGH_PREC_MV);
bc0b0ae994e6bb Yunfei Dong 2021-01-21 770 uh->interpolation_filter = hdr->interpolation_filter;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 771 uh->refresh_frame_context = HDR_FLAG(REFRESH_FRAME_CTX);
bc0b0ae994e6bb Yunfei Dong 2021-01-21 772 uh->frame_parallel_decoding_mode = HDR_FLAG(PARALLEL_DEC_MODE);
bc0b0ae994e6bb Yunfei Dong 2021-01-21 773 uh->frame_context_idx = hdr->frame_context_idx;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 774
bc0b0ae994e6bb Yunfei Dong 2021-01-21 775 /* tile info */
bc0b0ae994e6bb Yunfei Dong 2021-01-21 776 uh->tile_cols_log2 = hdr->tile_cols_log2;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 777 uh->tile_rows_log2 = hdr->tile_rows_log2;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 778
bc0b0ae994e6bb Yunfei Dong 2021-01-21 779 uh->uncompressed_header_size = hdr->uncompressed_header_size;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 780 uh->header_size_in_bytes = hdr->compressed_header_size;
bc0b0ae994e6bb Yunfei Dong 2021-01-21 781 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
_______________________________________________
kbuild mailing list -- kbuild(a)lists.01.org
To unsubscribe send an email to kbuild-leave(a)lists.01.org
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-20 8:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-17 9:51 [chrome-os:chromeos-5.4 56/243] drivers/media/platform/mtk-vcodec/vdec/vdec_vp9_req_lat_if.c:751:10: warning: Expression is always false because 'else if' condition matches previous condition at line 749. [multiCondition] kernel test robot
2021-04-20 8:34 Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.