Hi Alexandre,

I love your patch! Yet something to improve:

[auto build test ERROR on abelloni/rtc-next]
[also build test ERROR on v5.12-rc7 next-20210416]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Alexandre-Belloni/rtc-pcf8523-remove-useless-define/20210418-082211
base:   https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git rtc-next
config: x86_64-rhel-8.3-kselftests (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/ac4cc9aaf864c91e0bc0ec85c0a37c5983d350ba
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Alexandre-Belloni/rtc-pcf8523-remove-useless-define/20210418-082211
        git checkout ac4cc9aaf864c91e0bc0ec85c0a37c5983d350ba
        # save the attached .config to linux build tree
        make W=1 W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/rtc/rtc-pcf8523.c: In function 'pcf8523_probe':
>> drivers/rtc/rtc-pcf8523.c:533:9: error: implicit declaration of function 'rtc_register_device'; did you mean 'i2c_unregister_device'? [-Werror=implicit-function-declaration]
     533 |  return rtc_register_device(rtc);
         |         ^~~~~~~~~~~~~~~~~~~
         |         i2c_unregister_device
   cc1: some warnings being treated as errors


vim +533 drivers/rtc/rtc-pcf8523.c

   474	
   475	static int pcf8523_probe(struct i2c_client *client,
   476				 const struct i2c_device_id *id)
   477	{
   478		struct pcf8523 *pcf8523;
   479		struct rtc_device *rtc;
   480		bool wakeup_source = false;
   481		int err;
   482	
   483		if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C))
   484			return -ENODEV;
   485	
   486		pcf8523 = devm_kzalloc(&client->dev, sizeof(struct pcf8523), GFP_KERNEL);
   487		if (!pcf8523)
   488			return -ENOMEM;
   489	
   490		i2c_set_clientdata(client, pcf8523);
   491		pcf8523->client = client;
   492	
   493		err = pcf8523_load_capacitance(client);
   494		if (err < 0)
   495			dev_warn(&client->dev, "failed to set xtal load capacitance: %d",
   496				 err);
   497	
   498		err = pcf8523_set_pm(client, 0);
   499		if (err < 0)
   500			return err;
   501	
   502		rtc = devm_rtc_allocate_device(&client->dev);
   503		if (IS_ERR(rtc))
   504			return PTR_ERR(rtc);
   505	
   506		pcf8523->rtc = rtc;
   507		rtc->ops = &pcf8523_rtc_ops;
   508		rtc->range_min = RTC_TIMESTAMP_BEGIN_2000;
   509		rtc->range_max = RTC_TIMESTAMP_END_2099;
   510		rtc->uie_unsupported = 1;
   511	
   512		if (client->irq > 0) {
   513			err = pcf8523_write(client, REG_TMR_CLKOUT_CTRL, 0x38);
   514			if (err < 0)
   515				return err;
   516	
   517			err = devm_request_threaded_irq(&client->dev, client->irq,
   518							NULL, pcf8523_irq,
   519							IRQF_SHARED | IRQF_ONESHOT | IRQF_TRIGGER_LOW,
   520							dev_name(&rtc->dev), client);
   521			if (err)
   522				return err;
   523	
   524			dev_pm_set_wake_irq(&client->dev, client->irq);
   525		}
   526	
   527	#ifdef CONFIG_OF
   528		wakeup_source = of_property_read_bool(client->dev.of_node, "wakeup-source");
   529	#endif
   530		if (client->irq > 0 || wakeup_source)
   531			device_init_wakeup(&client->dev, true);
   532	
 > 533		return rtc_register_device(rtc);
   534	}
   535	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org