From: Tyler Hicks <code@tyhicks.com>
To: Ye Bin <yebin10@huawei.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.com>, Waiman Long <longman@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Howells <dhowells@redhat.com>,
ecryptfs@vger.kernel.org, kernel-janitors@vger.kernel.org,
Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] eCryptfs: Use DEFINE_MUTEX() for mutex lock
Date: Sun, 18 Apr 2021 12:34:33 -0500 [thread overview]
Message-ID: <20210418173433.GD398325@elm> (raw)
In-Reply-To: <20210409095142.2294032-1-yebin10@huawei.com>
On 2021-04-09 17:51:42, Ye Bin wrote:
> mutex lock can be initialized automatically with DEFINE_MUTEX()
> rather than explicitly calling mutex_init().
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Ye Bin <yebin10@huawei.com>
This looks good to me. Thanks for the fix.
Tyler
> ---
> fs/ecryptfs/messaging.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/fs/ecryptfs/messaging.c b/fs/ecryptfs/messaging.c
> index c0dfd9647627..25ed9baf524e 100644
> --- a/fs/ecryptfs/messaging.c
> +++ b/fs/ecryptfs/messaging.c
> @@ -14,10 +14,10 @@
>
> static LIST_HEAD(ecryptfs_msg_ctx_free_list);
> static LIST_HEAD(ecryptfs_msg_ctx_alloc_list);
> -static struct mutex ecryptfs_msg_ctx_lists_mux;
> +static DEFINE_MUTEX(ecryptfs_msg_ctx_lists_mux);
>
> static struct hlist_head *ecryptfs_daemon_hash;
> -struct mutex ecryptfs_daemon_hash_mux;
> +DEFINE_MUTEX(ecryptfs_daemon_hash_mux);
> static int ecryptfs_hash_bits;
> #define ecryptfs_current_euid_hash(uid) \
> hash_long((unsigned long)from_kuid(&init_user_ns, current_euid()), ecryptfs_hash_bits)
> @@ -359,7 +359,6 @@ int __init ecryptfs_init_messaging(void)
> "too large, defaulting to [%d] users\n", __func__,
> ecryptfs_number_of_users);
> }
> - mutex_init(&ecryptfs_daemon_hash_mux);
> mutex_lock(&ecryptfs_daemon_hash_mux);
> ecryptfs_hash_bits = 1;
> while (ecryptfs_number_of_users >> ecryptfs_hash_bits)
> @@ -383,7 +382,6 @@ int __init ecryptfs_init_messaging(void)
> rc = -ENOMEM;
> goto out;
> }
> - mutex_init(&ecryptfs_msg_ctx_lists_mux);
> mutex_lock(&ecryptfs_msg_ctx_lists_mux);
> ecryptfs_msg_counter = 0;
> for (i = 0; i < ecryptfs_message_buf_len; i++) {
>
prev parent reply other threads:[~2021-04-18 17:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 9:51 [PATCH -next] eCryptfs: Use DEFINE_MUTEX() for mutex lock Ye Bin
2021-04-09 9:51 ` Ye Bin
2021-04-18 17:34 ` Tyler Hicks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210418173433.GD398325@elm \
--to=code@tyhicks.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=ecryptfs@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=hulkci@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mhocko@suse.com \
--cc=yebin10@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.