From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEA09C433B4 for ; Mon, 19 Apr 2021 03:03:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A9DF96102A for ; Mon, 19 Apr 2021 03:03:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237334AbhDSDDk (ORCPT ); Sun, 18 Apr 2021 23:03:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229845AbhDSDDj (ORCPT ); Sun, 18 Apr 2021 23:03:39 -0400 Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CA02C061761 for ; Sun, 18 Apr 2021 20:03:10 -0700 (PDT) Received: by mail-oi1-x22c.google.com with SMTP id r186so6329491oif.8 for ; Sun, 18 Apr 2021 20:03:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=bqnvfHSQYNF4pvJ4mjc+HwtWh0C16GYEE3A80983hxI=; b=B4ewnibF9EHh8ijqrdNx6zYdfJy2upFzbtR2KcxcPAQstGakUWk/Rj2RTbP8hpwDKP S5p/gEaCCt5F5PP6blgoi9l7aYSYdCLMVT2aUbmKS6oTuXw9MWycD3P6te4Bf5SDfHB3 bTH5TZmVGW8K8dX3+/6LQh9nr0mNUNlNGZe/VCXInsfmP9Wef4C3W6W5QnHyX/9wIjpK 6tWxkW32M1cJwvRjPTiQ8uxpNgr7UthwhTM7c+qVlC5hCd5zNxKj4kkK66QQDU+cHxpQ 2NbEsKrC4kScpISxzxt93q1I0II0tMchCFdBNSNHE1PPP9hurBVNqe/j28Dyii53pUUr fuCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bqnvfHSQYNF4pvJ4mjc+HwtWh0C16GYEE3A80983hxI=; b=Tvhga5FodcjO/KS5Zfu5O2VKrG4gsqsxFNnOi6k234Vns6eJYoMkkkQGbZoJZx5tfD 47o1rbnn8+zEyeY0LlMDKZ2Y+lSURiKMYTLVfV2oB2sKIczr7NhuqDo1wh2L4mQLhWUn nRheQDSZjsvMpby40c0YQw4qXV6j7mTLFtSNLoTwhvmH7p8ppS4CumG66Le9H1Qt7ul/ MJ7JKAtJB3KzK93mkggH1fyRtmdG71MJTMFI6tgWwT5IcTPdLK88uUdaAjl9dmIa61uv ilHpzyOqpGSqWQdiSm7CLZ2oThxJF+LOfGRIRdO310pWqijidTCOTs9eGoWwIMhDTtJw bjdQ== X-Gm-Message-State: AOAM533Qay9vS0s46ajAt4YcUHCFIUr3JRRfg3eKpFqA/RaJxyPZ0Z2x 6xo/79PQ84t+Et4ntcnI16trHw== X-Google-Smtp-Source: ABdhPJyICQDHV5hiccixkRQbqfwPNkvLfdThlqYZKYj5tImWfvauBoTI+1+1h39g1nRUIL+Z1SCeuw== X-Received: by 2002:a05:6808:60f:: with SMTP id y15mr13917092oih.23.1618801389231; Sun, 18 Apr 2021 20:03:09 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id h25sm2656856oou.44.2021.04.18.20.03.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Apr 2021 20:03:08 -0700 (PDT) Date: Sun, 18 Apr 2021 22:03:05 -0500 From: Bjorn Andersson To: Thara Gopinath Cc: herbert@gondor.apana.org.au, davem@davemloft.net, ebiggers@google.com, ardb@kernel.org, sivaprak@codeaurora.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [Patch v2 3/7] crypto: qce: Add mode for rfc4309 Message-ID: <20210419030305.GJ1538589@yoga> References: <20210417132503.1401128-1-thara.gopinath@linaro.org> <20210417132503.1401128-4-thara.gopinath@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210417132503.1401128-4-thara.gopinath@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sat 17 Apr 08:24 CDT 2021, Thara Gopinath wrote: > rf4309 is the specification that uses aes ccm algorithms with IPsec > security packets. Add a submode to identify rfc4309 ccm(aes) algorithm > in the crypto driver. > Reviewed-by: Bjorn Andersson > Signed-off-by: Thara Gopinath > --- > > v1->v2: > - Moved up the QCE_ENCRYPT AND QCE_DECRYPT bit positions so that > addition of other algorithms in future will not affect these > macros. > > drivers/crypto/qce/common.h | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/crypto/qce/common.h b/drivers/crypto/qce/common.h > index 3bc244bcca2d..b135440bf72b 100644 > --- a/drivers/crypto/qce/common.h > +++ b/drivers/crypto/qce/common.h > @@ -51,9 +51,11 @@ > #define QCE_MODE_CCM BIT(12) > #define QCE_MODE_MASK GENMASK(12, 8) > > +#define QCE_MODE_CCM_RFC4309 BIT(13) > + > /* cipher encryption/decryption operations */ > -#define QCE_ENCRYPT BIT(13) > -#define QCE_DECRYPT BIT(14) > +#define QCE_ENCRYPT BIT(30) > +#define QCE_DECRYPT BIT(31) > > #define IS_DES(flags) (flags & QCE_ALG_DES) > #define IS_3DES(flags) (flags & QCE_ALG_3DES) > @@ -73,6 +75,7 @@ > #define IS_CTR(mode) (mode & QCE_MODE_CTR) > #define IS_XTS(mode) (mode & QCE_MODE_XTS) > #define IS_CCM(mode) (mode & QCE_MODE_CCM) > +#define IS_CCM_RFC4309(mode) ((mode) & QCE_MODE_CCM_RFC4309) > > #define IS_ENCRYPT(dir) (dir & QCE_ENCRYPT) > #define IS_DECRYPT(dir) (dir & QCE_DECRYPT) > -- > 2.25.1 >