From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F7DDC433ED for ; Mon, 19 Apr 2021 21:04:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3D789611F0 for ; Mon, 19 Apr 2021 21:04:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238385AbhDSVFP (ORCPT ); Mon, 19 Apr 2021 17:05:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:35926 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232897AbhDSVFO (ORCPT ); Mon, 19 Apr 2021 17:05:14 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2B81F6101C; Mon, 19 Apr 2021 21:04:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618866283; bh=BatIuz7zrAF5lJzJJQfQ3s2F5twGFrJv0Zvadn3IGXA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rO5RfE6NHjW2IJxJzNVH2kfC5gvwmOP415hNH+GKNCkr9bK/1t+AIJrR35dgzPytC lZ6IedHF/P+BhzneKPs1F70WrgvH2TETSO7B1xQ3PBdXkbBd1qfMSU9X+zqyex6HML 08PwBQ+AeDZmQJDjSr7/Iq+Q0Qlk0sY5mQxirVKqSpRIf3l9n6gGlWPEXoYJxRn25+ VAk2p41ceOFHtOqEskIWzR18ltovvpR1aI2KyhXrGTITKh32ysBtM0gF5HWoFQ3Xdy O0+oyT5OcI3d/KCehOBS0/c9Sx+SiQ99PisRh+w4TTVEan3Izme0VO6fuu632j79By lkz1JjAXG+QoQ== Date: Mon, 19 Apr 2021 14:04:42 -0700 From: Jakub Kicinski To: Vladimir Oltean Cc: "David S. Miller" , netdev@vger.kernel.org, Po Liu , Claudiu Manoil , Alex Marginean , Rob Herring , Shawn Guo , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Russell King - ARM Linux admin , Andrew Lunn , Michael Walle , Vladimir Oltean Subject: Re: [PATCH net-next 0/5] Flow control for NXP ENETC Message-ID: <20210419140442.79dd0ce0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20210416234225.3715819-1-olteanv@gmail.com> References: <20210416234225.3715819-1-olteanv@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, 17 Apr 2021 02:42:20 +0300 Vladimir Oltean wrote: > From: Vladimir Oltean > > This patch series contains logic for enabling the lossless mode on the > RX rings of the ENETC, and the PAUSE thresholds on the internal FIFO > memory. > > During testing it was found that, with the default FIFO configuration, > a sender which isn't persuaded by our PAUSE frames and keeps sending > will cause some MAC RX frame errors. To mitigate this, we need to ensure > that the FIFO never runs completely full, so we need to fix up a setting > that was supposed to be configured well out of reset. Unfortunately this > requires the addition of a new mini-driver. FWIW back in the day when I was working on more advanced devices than I deal with these days I was expecting to eventually run into this as well and create some form of devlink umbrella. IMHO such "mini driver" is a natural place for a devlink instance, and not the PFs/ports. Is this your thinking as well? AFAICT enetc doesn't implement devlink today so you start from whatever model works best without worrying about backward compat. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D287C433B4 for ; Mon, 19 Apr 2021 21:06:49 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 45A646101C for ; Mon, 19 Apr 2021 21:06:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 45A646101C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WFLhIVMHeoL1rOVvFeu4pYk7oQThBmu+H3SQtZZBF1I=; b=E4rO5iNwUqkSqoR2x3Rs1oQXj mRsETV5N0AqJbpTJBsLRt4SECarv72HGOQWpPR2IJYbEewa8VfyHhd1214et26j6932BhznFpCSqE 8WwupmuQ4pxLRMG4PoFFUEmS9BGdL7iTIJDa2AvXZx5gAw6y/O/CLIa9tKJ6CRgWZuPaF08pbrJVl /lcPz8M2OG1QWeJ2dyLl47SxV9JhFNdPg6yI748AxpO58ke6ULNMf29ZP5Ib4uF+zrKUbiJKYPx9e s49lWWmMSMkHfJqEbUpjCXUDQsD8iy8e25VOL/W3xuA1J0N1Krd+TP0P2HGBr94n16hfcygwd6zwQ ygrOI+5cA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lYb4c-00Ac4s-4m; Mon, 19 Apr 2021 21:04:50 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYb4Z-00Ac4f-ML for linux-arm-kernel@desiato.infradead.org; Mon, 19 Apr 2021 21:04:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Sender:Reply-To:Content-ID:Content-Description; bh=/dgR6y2ULeDGGVi7rYZjzi9rD4KExtWVs5S89bjC5h8=; b=06YxvFDIi/LKv18APiQ1Xiv7eL r3fibHSg0DjVBd1A7VHEvhMPXGqw7YLq70bFV+Q2SeHIiLQHQMzCrclW+QdrkhpY1YrqxgxpuSIfI iztKKGmWULF1wv7ly7gUHltGhx1Ihgh0KHIWUlvny4auMCPCsyleTaiWh3jTfgoNu1aR7QYcA5O6c MXFMaEOEFEeccGYsk4YgiTqza8IfaZziWo+pV8kwfffiJPQoES+w5HZpfHWMnTjcfM3gD5zwmIsRh Bf8VqqLnZLeK1I8OeAXWPJQvIdejzfDKnb/Kunha/uXU7lfS5aaZnubUh9W2Xyki3e4yfvuUqG64b z2XI3Mfg==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYb4X-00BfEG-5W for linux-arm-kernel@lists.infradead.org; Mon, 19 Apr 2021 21:04:46 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2B81F6101C; Mon, 19 Apr 2021 21:04:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618866283; bh=BatIuz7zrAF5lJzJJQfQ3s2F5twGFrJv0Zvadn3IGXA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rO5RfE6NHjW2IJxJzNVH2kfC5gvwmOP415hNH+GKNCkr9bK/1t+AIJrR35dgzPytC lZ6IedHF/P+BhzneKPs1F70WrgvH2TETSO7B1xQ3PBdXkbBd1qfMSU9X+zqyex6HML 08PwBQ+AeDZmQJDjSr7/Iq+Q0Qlk0sY5mQxirVKqSpRIf3l9n6gGlWPEXoYJxRn25+ VAk2p41ceOFHtOqEskIWzR18ltovvpR1aI2KyhXrGTITKh32ysBtM0gF5HWoFQ3Xdy O0+oyT5OcI3d/KCehOBS0/c9Sx+SiQ99PisRh+w4TTVEan3Izme0VO6fuu632j79By lkz1JjAXG+QoQ== Date: Mon, 19 Apr 2021 14:04:42 -0700 From: Jakub Kicinski To: Vladimir Oltean Cc: "David S. Miller" , netdev@vger.kernel.org, Po Liu , Claudiu Manoil , Alex Marginean , Rob Herring , Shawn Guo , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Russell King - ARM Linux admin , Andrew Lunn , Michael Walle , Vladimir Oltean Subject: Re: [PATCH net-next 0/5] Flow control for NXP ENETC Message-ID: <20210419140442.79dd0ce0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20210416234225.3715819-1-olteanv@gmail.com> References: <20210416234225.3715819-1-olteanv@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210419_140445_273942_6AD8B318 X-CRM114-Status: GOOD ( 14.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 17 Apr 2021 02:42:20 +0300 Vladimir Oltean wrote: > From: Vladimir Oltean > > This patch series contains logic for enabling the lossless mode on the > RX rings of the ENETC, and the PAUSE thresholds on the internal FIFO > memory. > > During testing it was found that, with the default FIFO configuration, > a sender which isn't persuaded by our PAUSE frames and keeps sending > will cause some MAC RX frame errors. To mitigate this, we need to ensure > that the FIFO never runs completely full, so we need to fix up a setting > that was supposed to be configured well out of reset. Unfortunately this > requires the addition of a new mini-driver. FWIW back in the day when I was working on more advanced devices than I deal with these days I was expecting to eventually run into this as well and create some form of devlink umbrella. IMHO such "mini driver" is a natural place for a devlink instance, and not the PFs/ports. Is this your thinking as well? AFAICT enetc doesn't implement devlink today so you start from whatever model works best without worrying about backward compat. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel