From: Trygve Aaberge <trygveaa@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org,
Christian Couder <christian.couder@gmail.com>,
Pranit Bauva <pranit.bauva@gmail.com>
Subject: Re: Using --term-* with bisect breaks skip
Date: Mon, 19 Apr 2021 21:32:03 +0200 [thread overview]
Message-ID: <20210419193203.GE10839@aaberge.net> (raw)
In-Reply-To: <xmqqlf9e9k9d.fsf@gitster.g>
On Mon, Apr 19, 2021 at 11:55:42 -0700, Junio C Hamano wrote:
> Can you "bisect" the problem? There aren't that many commits that
> touched bisection code during the period.
Yes, I ran it now. The commit introducing the regression is:
commit e4c7b33747dccc6600bc528b51e91c11b474eb04
Author: Pranit Bauva <pranit.bauva@gmail.com>
Date: Wed Feb 3 22:54:37 2021 +0100
bisect--helper: reimplement `bisect_skip` shell function in C
Reimplement the `bisect_skip()` shell function in C and also add
`bisect-skip` subcommand to `git bisect--helper` to call it from
git-bisect.sh
Using `--bisect-skip` subcommand is a temporary measure to port shell
function to C so as to use the existing test suite.
Mentored-by: Lars Schneider <larsxschneider@gmail.com>
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Mentored-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com>
Signed-off-by: Tanushree Tumane <tanushreetumane@gmail.com>
Signed-off-by: Miriam Rubio <mirucam@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
--
Trygve Aaberge
next prev parent reply other threads:[~2021-04-19 19:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-18 15:14 Using --term-* with bisect breaks skip Trygve Aaberge
2021-04-19 6:58 ` Bagas Sanjaya
2021-04-19 8:39 ` Trygve Aaberge
2021-04-19 12:50 ` Bagas Sanjaya
2021-04-19 18:55 ` Junio C Hamano
2021-04-19 19:32 ` Trygve Aaberge [this message]
2021-04-20 12:34 ` [PATCH] test: add test for git bisect skip with --term* arguments Bagas Sanjaya
2021-04-20 18:08 ` Junio C Hamano
2021-04-21 4:08 ` [PATCH v2] " Bagas Sanjaya
2021-04-21 17:25 ` Junio C Hamano
2021-04-22 5:16 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210419193203.GE10839@aaberge.net \
--to=trygveaa@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pranit.bauva@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.