From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5158FC433ED for ; Mon, 19 Apr 2021 20:49:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B89C61369 for ; Mon, 19 Apr 2021 20:49:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239146AbhDSUuQ (ORCPT ); Mon, 19 Apr 2021 16:50:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:54790 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242619AbhDSUro (ORCPT ); Mon, 19 Apr 2021 16:47:44 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A5A5D613DB; Mon, 19 Apr 2021 20:45:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618865139; bh=EDj1gHlZSzYdYf98LrWwBli/46xSjlYyncHL60ccxE8=; h=From:To:Cc:Subject:Date:From; b=n4e/cACLrXR9fL+SusuHUrUJmxENYhHr/Gc/cr+a9Ey7vujZmMR+HPNhKJS7qR9CE D4ata9YB6FBZmBmYSvEYRrkZ/qGb6nravcOb89RNuxvfHWWFBPvXx4fngsSkH6R9Rz HLN535MJu1ZLTBFWVXcVvwVETwQPE0kxvK/bxW1SVmD8TFCyVr9maXJJut9/xNFLww lblx1ZA+YhyRLNaROVsS1AvPeRgpBU81qU+19eD3OMd/rtYk/PAuoPX6S3h4LRkH4w htKkK1jYn0NhCtaXWk8s0sE2TjrHIxF045FAaH0Ty3sTS3sJwvtkazbhrHaXpmoFT1 gOgxXqebVTYYQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jia-Ju Bai , TOTE Robot , Jiri Kosina , Sasha Levin , linux-input@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 01/11] HID: alps: fix error return code in alps_input_configured() Date: Mon, 19 Apr 2021 16:45:26 -0400 Message-Id: <20210419204536.6924-1-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jia-Ju Bai [ Upstream commit fa8ba6e5dc0e78e409e503ddcfceef5dd96527f4 ] When input_register_device() fails, no error return code is assigned. To fix this bug, ret is assigned with -ENOENT as error return code. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai Signed-off-by: Jiri Kosina Signed-off-by: Sasha Levin --- drivers/hid/hid-alps.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c index ed9c0ea5b026..1bc6ad0339d2 100644 --- a/drivers/hid/hid-alps.c +++ b/drivers/hid/hid-alps.c @@ -429,6 +429,7 @@ static int alps_input_configured(struct hid_device *hdev, struct hid_input *hi) ret = input_register_device(data->input2); if (ret) { input_free_device(input2); + ret = -ENOENT; goto exit; } } -- 2.30.2