From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F069C43460 for ; Mon, 19 Apr 2021 21:40:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C8F7061354 for ; Mon, 19 Apr 2021 21:40:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241392AbhDSVlB (ORCPT ); Mon, 19 Apr 2021 17:41:01 -0400 Received: from mail.netfilter.org ([217.70.188.207]:37350 "EHLO mail.netfilter.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241175AbhDSVkz (ORCPT ); Mon, 19 Apr 2021 17:40:55 -0400 Received: from us.es (unknown [90.77.255.23]) by mail.netfilter.org (Postfix) with ESMTPSA id 5491163E56; Mon, 19 Apr 2021 23:39:51 +0200 (CEST) Date: Mon, 19 Apr 2021 23:40:19 +0200 From: Pablo Neira Ayuso To: Jakub Kicinski Cc: netdev@vger.kernel.org, davem@davemloft.net, john@phrozen.org, nbd@nbd.name, sean.wang@mediatek.com, Mark-MC.Lee@mediatek.com, dqfext@gmail.com, frank-w@public-files.de Subject: Re: [PATCH net-next 2/3] net: ethernet: mtk_eth_soc: missing mutex Message-ID: <20210419214019.GA8535@salvia> References: <20210418211145.21914-1-pablo@netfilter.org> <20210418211145.21914-3-pablo@netfilter.org> <20210419141601.531b2efd@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210419141601.531b2efd@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Apr 19, 2021 at 02:16:01PM -0700, Jakub Kicinski wrote: > On Sun, 18 Apr 2021 23:11:44 +0200 Pablo Neira Ayuso wrote: > > Patch 2ed37183abb7 ("netfilter: flowtable: separate replace, destroy and > > stats to different workqueues") splits the workqueue per event type. Add > > a mutex to serialize updates. > > > > Fixes: 502e84e2382d ("net: ethernet: mtk_eth_soc: add flow offloading support") > > Reported-by: Frank Wunderlich > > Signed-off-by: Pablo Neira Ayuso > > This driver doesn't set unlocked_driver_cb, why is it expected to take > any locks? I thought the contract is that caller should hold rtnl. No rtnl lock is held from the netfilter side, see: 42f1c2712090 ("netfilter: nftables: comment indirect serialization of commit_mutex with rtnl_mutex")