From: Eduardo Habkost <ehabkost@redhat.com>
To: Robert Hoo <robert.hu@linux.intel.com>
Cc: pbonzini@redhat.com, richard.henderson@linaro.org, qemu-devel@nongnu.org
Subject: Re: [PATCH v5] i386/cpu_dump: support AVX512 ZMM regs dump
Date: Mon, 19 Apr 2021 17:59:52 -0400 [thread overview]
Message-ID: <20210419215952.cganarekhjc3jy6t@habkost.net> (raw)
In-Reply-To: <20210419201825.43ejc5d4xaj7ebj3@habkost.net>
On Mon, Apr 19, 2021 at 04:18:25PM -0400, Eduardo Habkost wrote:
> On Fri, Apr 16, 2021 at 10:08:24AM +0800, Robert Hoo wrote:
> > Since commit fa4518741e (target-i386: Rename struct XMMReg to ZMMReg),
> > CPUX86State.xmm_regs[] has already been extended to 512bit to support
> > AVX512.
> > Also, other qemu level supports for AVX512 registers are there for
> > years.
> > But in x86_cpu_dump_state(), still only dump XMM registers no matter
> > YMM/ZMM is enabled.
> > This patch is to complement this, let it dump XMM/YMM/ZMM accordingly.
> >
> > Signed-off-by: Robert Hoo <robert.hu@linux.intel.com>
>
> Queued for 6.1, thanks!
Dequeuing, as it causes build failures on multiple configs:
https://gitlab.com/ehabkost/qemu/-/pipelines/288890306
Example:
../target/i386/cpu-dump.c: In function 'x86_cpu_dump_state':
../target/i386/cpu-dump.c:511:50: error: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'uint64_t' {aka 'long long unsigned int'} [-Werror=format=]
qemu_fprintf(f, "Opmask%02d=%016lx%s", i, env->opmask_regs[i],
~~~~~^ ~~~~~~~~~~~~~~~~~~~
%016llx
../target/i386/cpu-dump.c:517:47: error: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'uint64_t' {aka 'long long unsigned int'} [-Werror=format=]
qemu_fprintf(f, "ZMM%02d=%016lx %016lx %016lx %016lx %016lx "
~~~~~^
%016llx
--
Eduardo
next prev parent reply other threads:[~2021-04-19 22:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 2:08 [PATCH v5] i386/cpu_dump: support AVX512 ZMM regs dump Robert Hoo
2021-04-16 17:27 ` Richard Henderson
2021-04-19 20:18 ` Eduardo Habkost
2021-04-19 21:59 ` Eduardo Habkost [this message]
2021-05-06 8:56 ` Robert Hoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210419215952.cganarekhjc3jy6t@habkost.net \
--to=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=robert.hu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.