From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60158C433B4 for ; Tue, 20 Apr 2021 10:08:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 26BEF613AE for ; Tue, 20 Apr 2021 10:08:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231431AbhDTKJI (ORCPT ); Tue, 20 Apr 2021 06:09:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:34536 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231313AbhDTKJH (ORCPT ); Tue, 20 Apr 2021 06:09:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618913316; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a1pYqsNDnaImaveZt19WFrefpysHdoYlJwKJGNtTNq4=; b=AcHYZmXYqbeEh4cX5cSX0Z4yYp6A7Ns0ZkqGEEZYCLN3stlRASx5jEyXL3d1sp/Dag+WBO T/WsXj90eUTuPgo6b+Jb1BnmN8KrA16qoJ8bFnUzF37C4LYlE/7qNIGDgxoV+/arstHLXX 7hJ9Keja2FbZVLxxZTeFqqn9P29+L4A= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-217-WU_c-e7kOtqDaih1Jr0ECQ-1; Tue, 20 Apr 2021 06:08:34 -0400 X-MC-Unique: WU_c-e7kOtqDaih1Jr0ECQ-1 Received: by mail-wr1-f71.google.com with SMTP id h60-20020adf90420000b029010418c4cd0cso9763730wrh.12 for ; Tue, 20 Apr 2021 03:08:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=a1pYqsNDnaImaveZt19WFrefpysHdoYlJwKJGNtTNq4=; b=W2hjRyJNVnihL9+5Mpx5F0ryZNaG3zG1H/O/3ygt3zdmGlcDvN7ELDDEYA2Mz7rLA5 ArElp+E4XR8fEyiON+drglXvz2wVsnRatKTKkZKDfu91AapsZAUVVqW1LPf63SyD+P6G Y/6g2ZYUHYb9O/J07Um//PGf2VhFYlsEWEJvBOgmcFP3cAJUvScl3LYRO8wP3ovLxVuH elItkO7fVtbOz1eM2K9TOcedORLtQsPS25kXetXakhXfnDveM1T/BE0DkePVlNMrLvd8 pkcZcqOpKSzk3HJ9ZzIC4LInC89agqTd93L40fbdD7ag3CvBUs85GrdKxhM9OrVe2sP1 MUsQ== X-Gm-Message-State: AOAM530OmYImTltc9Uq794R5fyZHzPNMopiJX/rpgYukQ+pyMnIWDdDM Ufqj4yCMFlXsbrXWRElPXpZ6nTJ16xrU4yDWR1mX51CBlukHBs3MJ42HKi0nypJb5ugiHp4KeSN mxYOyf9TZJl0VKVXhuj9TYp8= X-Received: by 2002:adf:bbd2:: with SMTP id z18mr19583497wrg.274.1618913313338; Tue, 20 Apr 2021 03:08:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwiOVtXxYFOUh6+eZ32xEpHAEZlXERzd+C/fJVENNgoKL6Wlrxpy9j9zC3V92YoEbuatNntfw== X-Received: by 2002:adf:bbd2:: with SMTP id z18mr19583476wrg.274.1618913313205; Tue, 20 Apr 2021 03:08:33 -0700 (PDT) Received: from redhat.com ([2a10:800a:cdef:0:114d:2085:61e4:7b41]) by smtp.gmail.com with ESMTPSA id u8sm26806244wrr.42.2021.04.20.03.08.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Apr 2021 03:08:32 -0700 (PDT) Date: Tue, 20 Apr 2021 06:08:29 -0400 From: "Michael S. Tsirkin" To: Christoph Hellwig Cc: Enrico Granata , jasowang@redhat.com, pbonzini@redhat.com, stefanha@redhat.com, axboe@kernel.dk, virtualization@lists.linux-foundation.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] virtio_blk: Add support for lifetime feature Message-ID: <20210420060807-mutt-send-email-mst@kernel.org> References: <20210416194709.155497-1-egranata@google.com> <20210420070129.GA3534874@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210420070129.GA3534874@infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Apr 20, 2021 at 08:01:29AM +0100, Christoph Hellwig wrote: > Just to despit my 2 cents again: I think the way this is specified > in the virtio spec is actively harmful and we should not suport it in > Linux. > > If others override me we at least need to require a detailed > documentation of these fields as the virto spec does not provide it. > > Please also do not add pointless over 80 character lines, and follow > the one value per sysfs file rule. Enrico would you like to raise the issues with the virtio TC for resolution? -- MST From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB7E1C433ED for ; Tue, 20 Apr 2021 10:09:36 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 24C03613AE for ; Tue, 20 Apr 2021 10:09:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 24C03613AE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id ADB2E402E3; Tue, 20 Apr 2021 10:09:35 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aW80rf03JsaM; Tue, 20 Apr 2021 10:09:34 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTP id 5628A402E1; Tue, 20 Apr 2021 10:09:34 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3782DC001E; Tue, 20 Apr 2021 10:09:34 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 6FB0DC000B for ; Tue, 20 Apr 2021 10:09:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 5EB2983131 for ; Tue, 20 Apr 2021 10:09:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ua995GWyNMVM for ; Tue, 20 Apr 2021 10:09:28 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by smtp1.osuosl.org (Postfix) with ESMTPS id B15DD82F49 for ; Tue, 20 Apr 2021 10:09:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618913367; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a1pYqsNDnaImaveZt19WFrefpysHdoYlJwKJGNtTNq4=; b=C0T6fv0kROrqhhqkDlj+3uaztkbQ17x0ueP1He5z6BuBYbGJXpx9uZs3ZRiRlmwl8PoHfE MZ2BrkfnqVsaB1zmitaasMaTNXltDvFwliaAXN5j82pPGjgib8JC1bu6muot3aJLc3ZgXX 5A0oSD24mvmN+ynpyQ8ODXaBx/HQ7vI= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-217-EVzQ6LGxPJS_H1UyDHilug-1; Tue, 20 Apr 2021 06:08:34 -0400 X-MC-Unique: EVzQ6LGxPJS_H1UyDHilug-1 Received: by mail-wm1-f71.google.com with SMTP id g144-20020a1c20960000b029012983de0c8fso4353149wmg.7 for ; Tue, 20 Apr 2021 03:08:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=a1pYqsNDnaImaveZt19WFrefpysHdoYlJwKJGNtTNq4=; b=KIsSwsvxs2uxT5ocKV4+UzUn/O927rEF6+S0K5Pw0Hi1M5N/NWgWbJg96dq9l4PMTw kseLYJS8K6RYIDUbHW46gbN2hTYvHsouM+UdNs4PQ5n0Sjp8LrsM09PXhFP2YSOlIkAp B2b3aJmXRM32AzW1pVbH1TRoSw5gL5bBlZhAFLQ+qOywpWGc9UIuz8B/DmPXDa/Z5Mkm szh9Bz0eGu0/ue/BFMXBbhCXkd+65f0ewpxtC8+sT2Kl7yP2Sw4lds/i7JYhSNoTlkib hWj8MMsP0HK4F9iOulsR0SUhzTkDJTf6ztU8mnLGD8I6NUXitb5ilu2J7K+n4o1jPe0P SZQw== X-Gm-Message-State: AOAM530BOTBrZbCeo1XMqJnvjpcW/dXU9TcGQ44LWtJU3j7eo7TXc/H6 xX9XE7cBbd/oDC7DRLqA0S8Phu+2aMahE36T400CyHAwOgZ2QH8z2Ve8wrd7EK5rHXdneiOQt4o 97mPF3a8F0EqRffZbjj6El9DlIbfBu3Vk/ImSuDtMJQ== X-Received: by 2002:adf:bbd2:: with SMTP id z18mr19583492wrg.274.1618913313337; Tue, 20 Apr 2021 03:08:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwiOVtXxYFOUh6+eZ32xEpHAEZlXERzd+C/fJVENNgoKL6Wlrxpy9j9zC3V92YoEbuatNntfw== X-Received: by 2002:adf:bbd2:: with SMTP id z18mr19583476wrg.274.1618913313205; Tue, 20 Apr 2021 03:08:33 -0700 (PDT) Received: from redhat.com ([2a10:800a:cdef:0:114d:2085:61e4:7b41]) by smtp.gmail.com with ESMTPSA id u8sm26806244wrr.42.2021.04.20.03.08.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Apr 2021 03:08:32 -0700 (PDT) Date: Tue, 20 Apr 2021 06:08:29 -0400 From: "Michael S. Tsirkin" To: Christoph Hellwig Subject: Re: [PATCH v2] virtio_blk: Add support for lifetime feature Message-ID: <20210420060807-mutt-send-email-mst@kernel.org> References: <20210416194709.155497-1-egranata@google.com> <20210420070129.GA3534874@infradead.org> MIME-Version: 1.0 In-Reply-To: <20210420070129.GA3534874@infradead.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-block@vger.kernel.org, stefanha@redhat.com, pbonzini@redhat.com, Enrico Granata X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Tue, Apr 20, 2021 at 08:01:29AM +0100, Christoph Hellwig wrote: > Just to despit my 2 cents again: I think the way this is specified > in the virtio spec is actively harmful and we should not suport it in > Linux. > > If others override me we at least need to require a detailed > documentation of these fields as the virto spec does not provide it. > > Please also do not add pointless over 80 character lines, and follow > the one value per sysfs file rule. Enrico would you like to raise the issues with the virtio TC for resolution? -- MST _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization