From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7A44C43461 for ; Tue, 20 Apr 2021 12:25:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A2E77613BF for ; Tue, 20 Apr 2021 12:25:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232026AbhDTM0G (ORCPT ); Tue, 20 Apr 2021 08:26:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231196AbhDTM0F (ORCPT ); Tue, 20 Apr 2021 08:26:05 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF05BC06174A for ; Tue, 20 Apr 2021 05:25:33 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1lYpRc-0008Eg-HP; Tue, 20 Apr 2021 14:25:32 +0200 Date: Tue, 20 Apr 2021 14:25:32 +0200 From: Florian Westphal To: Ali Abdallah Cc: netfilter-devel@vger.kernel.org Subject: Re: [PATCH] netfilter: conntrack: Reset the max ACK flag on SYN in ignore state Message-ID: <20210420122532.GC4841@breakpoint.cc> References: <20210420122415.v2jtayiw3n4ds7t7@Fryzen495> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210420122415.v2jtayiw3n4ds7t7@Fryzen495> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Ali Abdallah wrote: > In ignore state, we let SYN goes in original, the server might respond > with RST/ACK, and that RST packet is erroneously dropped because of the > flag IP_CT_TCP_FLAG_MAXACK_SET being already set. Acked-by: Florian Westphal