Re: [PATCH 1/2] bitmap_parse: support 'all' semantics

From: Yury Norov <yury.norov@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, rcu@vger.kernel.org,
	linux-doc@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	Joel Fernandes <joel@joelfernandes.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Lai Jiangshan <jiangshanlai@gmail.com>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Palmer Dabbelt <palmerdabbelt@google.com>,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH 1/2] bitmap_parse: support 'all' semantics
Date: Tue, 20 Apr 2021 12:32:50 -0700	[thread overview]
Message-ID: <20210420193250.GA61766@yury-ThinkPad> (raw)
In-Reply-To: <YH6qUDJmUflEmper@smile.fi.intel.com>

On Tue, Apr 20, 2021 at 01:17:52PM +0300, Andy Shevchenko wrote:
> On Mon, Apr 19, 2021 at 05:01:30PM -0700, Yury Norov wrote:
> > RCU code supports an 'all' group as a special case when parsing
> > rcu_nocbs parameter. This patch moves the 'all' support to the core
> > bitmap_parse code, so that all bitmap users can enjoy this extension.
> > 
> > Moving 'all' parsing to a bitmap_parse level, also allows users to
> > pass patterns together with 'all' in regular group:pattern format
> 
> ...
> 
> >  	{0, "0-31:1/3,1-31:1/3,2-31:1/3",	&exp1[8 * step], 32, 0},
> >  	{0, "1-10:8/12,8-31:24/29,0-31:0/3",	&exp1[9 * step], 32, 0},
> >  
> > +	{0,	  "all",		&exp1[8 * step], 32, 0},
> > +	{0,	  "0, 1, all,  ",	&exp1[8 * step], 32, 0},
> > +	{0,	  "all:1/2",		&exp1[4 * step], 32, 0},
> > +	{0,	  "ALL:1/2",		&exp1[4 * step], 32, 0},
> 
> > +	{-EINVAL, "al", NULL, 8, 0},
> > +	{-EINVAL, "alll", NULL, 8, 0},
> > +
> 
> Looking at the below hunk it seems like the two above should be actually placed
> there.
> 
> >  	{-EINVAL, "-1",	NULL, 8, 0},
> >  	{-EINVAL, "-0",	NULL, 8, 0},
> >  	{-EINVAL, "10-1", NULL, 8, 0},
> > @@ -384,7 +391,6 @@ static const struct test_bitmap_parselist parselist_tests[] __initconst = {
> >  	{-EINVAL, "a-31:10/1", NULL, 8, 0},
> >  	{-EINVAL, "0-31:a/1", NULL, 8, 0},
> >  	{-EINVAL, "0-\n", NULL, 8, 0},
> > -
> 
> Otherwise this change doesn't belong to the series.

My bad, I'll fix it in v2.