From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C44A7C433B4 for ; Tue, 20 Apr 2021 20:00:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 848E5613E3 for ; Tue, 20 Apr 2021 20:00:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233541AbhDTUBU (ORCPT ); Tue, 20 Apr 2021 16:01:20 -0400 Received: from mail-ot1-f53.google.com ([209.85.210.53]:35725 "EHLO mail-ot1-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233548AbhDTUBT (ORCPT ); Tue, 20 Apr 2021 16:01:19 -0400 Received: by mail-ot1-f53.google.com with SMTP id 35-20020a9d05260000b029029c82502d7bso5498829otw.2 for ; Tue, 20 Apr 2021 13:00:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=IhDL9E4EMajKLlxLPAH3/m7tAdxZQuhhLK82BEcjgIs=; b=oxtSrGJiwDui/COG8T5CCCqAU9MTisHHwXT6iT+lyhU26urdo7OkDCR67IGAMMukLQ vgTvX4+ft6RD5715sBgnpH76z920rFoGijiPfMqs3+3lLLSIbCoixAD41GOPRp72sH2x eSS+naLHHI0Jz3Kk6mF7z5XJpdMWR4FUDvRbtCoaXBVQ7ud93sSNE0rK58g5uXNVlntO r76tzkqosk7SBeQVnX5bnm0XgiVuIvWLX1oVF7peeWquw5bULTKV7JOxDF/yA60A/1eI kb5ZeJUV8BLIbj9cSorSSue7cIzTX56XdV0brJzC1c3ZTyYt/e9/u/wGb5gQlCWDfkrb eY3Q== X-Gm-Message-State: AOAM532LeNwUWe9RZgJpPSYl3XTzgHXk9EJSNRlKG2cfE4i/EoS02ZCw S/xffmPY4x1JD/7JesWG/oUmgkTW+Q== X-Google-Smtp-Source: ABdhPJxboA35RcbHVSP5NuFAUvqrJnu9tWe+0EajshhhLShxYWXe+BvyeYC2Odu+m/93QhL4uVgxMA== X-Received: by 2002:a9d:6e9:: with SMTP id 96mr19886392otx.118.1618948847684; Tue, 20 Apr 2021 13:00:47 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id e20sm8797otl.15.2021.04.20.13.00.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Apr 2021 13:00:47 -0700 (PDT) Received: (nullmailer pid 3717287 invoked by uid 1000); Tue, 20 Apr 2021 20:00:45 -0000 Date: Tue, 20 Apr 2021 15:00:45 -0500 From: Rob Herring To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Lee Jones , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Florian Fainelli , Vivek Unune , bcm-kernel-feedback-list@broadcom.com, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH robh dt/next] dt-bindings: mfd: add Broadcom CRU Message-ID: <20210420200045.GA3710852@robh.at.kernel.org> References: <20210415062839.11713-1-zajec5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210415062839.11713-1-zajec5@gmail.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Apr 15, 2021 at 08:28:39AM +0200, Rafał Miłecki wrote: > From: Rafał Miłecki > > CRU is a block used in e.g. Northstar devices. It can be seen in the > bcm5301x.dtsi and this binding documents its proper usage. > > Signed-off-by: Rafał Miłecki > --- > This is reworked version of the > [PATCH robh next] dt-bindings: bus: add Broadcom CRU > https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20210309142241.16259-1-zajec5@gmail.com/ > --- > .../devicetree/bindings/mfd/brcm,cru.yaml | 46 +++++++++++++++++++ > 1 file changed, 46 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/brcm,cru.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/brcm,cru.yaml b/Documentation/devicetree/bindings/mfd/brcm,cru.yaml > new file mode 100644 > index 000000000000..f5bce6453c33 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/brcm,cru.yaml > @@ -0,0 +1,46 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/brcm,cru.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Broadcom CRU > + > +maintainers: > + - Rafał Miłecki > + > +description: | > + Broadcom CRU ("Clock and Reset Unit" or "Central Resource Unit") is a hardware > + block grouping smaller blocks. On Broadcom Northstar platform it contains e.g. > + clocks, pinctrl, USB PHY and thermal. As I said before, this needs to be a complete binding. > + > +properties: > + compatible: > + items: > + - enum: > + - brcm,ns-cru > + - const: simple-mfd As of now, it is not a 'simple-mfd' because there are no defined children. > + > + reg: > + description: CRU registers > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 1 > + > +additionalProperties: true This needs to be 'false' (and then any child nodes defined). > + > +required: > + - reg > + > +examples: > + - | > + cru-bus@1800c100 { > + compatible = "brcm,ns-cru", "simple-mfd"; > + reg = <0x1800c100 0x1d0>; > + ranges; > + #address-cells = <1>; > + #size-cells = <1>; > + }; > -- > 2.26.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80BFDC433ED for ; Tue, 20 Apr 2021 20:03:29 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B5B2060241 for ; Tue, 20 Apr 2021 20:03:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5B2060241 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SkBtMiFh7HsWVcVWnMYWabRd7mzuy0B3KkM+7LJM2vA=; b=POZaIHoaVugj05wEhFzS1IUvS nz6z5AgIYZv3V26Qv9f47YB+NNJYm4NyBGfjOfp2T+OXDXxSASFympkLdJrskxLHXdSvxnVgJiO75 OG0ZYQwOyQ4U4+dD6NSutDOE3/+CeZetY869ykR5Vv/xbiM8pDYk0YprHF4G1duEZReH0RZ1wpGY2 kun5QcieREnQaaXSbvRN7YZQfy5oSLvGycLhtS8QlSF8K0MewdfYAZ4ZmkkBXo/qfZm2/UK4DtdGF UcfvTg7KBEFjlCA34azpEEQH9BDr/eywWwSgeVFh73j/c5nLKr0Nhx5ISmxomt7bIn3pPS0S8Rxh1 gVtxtaoYQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lYwYL-00CyuC-87; Tue, 20 Apr 2021 20:00:57 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYwYI-00Cytu-By for linux-arm-kernel@desiato.infradead.org; Tue, 20 Apr 2021 20:00:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=IhDL9E4EMajKLlxLPAH3/m7tAdxZQuhhLK82BEcjgIs=; b=UhJMnhTcVYhQPl678N6pyRyDX7 Sy4S84xvmLwqefCo9T4iE4inlU1EO5lDm3qDFPpL8+iAW+cDEIAM+i0QsO/kXSslOrY0/Fqi87pCw ZvaQfEE8ySn70CxYOzRFxRJ27CU87Nkxhgxm/QD31fvB/frls394z7HwjSXnzqIxL7AbJXUB073rM nCm7cc9Uh1JoMmaGRIozUil9GV/1Sh9GJWNWhHaN4+6DGAw0fJWme16vH0LGwd8YQ5S0+1KYLZVBG ypNK55q9GszUUlmAUjAt8s6s8v0JX1C8qU4PMq1cYG9LfGwSqi34c2KQyYOqEnMvkTzDe94gdyptE 5b2CbF6w==; Received: from mail-ot1-f42.google.com ([209.85.210.42]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYwYD-00COJq-HL for linux-arm-kernel@lists.infradead.org; Tue, 20 Apr 2021 20:00:53 +0000 Received: by mail-ot1-f42.google.com with SMTP id f75-20020a9d03d10000b0290280def9ab76so31811801otf.12 for ; Tue, 20 Apr 2021 13:00:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=IhDL9E4EMajKLlxLPAH3/m7tAdxZQuhhLK82BEcjgIs=; b=DV/m5TwiNjiRfCEz39JcbI+/wcBdAQtf09CgoLPz3Yl3VRf0H/1iWDquudOruxjqQg C2npQ9k/ipBTWVLzZOm7QjiitIZhZxk6CMMz4xmPQUkM25GbBDeXwQY7rEp9B6xlHlTu OizBieSuHATlEk0a/gHXaPAjkZ45uRZXga5c7CFKCdr1T8hApxZZ2iholyU8HFjPINVm p2sV6M3iHJgj0HvcYGbHpOg7UQjUePL7MAc/DlWSlLLpXIJECbCL/C3jDO9w/605sA/C dwE6tngYus9B8edsvq8AaWwd5R5mhl4xMj+nkJqaSkbBeECgCNkQ+ToXS1W+SRe2PdNG KXZg== X-Gm-Message-State: AOAM530RgkhsRaU2L83T63MxWgo1eqxZx+Ucqhhw8btc3ALxHa/H+u/w FLa4RaUeMNltuHEx88zqBw== X-Google-Smtp-Source: ABdhPJxboA35RcbHVSP5NuFAUvqrJnu9tWe+0EajshhhLShxYWXe+BvyeYC2Odu+m/93QhL4uVgxMA== X-Received: by 2002:a9d:6e9:: with SMTP id 96mr19886392otx.118.1618948847684; Tue, 20 Apr 2021 13:00:47 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id e20sm8797otl.15.2021.04.20.13.00.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Apr 2021 13:00:47 -0700 (PDT) Received: (nullmailer pid 3717287 invoked by uid 1000); Tue, 20 Apr 2021 20:00:45 -0000 Date: Tue, 20 Apr 2021 15:00:45 -0500 From: Rob Herring To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Lee Jones , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Florian Fainelli , Vivek Unune , bcm-kernel-feedback-list@broadcom.com, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH robh dt/next] dt-bindings: mfd: add Broadcom CRU Message-ID: <20210420200045.GA3710852@robh.at.kernel.org> References: <20210415062839.11713-1-zajec5@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210415062839.11713-1-zajec5@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210420_130049_599344_67FB8492 X-CRM114-Status: GOOD ( 20.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBBcHIgMTUsIDIwMjEgYXQgMDg6Mjg6MzlBTSArMDIwMCwgUmFmYcWCIE1pxYJlY2tp IHdyb3RlOgo+IEZyb206IFJhZmHFgiBNacWCZWNraSA8cmFmYWxAbWlsZWNraS5wbD4KPiAKPiBD UlUgaXMgYSBibG9jayB1c2VkIGluIGUuZy4gTm9ydGhzdGFyIGRldmljZXMuIEl0IGNhbiBiZSBz ZWVuIGluIHRoZQo+IGJjbTUzMDF4LmR0c2kgYW5kIHRoaXMgYmluZGluZyBkb2N1bWVudHMgaXRz IHByb3BlciB1c2FnZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBSYWZhxYIgTWnFgmVja2kgPHJhZmFs QG1pbGVja2kucGw+Cj4gLS0tCj4gVGhpcyBpcyByZXdvcmtlZCB2ZXJzaW9uIG9mIHRoZQo+IFtQ QVRDSCByb2JoIG5leHRdIGR0LWJpbmRpbmdzOiBidXM6IGFkZCBCcm9hZGNvbSBDUlUKPiBodHRw czovL3BhdGNod29yay5vemxhYnMub3JnL3Byb2plY3QvZGV2aWNldHJlZS1iaW5kaW5ncy9wYXRj aC8yMDIxMDMwOTE0MjI0MS4xNjI1OS0xLXphamVjNUBnbWFpbC5jb20vCj4gLS0tCj4gIC4uLi9k ZXZpY2V0cmVlL2JpbmRpbmdzL21mZC9icmNtLGNydS55YW1sICAgICB8IDQ2ICsrKysrKysrKysr KysrKysrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDQ2IGluc2VydGlvbnMoKykKPiAgY3JlYXRlIG1v ZGUgMTAwNjQ0IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9tZmQvYnJjbSxjcnUu eWFtbAo+IAo+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mv bWZkL2JyY20sY3J1LnlhbWwgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbWZk L2JyY20sY3J1LnlhbWwKPiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+IGluZGV4IDAwMDAwMDAwMDAw MC4uZjViY2U2NDUzYzMzCj4gLS0tIC9kZXYvbnVsbAo+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2 aWNldHJlZS9iaW5kaW5ncy9tZmQvYnJjbSxjcnUueWFtbAo+IEBAIC0wLDAgKzEsNDYgQEAKPiAr IyBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjogR1BMLTIuMC1vbmx5IE9SIEJTRC0yLUNsYXVzZQo+ ICslWUFNTCAxLjIKPiArLS0tCj4gKyRpZDogaHR0cDovL2RldmljZXRyZWUub3JnL3NjaGVtYXMv bWZkL2JyY20sY3J1LnlhbWwjCj4gKyRzY2hlbWE6IGh0dHA6Ly9kZXZpY2V0cmVlLm9yZy9tZXRh LXNjaGVtYXMvY29yZS55YW1sIwo+ICsKPiArdGl0bGU6IEJyb2FkY29tIENSVQo+ICsKPiArbWFp bnRhaW5lcnM6Cj4gKyAgLSBSYWZhxYIgTWnFgmVja2kgPHJhZmFsQG1pbGVja2kucGw+Cj4gKwo+ ICtkZXNjcmlwdGlvbjogfAo+ICsgIEJyb2FkY29tIENSVSAoIkNsb2NrIGFuZCBSZXNldCBVbml0 IiBvciAiQ2VudHJhbCBSZXNvdXJjZSBVbml0IikgaXMgYSBoYXJkd2FyZQo+ICsgIGJsb2NrIGdy b3VwaW5nIHNtYWxsZXIgYmxvY2tzLiBPbiBCcm9hZGNvbSBOb3J0aHN0YXIgcGxhdGZvcm0gaXQg Y29udGFpbnMgZS5nLgo+ICsgIGNsb2NrcywgcGluY3RybCwgVVNCIFBIWSBhbmQgdGhlcm1hbC4K CkFzIEkgc2FpZCBiZWZvcmUsIHRoaXMgbmVlZHMgdG8gYmUgYSBjb21wbGV0ZSBiaW5kaW5nLgoK PiArCj4gK3Byb3BlcnRpZXM6Cj4gKyAgY29tcGF0aWJsZToKPiArICAgIGl0ZW1zOgo+ICsgICAg ICAtIGVudW06Cj4gKyAgICAgICAgICAtIGJyY20sbnMtY3J1Cj4gKyAgICAgIC0gY29uc3Q6IHNp bXBsZS1tZmQKCkFzIG9mIG5vdywgaXQgaXMgbm90IGEgJ3NpbXBsZS1tZmQnIGJlY2F1c2UgdGhl cmUgYXJlIG5vIGRlZmluZWQgCmNoaWxkcmVuLgoKPiArCj4gKyAgcmVnOgo+ICsgICAgZGVzY3Jp cHRpb246IENSVSByZWdpc3RlcnMKPiArCj4gKyAgIiNhZGRyZXNzLWNlbGxzIjoKPiArICAgIGNv bnN0OiAxCj4gKwo+ICsgICIjc2l6ZS1jZWxscyI6Cj4gKyAgICBjb25zdDogMQo+ICsKPiArYWRk aXRpb25hbFByb3BlcnRpZXM6IHRydWUKClRoaXMgbmVlZHMgdG8gYmUgJ2ZhbHNlJyAoYW5kIHRo ZW4gYW55IGNoaWxkIG5vZGVzIGRlZmluZWQpLgoKPiArCj4gK3JlcXVpcmVkOgo+ICsgIC0gcmVn Cj4gKwo+ICtleGFtcGxlczoKPiArICAtIHwKPiArICAgIGNydS1idXNAMTgwMGMxMDAgewo+ICsg ICAgICBjb21wYXRpYmxlID0gImJyY20sbnMtY3J1IiwgInNpbXBsZS1tZmQiOwo+ICsgICAgICBy ZWcgPSA8MHgxODAwYzEwMCAweDFkMD47Cj4gKyAgICAgIHJhbmdlczsKPiArICAgICAgI2FkZHJl c3MtY2VsbHMgPSA8MT47Cj4gKyAgICAgICNzaXplLWNlbGxzID0gPDE+Owo+ICsgICAgfTsKPiAt LSAKPiAyLjI2LjIKPiAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LWFybS1rZXJuZWwK