From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4828C433ED for ; Tue, 20 Apr 2021 21:50:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8BC0261411 for ; Tue, 20 Apr 2021 21:50:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234191AbhDTVu7 (ORCPT ); Tue, 20 Apr 2021 17:50:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234218AbhDTVup (ORCPT ); Tue, 20 Apr 2021 17:50:45 -0400 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 168B3C06138F for ; Tue, 20 Apr 2021 14:50:11 -0700 (PDT) Received: by mail-pl1-x62e.google.com with SMTP id n10so9286842plc.0 for ; Tue, 20 Apr 2021 14:50:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TgjLxTMswgoGuX5Ufpd99mf4WDXQ7EH22iq7Xe02XNg=; b=ADzfPOozkAyPGGkprom2jYtHCQwH6uB1cl0/Z+8TbX+7HImHE4WHLpNxw6M8aIx9FA 7wRPPnFQT87XvfdZ/kCEuPm2w4Cq1lDCJ9PnLvhiyYZdgpKbpD86kSKKmbHaFFgfpAIB xMD6Bqyefxk0KdY7+oRIlSKLLna05jDv/u910= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TgjLxTMswgoGuX5Ufpd99mf4WDXQ7EH22iq7Xe02XNg=; b=WZYlvYvL01jt+rJpGzibUEUCo1G4aUOdf6BjEJily+gfPm6gufQNbkVVZ3bbdRFXtb GX3E2yA/0Fxh2YaDAw94kN9K6RQjRZon1fS1oqwcNCcP/bzypsBF5/ea7uC+GlWpGxJ/ YJ751X5bvvjG1oZNaUn+YmzCwAxw8iqHYhPNup7o5OboyDKZc7EB6Hco1MDYI3BilxmR 2JyTrh6lb44RceGhSCR106oo2iz3xfB9XYPNQRIOBfdnTHWrINCFR9Y+zBav4qFlaSGz Ohg783+l7ogEFWEpuj16WhubPW3mxi2RPoZ1pH/Zibjpp6t/TGeaZX1LSG5qjJSBJK7Q /5sA== X-Gm-Message-State: AOAM530io+dg6WQtgdrvNimLtFJLN2aKmeUiw+T1Mhk1XtL6GsOLBkZA Z1n+9PRHcdwdiGgQDno93Zd9xQ== X-Google-Smtp-Source: ABdhPJyYSt/sp/vHAPAJ0wTY88n203xox8pvJ907wdKtGaU3egQTlP7ZTjlkH6j9/lBlPwBpRsB/Xg== X-Received: by 2002:a17:902:64:b029:eb:1827:de61 with SMTP id 91-20020a1709020064b02900eb1827de61mr30793889pla.32.1618955410684; Tue, 20 Apr 2021 14:50:10 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:201:bf8b:4b8b:2315:3719]) by smtp.gmail.com with ESMTPSA id c21sm31481pfo.91.2021.04.20.14.50.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Apr 2021 14:50:10 -0700 (PDT) From: Stephen Boyd To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, Jiri Olsa , Alexei Starovoitov , Jessica Yu , Evan Green , Hsin-Yi Wang , Petr Mladek , Steven Rostedt , Andy Shevchenko , Matthew Wilcox Subject: [PATCH v5 07/13] x86/dumpstack: Use %pSb/%pBb for backtrace printing Date: Tue, 20 Apr 2021 14:49:57 -0700 Message-Id: <20210420215003.3510247-8-swboyd@chromium.org> X-Mailer: git-send-email 2.31.1.368.gbe11c130af-goog In-Reply-To: <20210420215003.3510247-1-swboyd@chromium.org> References: <20210420215003.3510247-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Let's use the new printk formats to print the stacktrace entries when printing a backtrace to the kernel logs. This will include any module's build ID[1] in it so that offline/crash debugging can easily locate the debuginfo for a module via something like debuginfod[2]. Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Cc: Jiri Olsa Cc: Alexei Starovoitov Cc: Jessica Yu Cc: Evan Green Cc: Hsin-Yi Wang Cc: Petr Mladek Cc: Steven Rostedt Cc: Andy Shevchenko Cc: Matthew Wilcox Link: https://fedoraproject.org/wiki/Releases/FeatureBuildId [1] Link: https://sourceware.org/elfutils/Debuginfod.html [2] Signed-off-by: Stephen Boyd --- arch/x86/kernel/dumpstack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c index 299c20f0a38b..ea4fe192189d 100644 --- a/arch/x86/kernel/dumpstack.c +++ b/arch/x86/kernel/dumpstack.c @@ -69,7 +69,7 @@ static void printk_stack_address(unsigned long address, int reliable, const char *log_lvl) { touch_nmi_watchdog(); - printk("%s %s%pB\n", log_lvl, reliable ? "" : "? ", (void *)address); + printk("%s %s%pBb\n", log_lvl, reliable ? "" : "? ", (void *)address); } static int copy_code(struct pt_regs *regs, u8 *buf, unsigned long src, -- https://chromeos.dev