From: Guenter Roeck <linux@roeck-us.net>
To: Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: pci-legacy: revert "use generic pci_enable_resources"
Date: Tue, 20 Apr 2021 15:56:30 -0700 [thread overview]
Message-ID: <20210420225630.GA223531@roeck-us.net> (raw)
In-Reply-To: <20210420063942.7041-1-ilya.lipnitskiy@gmail.com>
On Mon, Apr 19, 2021 at 11:39:43PM -0700, Ilya Lipnitskiy wrote:
> This mostly reverts commit 99bca615d895 ("MIPS: pci-legacy: use generic
> pci_enable_resources"). Fixes regressions such as:
> ata_piix 0000:00:0a.1: can't enable device: BAR 0 [io 0x01f0-0x01f7] not
> claimed
> ata_piix: probe of 0000:00:0a.1 failed with error -22
>
> The only changes from the strict revert are to fix checkpatch errors:
> ERROR: spaces required around that '=' (ctx:VxV)
> #33: FILE: arch/mips/pci/pci-legacy.c:252:
> + for (idx=0; idx < PCI_NUM_RESOURCES; idx++) {
> ^
>
> ERROR: do not use assignment in if condition
> #67: FILE: arch/mips/pci/pci-legacy.c:284:
> + if ((err = pcibios_enable_resources(dev, mask)) < 0)
>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Guenter
next prev parent reply other threads:[~2021-04-20 22:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 3:12 [PATCH v2 0/8] MIPS: fixes for PCI legacy drivers (rt2880, rt3883) Ilya Lipnitskiy
2021-04-14 3:12 ` [PATCH v2 1/8] MIPS: pci-rt2880: fix slot 0 configuration Ilya Lipnitskiy
2021-04-14 3:12 ` [PATCH v2 2/8] MIPS: pci-rt2880: remove unneeded locks Ilya Lipnitskiy
2021-04-15 8:07 ` Sergey Ryazanov
2021-04-14 3:12 ` [PATCH v2 3/8] MIPS: pci-rt3883: trivial: remove unused variable Ilya Lipnitskiy
2021-04-14 3:12 ` [PATCH v2 4/8] MIPS: pci-rt3883: more accurate DT error messages Ilya Lipnitskiy
2021-04-14 3:12 ` [PATCH v2 5/8] MIPS: pci-legacy: stop using of_pci_range_to_resource Ilya Lipnitskiy
2021-04-16 16:00 ` Liviu Dudau
2021-04-14 3:12 ` [PATCH v2 6/8] MIPS: pci-legacy: remove redundant info messages Ilya Lipnitskiy
2021-04-14 3:12 ` [PATCH v2 7/8] MIPS: pci-legacy: remove busn_resource field Ilya Lipnitskiy
2021-04-14 3:12 ` [PATCH v2 8/8] MIPS: pci-legacy: use generic pci_enable_resources Ilya Lipnitskiy
2021-04-20 5:23 ` Guenter Roeck
2021-04-20 6:39 ` [PATCH] MIPS: pci-legacy: revert "use generic pci_enable_resources" Ilya Lipnitskiy
2021-04-20 22:56 ` Guenter Roeck [this message]
2021-04-21 12:02 ` Thomas Bogendoerfer
2021-04-16 7:22 ` [PATCH v2 0/8] MIPS: fixes for PCI legacy drivers (rt2880, rt3883) Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210420225630.GA223531@roeck-us.net \
--to=linux@roeck-us.net \
--cc=ilya.lipnitskiy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.