From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67A34C43617 for ; Wed, 21 Apr 2021 13:16:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 399936144C for ; Wed, 21 Apr 2021 13:16:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242843AbhDUNQR (ORCPT ); Wed, 21 Apr 2021 09:16:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:52158 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242340AbhDUNKF (ORCPT ); Wed, 21 Apr 2021 09:10:05 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C43176143B; Wed, 21 Apr 2021 13:09:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619010572; bh=v8XqbaWDsCTh/eqqJjgZUGkLkeNt2H0yrxWwioMDIvk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eALUEUhLzVil8kHOxCrj7yKOwvNqxs7iC0OxZDiEAKmGBVb6jzrJOBGrpjJOgOC7l Vr0Ez6xi746XxhKQqGL10rKsJPgdL6Wu7Ohkc3eQmeGgT41wod8Sj501k1wAcT30M0 61NsTeZNzZZ3C0aGkxumgTz2DofccDe9MMC63Sbg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Kangjie Lu , Sean Young , Mauro Carvalho Chehab Subject: [PATCH 149/190] Revert "media: lgdt3306a: fix a missing check of return value" Date: Wed, 21 Apr 2021 15:00:24 +0200 Message-Id: <20210421130105.1226686-150-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210421130105.1226686-1-gregkh@linuxfoundation.org> References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This reverts commit c9b7d8f252a5a6f8ca6e948151367cbc7bc4b776. Commits from @umn.edu addresses have been found to be submitted in "bad faith" to try to test the kernel community's ability to review "known malicious" changes. The result of these submissions can be found in a paper published at the 42nd IEEE Symposium on Security and Privacy entitled, "Open Source Insecurity: Stealthily Introducing Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University of Minnesota) and Kangjie Lu (University of Minnesota). Because of this, all submissions from this group must be reverted from the kernel tree and will need to be re-reviewed again to determine if they actually are a valid fix. Until that work is complete, remove this change to ensure that no problems are being introduced into the codebase. Cc: Kangjie Lu Cc: Sean Young Cc: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/media/dvb-frontends/lgdt3306a.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/media/dvb-frontends/lgdt3306a.c b/drivers/media/dvb-frontends/lgdt3306a.c index 722576f1732a..f34263a33ede 100644 --- a/drivers/media/dvb-frontends/lgdt3306a.c +++ b/drivers/media/dvb-frontends/lgdt3306a.c @@ -1690,10 +1690,7 @@ static int lgdt3306a_read_signal_strength(struct dvb_frontend *fe, case QAM_256: case QAM_AUTO: /* need to know actual modulation to set proper SNR baseline */ - ret = lgdt3306a_read_reg(state, 0x00a6, &val); - if (lg_chkerr(ret)) - goto fail; - + lgdt3306a_read_reg(state, 0x00a6, &val); if(val & 0x04) ref_snr = 2800; /* QAM-256 28dB */ else -- 2.31.1