From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH] fs/reiserfs/journal.c: delete useless variables Date: Wed, 21 Apr 2021 16:31:13 +0200 Message-ID: <20210421143113.GX8706@quack2.suse.cz> References: <1618278196-17749-1-git-send-email-tiantao6@hisilicon.com> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <1618278196-17749-1-git-send-email-tiantao6@hisilicon.com> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tian Tao Cc: jack@suse.cz, rdunlap@infradead.org, reiserfs-devel@vger.kernel.org On Tue 13-04-21 09:43:16, Tian Tao wrote: > The value of 'cn' is not used, so just delete it. > > Signed-off-by: Tian Tao Thanks. I've added the patch to my tree. Honza > --- > fs/reiserfs/journal.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c > index e98f993..9edc8e2 100644 > --- a/fs/reiserfs/journal.c > +++ b/fs/reiserfs/journal.c > @@ -461,7 +461,6 @@ int reiserfs_in_journal(struct super_block *sb, > b_blocknr_t * next_zero_bit) > { > struct reiserfs_journal *journal = SB_JOURNAL(sb); > - struct reiserfs_journal_cnode *cn; > struct reiserfs_list_bitmap *jb; > int i; > unsigned long bl; > @@ -497,13 +496,12 @@ int reiserfs_in_journal(struct super_block *sb, > bl = bmap_nr * (sb->s_blocksize << 3) + bit_nr; > /* is it in any old transactions? */ > if (search_all > - && (cn = > - get_journal_hash_dev(sb, journal->j_list_hash_table, bl))) { > + && (get_journal_hash_dev(sb, journal->j_list_hash_table, bl))) { > return 1; > } > > /* is it in the current transaction. This should never happen */ > - if ((cn = get_journal_hash_dev(sb, journal->j_hash_table, bl))) { > + if ((get_journal_hash_dev(sb, journal->j_hash_table, bl))) { > BUG(); > return 1; > } > -- > 2.7.4 > -- Jan Kara SUSE Labs, CR