From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B38E5C43460 for ; Wed, 21 Apr 2021 16:01:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 878636144D for ; Wed, 21 Apr 2021 16:01:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244164AbhDUQB4 (ORCPT ); Wed, 21 Apr 2021 12:01:56 -0400 Received: from mx2.suse.de ([195.135.220.15]:37890 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240784AbhDUQBy (ORCPT ); Wed, 21 Apr 2021 12:01:54 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DE750B4AE; Wed, 21 Apr 2021 16:01:19 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 9C7F3DA7AE; Wed, 21 Apr 2021 17:59:00 +0200 (CEST) Date: Wed, 21 Apr 2021 17:59:00 +0200 From: David Sterba To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Kangjie Lu , David Sterba Subject: Re: [PATCH 106/190] Revert "tty: ipwireless: fix missing checks for ioremap" Message-ID: <20210421155900.GB7604@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Kangjie Lu , David Sterba References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-107-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210421130105.1226686-107-gregkh@linuxfoundation.org> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 21, 2021 at 02:59:41PM +0200, Greg Kroah-Hartman wrote: > This reverts commit 1bbb1c318cd8a3a39e8c3e2e83d5e90542d6c3e3. > > Commits from @umn.edu addresses have been found to be submitted in "bad > faith" to try to test the kernel community's ability to review "known > malicious" changes. The result of these submissions can be found in a > paper published at the 42nd IEEE Symposium on Security and Privacy > entitled, "Open Source Insecurity: Stealthily Introducing > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > of Minnesota) and Kangjie Lu (University of Minnesota). > > Because of this, all submissions from this group must be reverted from > the kernel tree and will need to be re-reviewed again to determine if > they actually are a valid fix. Until that work is complete, remove this > change to ensure that no problems are being introduced into the > codebase. I've reviewed the patch at the time and now again with fresh eyes, but it's IMO a valid fix that would have to be done the same way after revert.