From: Francesco Zanella <francesco.zanella@vimar.com>
To: linux-watchdog@vger.kernel.org, wim@linux-watchdog.org,
linux@roeck-us.net
Cc: devicetree@vger.kernel.org, robh+dt@kernel.org,
linux-kernel@vger.kernel.org,
Francesco Zanella <francesco.zanella@vimar.com>
Subject: [PATCH 2/2] watchdog: gpio_wdt: add "start-at-boot" feature
Date: Wed, 21 Apr 2021 18:26:21 +0200 [thread overview]
Message-ID: <20210421162621.24910-3-francesco.zanella@vimar.com> (raw)
In-Reply-To: <20210421162621.24910-1-francesco.zanella@vimar.com>
If "start-at-boot" property is present in the device tree, start pinging
hw watchdog at probe, in order to take advantage of kernel configs:
- WATCHDOG_HANDLE_BOOT_ENABLED: Avoid possible reboot if hw watchdog was
been enabled before the kernel (by uboot for example) and userspace
doesn't take control of /dev/watchdog in time;
- WATCHDOG_OPEN_TIMEOUT: Reboot if userspace doesn't take control of
/dev/watchdog within the timeout.
Signed-off-by: Francesco Zanella <francesco.zanella@vimar.com>
---
drivers/watchdog/gpio_wdt.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/watchdog/gpio_wdt.c b/drivers/watchdog/gpio_wdt.c
index 0923201ce874..1e6f0322ab7a 100644
--- a/drivers/watchdog/gpio_wdt.c
+++ b/drivers/watchdog/gpio_wdt.c
@@ -31,6 +31,7 @@ struct gpio_wdt_priv {
struct gpio_desc *gpiod;
bool state;
bool always_running;
+ bool start_at_boot;
unsigned int hw_algo;
struct watchdog_device wdd;
};
@@ -147,6 +148,9 @@ static int gpio_wdt_probe(struct platform_device *pdev)
priv->always_running = of_property_read_bool(np,
"always-running");
+ priv->start_at_boot = of_property_read_bool(np,
+ "start-at-boot");
+
watchdog_set_drvdata(&priv->wdd, priv);
priv->wdd.info = &gpio_wdt_ident;
@@ -161,7 +165,7 @@ static int gpio_wdt_probe(struct platform_device *pdev)
watchdog_stop_on_reboot(&priv->wdd);
- if (priv->always_running)
+ if (priv->always_running || priv->start_at_boot)
gpio_wdt_start(&priv->wdd);
return devm_watchdog_register_device(dev, &priv->wdd);
--
2.17.1
next prev parent reply other threads:[~2021-04-21 16:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 16:26 [PATCH 0/2] GPIO WDT "start-at-boot" property Francesco Zanella
2021-04-21 16:26 ` [PATCH 1/2] dt-bindings: watchdog: gpio-wdt: add "start-at-boot" Francesco Zanella
2021-04-21 16:37 ` Guenter Roeck
2021-04-22 16:28 ` Francesco Zanella
2021-04-21 16:26 ` Francesco Zanella [this message]
2021-04-21 16:42 ` [PATCH 2/2] watchdog: gpio_wdt: add "start-at-boot" feature Guenter Roeck
2021-04-22 16:28 ` Francesco Zanella
2021-04-22 18:05 ` Guenter Roeck
2021-04-23 9:47 ` Francesco Zanella
2021-04-23 11:36 ` Rasmus Villemoes
2021-04-23 14:24 ` Francesco Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210421162621.24910-3-francesco.zanella@vimar.com \
--to=francesco.zanella@vimar.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.