From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 417F1C433B4 for ; Wed, 21 Apr 2021 22:52:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1C3A0613E6 for ; Wed, 21 Apr 2021 22:52:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343584AbhDUWwu (ORCPT ); Wed, 21 Apr 2021 18:52:50 -0400 Received: from mail-oi1-f178.google.com ([209.85.167.178]:39792 "EHLO mail-oi1-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235481AbhDUWwt (ORCPT ); Wed, 21 Apr 2021 18:52:49 -0400 Received: by mail-oi1-f178.google.com with SMTP id i81so43992171oif.6; Wed, 21 Apr 2021 15:52:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZfP+v08fbXOyQGmlXgs34y9m62CQJ9d66rbECIK0MBw=; b=Dd0tQaJJBFhGob251JdzNdw0wZj2fT81LhNPTPSlIEYY31ATxH55JwJQ1v5+52qBlt yu0wgqO7EE3ycpSrtCHxtbF/77kOUX2xWW42W6/nD5prBiMg+IbEaF8aKATdS2fcvy7Q zxsJ0ZmvSv3rHedkTWF9MHhRuj8wWwrLj/rmiV6GIhiGAtXDPz00TDRK5nRXCNFvBno9 9gG2mgw/fKJ60C3Zt2fhqFagu6B7EoHCOMCwh3oTpFTgK6ASPnNGUwdVjZ5oLNLzGPil UG92kUZMNb9PDhQQZ1UsQepMy1aHR/x0ZRjkdrIKN5AHAPrp7t8VcfNgzNfgBkBOuZlZ SDzQ== X-Gm-Message-State: AOAM533z5uPGpPwCrzzLjVQ3BUPrc/oncgllu5MtttTSpy13cojgaKaF QvMhWqRJ1r5ls2fZp2hATA== X-Google-Smtp-Source: ABdhPJxM2G9XHRqVP6I+dA7m+p0XdMvLC72ekhQnsH+Rh1qvuIPrfU3LUCdqIWAsIOh3/pRWmS17Pg== X-Received: by 2002:aca:44b:: with SMTP id 72mr216449oie.68.1619045534389; Wed, 21 Apr 2021 15:52:14 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id d17sm181223oth.19.2021.04.21.15.52.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Apr 2021 15:52:13 -0700 (PDT) Received: (nullmailer pid 1761097 invoked by uid 1000); Wed, 21 Apr 2021 22:52:12 -0000 Date: Wed, 21 Apr 2021 17:52:12 -0500 From: Rob Herring To: Nishanth Menon Cc: Jens Wiklander , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] dt-bindings: arm: firmware: Convert linaro,optee-tz to json schema Message-ID: <20210421225212.GB1750844@robh.at.kernel.org> References: <20210416222518.15801-1-nm@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210416222518.15801-1-nm@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 16, 2021 at 05:25:18PM -0500, Nishanth Menon wrote: > Convert linaro,optee-tz to json schema format for better documentation > and error checks. > > NOTE: > 1. This change does introduce a stricter naming convention for > optee nodes. > 2. We do have false positive checkpatch warning with this patch: > "DT binding docs and includes should be a separate patch" Not really something that needs to be in the commit msg. I'm aware of the issue, just haven't gotten around to fixing it. > Signed-off-by: Nishanth Menon > --- > .../bindings/arm/firmware/linaro,optee-tz.txt | 31 ---------- > .../arm/firmware/linaro,optee-tz.yaml | 62 +++++++++++++++++++ > 2 files changed, 62 insertions(+), 31 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt > create mode 100644 Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.yaml > > diff --git a/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt b/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt > deleted file mode 100644 > index d38834c67dff..000000000000 > --- a/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt > +++ /dev/null > @@ -1,31 +0,0 @@ > -OP-TEE Device Tree Bindings > - > -OP-TEE is a piece of software using hardware features to provide a Trusted > -Execution Environment. The security can be provided with ARM TrustZone, but > -also by virtualization or a separate chip. > - > -We're using "linaro" as the first part of the compatible property for > -the reference implementation maintained by Linaro. > - > -* OP-TEE based on ARM TrustZone required properties: > - > -- compatible : should contain "linaro,optee-tz" > - > -- method : The method of calling the OP-TEE Trusted OS. Permitted > - values are: > - > - "smc" : SMC #0, with the register assignments specified > - in drivers/tee/optee/optee_smc.h > - > - "hvc" : HVC #0, with the register assignments specified > - in drivers/tee/optee/optee_smc.h > - > - > - > -Example: > - firmware { > - optee { > - compatible = "linaro,optee-tz"; > - method = "smc"; > - }; > - }; > diff --git a/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.yaml b/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.yaml > new file mode 100644 > index 000000000000..6513b5ac8b2c > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.yaml > @@ -0,0 +1,62 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/firmware/linaro,optee-tz.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: OP-TEE Device Tree Bindings > + > +maintainers: > + - Jens Wiklander > + > +description: | > + OP-TEE is a piece of software using hardware features to provide a Trusted > + Execution Environment. The security can be provided with ARM TrustZone, but > + also by virtualization or a separate chip. > + > + We're using "linaro" as the first part of the compatible property for > + the reference implementation maintained by Linaro. > + > +properties: > + $nodename: > + const: 'optee' Don't need quotes. > + > + compatible: > + const: linaro,optee-tz > + > + method: > + description: The method of calling the OP-TEE Trusted OS. > + oneOf: > + - description: | > + SMC #0, with the register assignments specified > + in drivers/tee/optee/optee_smc.h > + items: > + - const: smc > + - description: | > + HVC #0, with the register assignments specified > + in drivers/tee/optee/optee_smc.h > + items: > + - const: hvc Please just do 'enum: [ smc, hvc ]' and rework to a single description. > + > +required: > + - compatible > + - method > + > +additionalProperties: false > + > +examples: > + - | > + firmware { > + optee { > + compatible = "linaro,optee-tz"; > + method = "smc"; > + }; > + }; > + > + - | > + firmware { > + optee { > + compatible = "linaro,optee-tz"; > + method = "hvc"; > + }; > + }; > -- > 2.31.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E17BC433ED for ; Wed, 21 Apr 2021 22:54:54 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9DD33613E1 for ; Wed, 21 Apr 2021 22:54:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9DD33613E1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fpiaPsiwG9Cp7xcXC9Vku5f0akVXsXDvZ5Sh6xK9dXs=; b=Vgnh8yvUSedGhPigD8ecTcXrr MEFt5FWcvo0bNbcmsyt17Q7LUxq5vnAXcNONbvhzkfqRickZruJ4zFMG+biD+uXgo04PmChYjKiTg lJfyy6wDId4Jf8jSODziT8Tcs5dho87on82f0Yxki/3/3eGNfMTZAvNlLuzi5H0nNFl0VPgg64HnE Nm+QAFnfYqYXUC57LsXdt0QIy1RWpE8UArm8S5Ay5UcZFMg4hXm6dLTfi6t5u3BinaWe+ABqtMCjP QlvvecO1YKJbjSwjD02vyGfhAQFBUlZ3b0Lni0kLW8Qha/Mx2s6mKToPQr3TWd0wbNqRi5bjVTV9i HZm+hHMLQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lZLiJ-00FKiB-HV; Wed, 21 Apr 2021 22:52:56 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZLhi-00FKhh-Ce for linux-arm-kernel@desiato.infradead.org; Wed, 21 Apr 2021 22:52:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ZfP+v08fbXOyQGmlXgs34y9m62CQJ9d66rbECIK0MBw=; b=Qrq9uyrI3WhJK0IqStWJ4/aziS p2vO5bG0Y0BsPz7SuV5Eh1W4O+MhH28jMMuFdSIOUpWO8OsJR6tvIxLNk0B9NGMIPrKdM3begv7ll YgHkXQsmi1hLmuwLHeQADeDKSxTd40B+wveXRmmYhvMGmPGFvbmAcAhmbMXkTqG/ez6bdkPTozsmT 2dOh/+aLsyPGc2gT02nXV4jH1ZgkWcTiTmcKnefaV2ewZuSMUmNesmCY3b8LVf+cBo7/dImFvx0AL 4yWbanKms0PaM0a+WPJvwFoOwAvTAD+VokLSnACAvud/eHmci4P3NcyELPunBygHrjh7KOY2VuED2 iniBb9wQ==; Received: from mail-oi1-f182.google.com ([209.85.167.182]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZLhf-00DF7h-JB for linux-arm-kernel@lists.infradead.org; Wed, 21 Apr 2021 22:52:17 +0000 Received: by mail-oi1-f182.google.com with SMTP id d25so6485318oij.5 for ; Wed, 21 Apr 2021 15:52:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZfP+v08fbXOyQGmlXgs34y9m62CQJ9d66rbECIK0MBw=; b=bINuKz0ItTI3DtaLA5XigHsXV0RgG96X3X6bMuQy6fgEaQ+4JaXzD2N98e+7yR56sa V8MDZu/R9D3ZYDeeSqyQPBELUnKwOv5Ow6T56PPkFFbs9mReFRR3Vz2tWZzn9bNpLB7k J+Sj3thPGNh3jVfch4d3kt/bqcbj+IKXCLz9cEdjAuHPLjiWAhwqM5PYKaYhIr/pi5M+ SiHjPvyN357rmGu9D8dcKc9ewneATH5pfrJ2T/101f91+9H+HyRHsUbU91gu89QYQAgT dHamNj07RiQ6QazblgNcA0afxtfQv5Fxw/MnBoi61y9gc53BhkQewIKDM/kSOfHwYjTP JzMw== X-Gm-Message-State: AOAM532ZeOnkuDhCqd8wVsWu91w9KKhXaJjW4xTyRilSG9Nf2KneTVd6 9m/xsEgqrDz8XfS2onYGdw== X-Google-Smtp-Source: ABdhPJxM2G9XHRqVP6I+dA7m+p0XdMvLC72ekhQnsH+Rh1qvuIPrfU3LUCdqIWAsIOh3/pRWmS17Pg== X-Received: by 2002:aca:44b:: with SMTP id 72mr216449oie.68.1619045534389; Wed, 21 Apr 2021 15:52:14 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id d17sm181223oth.19.2021.04.21.15.52.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Apr 2021 15:52:13 -0700 (PDT) Received: (nullmailer pid 1761097 invoked by uid 1000); Wed, 21 Apr 2021 22:52:12 -0000 Date: Wed, 21 Apr 2021 17:52:12 -0500 From: Rob Herring To: Nishanth Menon Cc: Jens Wiklander , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] dt-bindings: arm: firmware: Convert linaro,optee-tz to json schema Message-ID: <20210421225212.GB1750844@robh.at.kernel.org> References: <20210416222518.15801-1-nm@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210416222518.15801-1-nm@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210421_155215_664831_D6BD288B X-CRM114-Status: GOOD ( 25.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 16, 2021 at 05:25:18PM -0500, Nishanth Menon wrote: > Convert linaro,optee-tz to json schema format for better documentation > and error checks. > > NOTE: > 1. This change does introduce a stricter naming convention for > optee nodes. > 2. We do have false positive checkpatch warning with this patch: > "DT binding docs and includes should be a separate patch" Not really something that needs to be in the commit msg. I'm aware of the issue, just haven't gotten around to fixing it. > Signed-off-by: Nishanth Menon > --- > .../bindings/arm/firmware/linaro,optee-tz.txt | 31 ---------- > .../arm/firmware/linaro,optee-tz.yaml | 62 +++++++++++++++++++ > 2 files changed, 62 insertions(+), 31 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt > create mode 100644 Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.yaml > > diff --git a/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt b/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt > deleted file mode 100644 > index d38834c67dff..000000000000 > --- a/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt > +++ /dev/null > @@ -1,31 +0,0 @@ > -OP-TEE Device Tree Bindings > - > -OP-TEE is a piece of software using hardware features to provide a Trusted > -Execution Environment. The security can be provided with ARM TrustZone, but > -also by virtualization or a separate chip. > - > -We're using "linaro" as the first part of the compatible property for > -the reference implementation maintained by Linaro. > - > -* OP-TEE based on ARM TrustZone required properties: > - > -- compatible : should contain "linaro,optee-tz" > - > -- method : The method of calling the OP-TEE Trusted OS. Permitted > - values are: > - > - "smc" : SMC #0, with the register assignments specified > - in drivers/tee/optee/optee_smc.h > - > - "hvc" : HVC #0, with the register assignments specified > - in drivers/tee/optee/optee_smc.h > - > - > - > -Example: > - firmware { > - optee { > - compatible = "linaro,optee-tz"; > - method = "smc"; > - }; > - }; > diff --git a/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.yaml b/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.yaml > new file mode 100644 > index 000000000000..6513b5ac8b2c > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.yaml > @@ -0,0 +1,62 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/firmware/linaro,optee-tz.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: OP-TEE Device Tree Bindings > + > +maintainers: > + - Jens Wiklander > + > +description: | > + OP-TEE is a piece of software using hardware features to provide a Trusted > + Execution Environment. The security can be provided with ARM TrustZone, but > + also by virtualization or a separate chip. > + > + We're using "linaro" as the first part of the compatible property for > + the reference implementation maintained by Linaro. > + > +properties: > + $nodename: > + const: 'optee' Don't need quotes. > + > + compatible: > + const: linaro,optee-tz > + > + method: > + description: The method of calling the OP-TEE Trusted OS. > + oneOf: > + - description: | > + SMC #0, with the register assignments specified > + in drivers/tee/optee/optee_smc.h > + items: > + - const: smc > + - description: | > + HVC #0, with the register assignments specified > + in drivers/tee/optee/optee_smc.h > + items: > + - const: hvc Please just do 'enum: [ smc, hvc ]' and rework to a single description. > + > +required: > + - compatible > + - method > + > +additionalProperties: false > + > +examples: > + - | > + firmware { > + optee { > + compatible = "linaro,optee-tz"; > + method = "smc"; > + }; > + }; > + > + - | > + firmware { > + optee { > + compatible = "linaro,optee-tz"; > + method = "hvc"; > + }; > + }; > -- > 2.31.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel