All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Jones <drjones@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>, Jacob Xu <jacobhxu@google.com>,
	kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH] update git tree location in MAINTAINERS to point at gitlab
Date: Thu, 22 Apr 2021 10:03:05 +0200	[thread overview]
Message-ID: <20210422080305.pjmfwq45qhhwmzt2@gator> (raw)
In-Reply-To: <97adb2d3-47f4-385a-18b4-90572c9f486a@redhat.com>

On Thu, Apr 22, 2021 at 09:39:44AM +0200, Paolo Bonzini wrote:
> On 22/04/21 05:42, Thomas Huth wrote:
> > On 21/04/2021 21.16, Jacob Xu wrote:
> > > The MAINTAINERS file appears to have been forgotten during the migration
> > > to gitlab from the kernel.org. Let's update it now.
> > > 
> > > Signed-off-by: Jacob Xu <jacobhxu@google.com>
> > > ---
> > >   MAINTAINERS | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 54124f6..e0c8e99 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -55,7 +55,7 @@ Maintainers
> > >   -----------
> > >   M: Paolo Bonzini <pbonzini@redhat.com>
> > >   L: kvm@vger.kernel.org
> > > -T: git://git.kernel.org/pub/scm/virt/kvm/kvm-unit-tests.git
> > > +T:    https://gitlab.com/kvm-unit-tests/kvm-unit-tests.git
> > 
> > Reviewed-by: Thomas Huth <thuth@redhat.com>
> 
> You're too humble, Thomas. :)  Since Drew and you have commit access this
> could very well be:
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ef7e9af..0082e58 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -54,8 +54,9 @@ Descriptions of section entries:
>  Maintainers
>  -----------
>  M: Paolo Bonzini <pbonzini@redhat.com>
> +M: Thomas Huth <thuth@redhat.com>
> +M: Andrew Jones <drjones@redhat.com>
>  L: kvm@vger.kernel.org
> -T: git://git.kernel.org/pub/scm/virt/kvm/kvm-unit-tests.git
> +T: https://gitlab.com/kvm-unit-tests/kvm-unit-tests.git
> 
>  Architecture Specific Code:
>  ---------------------------
> 
> And also, while at it:
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ef7e9af..0082e58 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -92,3 +94,4 @@ M: Paolo Bonzini <pbonzini@redhat.com>
>  L: kvm@vger.kernel.org
>  F: x86/*
>  F: lib/x86/*
> +T: https://gitlab.com/bonzini/kvm-unit-tests.git
> 
>

I also use my own gitlab for arm/queue. So we could also add

diff --git a/MAINTAINERS b/MAINTAINERS
index 54124f6f1a5e..0a2f3a645bb3 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -67,6 +67,7 @@ L: kvmarm@lists.cs.columbia.edu
 F: arm/*
 F: lib/arm/*
 F: lib/arm64/*
+T: https://gitlab.com/rhdrjones/kvm-unit-tests.git
 
 POWERPC
 M: Laurent Vivier <lvivier@redhat.com>


Thanks,
drew


  reply	other threads:[~2021-04-22  8:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-21 19:16 [kvm-unit-tests PATCH] update git tree location in MAINTAINERS to point at gitlab Jacob Xu
2021-04-22  3:42 ` Thomas Huth
2021-04-22  7:39   ` Paolo Bonzini
2021-04-22  8:03     ` Andrew Jones [this message]
2021-04-22  8:57     ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210422080305.pjmfwq45qhhwmzt2@gator \
    --to=drjones@redhat.com \
    --cc=jacobhxu@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.