From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 8F2C4C433B4
	for <netdev@archiver.kernel.org>; Thu, 22 Apr 2021 16:26:38 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 64D2561077
	for <netdev@archiver.kernel.org>; Thu, 22 Apr 2021 16:26:38 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S236625AbhDVQ1M (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Thu, 22 Apr 2021 12:27:12 -0400
Received: from mail.kernel.org ([198.145.29.99]:60790 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S236058AbhDVQ1L (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 22 Apr 2021 12:27:11 -0400
Received: by mail.kernel.org (Postfix) with ESMTPSA id AF1B661077;
        Thu, 22 Apr 2021 16:26:35 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1619108796;
        bh=mNGR1kwwmLfDQaatKtt0BJE28FQuiJQhoYYBiS31MZw=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=b3v82huMOcUHGYGKwzrowyWa9IoEHv/lHcbTsdACq/X61RnZBAiH35oEaZmgVD39K
         2j8x2dnpe4t/c8/E5Z3yC9p6abJd7Yc5UdcnUcNAnixxpE6aIrhQLjnlDyRdNtJPMP
         sJ/dPe0Hr9ZfEF/UGV/NBmwMA0W0zJGME2aGSVvvoGA1ZAD+XP4trnU0TL0Jp7C5C/
         sUDEjNA2F6BJX9kZ+2m2UUiR98R4TKogvc6WZe6Zx5W2/RgXgZwxFOT69QLvIx4QG9
         C+Ym9fUXSsJMlEoa8m1FRm0yegdDGYiwrfJ8trfPCiU66prZNoIe6/wlBj6/dMQhwR
         8OkRTkPSyiiJQ==
Date:   Thu, 22 Apr 2021 09:26:34 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Ido Schimmel <idosch@idosch.org>
Cc:     netdev@vger.kernel.org, davem@davemloft.net, mlxsw@nvidia.com,
        Ido Schimmel <idosch@nvidia.com>
Subject: Re: [PATCH net-next] netdevsim: Only use sampling truncation length
 when valid
Message-ID: <20210422092634.18f23f8c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <YIGikZ2xZhH7ZRZc@shredder.lan>
References: <20210422135050.2429936-1-idosch@idosch.org>
        <20210422091426.6fda8280@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
        <YIGikZ2xZhH7ZRZc@shredder.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Thu, 22 Apr 2021 19:21:37 +0300 Ido Schimmel wrote:
> > > +	md->trunc_size = psample->trunc_size ? psample->trunc_size : len;  
> > 
> > nit:  ... = psample->trunc_size ? : len;  ?  
> 
> Yea, I don't find this form too readable and always prefer the one I
> used when it fits in a single line :)

Fair enough.