All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukasz Luba <lukasz.luba@arm.com>
To: linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org
Cc: linux-pm@vger.kernel.org, amitk@kernel.org, rui.zhang@intel.com,
	lukasz.luba@arm.com
Subject: [PATCH v4 0/3] Improve IPA mechanisms in low temperature state
Date: Thu, 22 Apr 2021 12:43:05 +0100	[thread overview]
Message-ID: <20210422114308.29684-1-lukasz.luba@arm.com> (raw)

Hi all,

This v4 patch set aims to address the issues present in IPA when the
temperature is below the first trip point and cooling devices are not
throttled.
The last patch 1/3 is co-developed by Daniel, who presented the code
during v2 review. I have created a helper function based on his idea,
which can now be used inside IPA governor lock protected code. 
The patch 2/3 adds a basic check of cooling devices power to keep the
internal statistics fresh. This allows to avoid issue when the statistics
cover very long period, because they were not maintained.
The patch 3/3 addresses an issue described in bugzilla [1], which is:
unnecessary updating cooling devices when their state has not changed
because they are not throttled. This update triggers sending an event,
which should be avoided. Thus, patch 2/3 adds a tracking mechanism if
the update was triggered and makes sure it will be done only once when
the temperature continue to stay below first trip point.

changelog:
v4:
- reordered the patches, patch 3/3 from v3 is now 1/3 
v3:
- new patch 3/3 co-developed with Daniel
v2:
- patch 2/2 uses now simple 'update' bool flag and information from
  'tz->last_temperature'
- patch 1/2 has small change in the comment
- re-based on top of today's thermal/next branch

Regards,
Lukasz Luba

[1] https://bugzilla.kernel.org/show_bug.cgi?id=212501

Lukasz Luba (3):
  thermal: create a helper __thermal_cdev_update() without a lock
  thermal: power_allocator: maintain the device statistics from going
    stale
  thermal: power_allocator: update once cooling devices when temp is low

 drivers/thermal/gov_power_allocator.c | 21 +++++++++++++++++----
 drivers/thermal/thermal_core.h        |  1 +
 drivers/thermal/thermal_helpers.c     | 27 +++++++++++++++++----------
 3 files changed, 35 insertions(+), 14 deletions(-)

-- 
2.17.1


             reply	other threads:[~2021-04-22 11:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-22 11:43 Lukasz Luba [this message]
2021-04-22 11:43 ` [PATCH v4 1/3] thermal: create a helper __thermal_cdev_update() without a lock Lukasz Luba
2021-04-27 19:44   ` [thermal: thermal/next] thermal/core: Create " thermal-bot for Lukasz Luba
2021-04-22 11:43 ` [PATCH v4 2/3] thermal: power_allocator: maintain the device statistics from going stale Lukasz Luba
2021-04-27 19:44   ` [thermal: thermal/next] thermal/core/power_allocator: Maintain " thermal-bot for Lukasz Luba
2021-04-22 11:43 ` [PATCH v4 3/3] thermal: power_allocator: update once cooling devices when temp is low Lukasz Luba
2021-04-27 19:44   ` [thermal: thermal/next] thermal/core/power_allocator: Update " thermal-bot for Lukasz Luba
2021-04-22 17:30 ` [PATCH v4 0/3] Improve IPA mechanisms in low temperature state Daniel Lezcano
2021-04-22 17:33   ` Lukasz Luba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210422114308.29684-1-lukasz.luba@arm.com \
    --to=lukasz.luba@arm.com \
    --cc=amitk@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.