From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C491FC43460 for ; Thu, 22 Apr 2021 12:18:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 79C3461458 for ; Thu, 22 Apr 2021 12:18:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236160AbhDVMTD (ORCPT ); Thu, 22 Apr 2021 08:19:03 -0400 Received: from mx2.suse.de ([195.135.220.15]:33102 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235232AbhDVMTC (ORCPT ); Thu, 22 Apr 2021 08:19:02 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DFBBBADD7; Thu, 22 Apr 2021 12:18:26 +0000 (UTC) Date: Thu, 22 Apr 2021 14:18:29 +0200 From: Borislav Petkov To: Paolo Bonzini Cc: Sean Christopherson , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Lendacky , Brijesh Singh Subject: Re: [PATCH v5 06/15] x86/sev: Drop redundant and potentially misleading 'sev_enabled' Message-ID: <20210422121829.GD6361@zn.tnic> References: <20210422021125.3417167-1-seanjc@google.com> <20210422021125.3417167-7-seanjc@google.com> <8f1fa7e0-b940-6d1d-1a74-11014901fc0d@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8f1fa7e0-b940-6d1d-1a74-11014901fc0d@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 22, 2021 at 02:05:46PM +0200, Paolo Bonzini wrote: > Boris or another x86 maintainer, can you ack this small patch? We would > like to use sev_enabled as a static variable in KVM. Yeah, all those "is anything SEV-like enabled" mechanisms would need refactoring before it goes nuts. I think we should do this bool sev_feature_enabled(enum sev_feature) thing at some point: https://lkml.kernel.org/r/20210421144402.GB5004@zn.tnic And TDX would probably need something similar. Thx. -- Regards/Gruss, Boris. SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg