From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04535C433B4 for ; Thu, 22 Apr 2021 14:20:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C478461421 for ; Thu, 22 Apr 2021 14:20:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236998AbhDVOUy (ORCPT ); Thu, 22 Apr 2021 10:20:54 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:58106 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236496AbhDVOUw (ORCPT ); Thu, 22 Apr 2021 10:20:52 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 13MEKClj074412; Thu, 22 Apr 2021 09:20:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1619101212; bh=eLCNEeT9z0g1L4VWRS3pYMec87wOC2TuVWX5CHcWjjc=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=JX2Qi2RVy+cgLm4xZG0ELG0EljMsR2mUXfYv3oa+z9aF47wFE+SjUecuwFEDCfDjs dNO0AKFSR98+cG6xBzfyj7/P9Hqx9TLyBW/4dyc+pC+xazht9tuLnGETnlgs0+f3hC Uq6Yj9jzR0cLlz5qf1PW6nAiSFl7DCv5dX9Z7Tek= Received: from DFLE115.ent.ti.com (dfle115.ent.ti.com [10.64.6.36]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 13MEKCYg067110 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 22 Apr 2021 09:20:12 -0500 Received: from DFLE108.ent.ti.com (10.64.6.29) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Thu, 22 Apr 2021 09:20:12 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Thu, 22 Apr 2021 09:20:12 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 13MEKCNu104239; Thu, 22 Apr 2021 09:20:12 -0500 Date: Thu, 22 Apr 2021 09:20:12 -0500 From: Nishanth Menon To: Rob Herring CC: Jens Wiklander , , , Subject: Re: [PATCH] dt-bindings: arm: firmware: Convert linaro,optee-tz to json schema Message-ID: <20210422142012.lcjiy2gaoqllzlna@nervy> References: <20210416222518.15801-1-nm@ti.com> <20210421225212.GB1750844@robh.at.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20210421225212.GB1750844@robh.at.kernel.org> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17:52-20210421, Rob Herring wrote: > On Fri, Apr 16, 2021 at 05:25:18PM -0500, Nishanth Menon wrote: > > Convert linaro,optee-tz to json schema format for better documentation > > and error checks. > > > > NOTE: > > 1. This change does introduce a stricter naming convention for > > optee nodes. > > 2. We do have false positive checkpatch warning with this patch: > > "DT binding docs and includes should be a separate patch" > > Not really something that needs to be in the commit msg. I'm aware of > the issue, just haven't gotten around to fixing it. sure, thanks.. In this patch and my previous patches as well, I will move them all to diffstat comment. > > +properties: > > + $nodename: > > + const: 'optee' > > Don't need quotes. aarrgh.. yes, ofcourse. > > > + > > + compatible: > > + const: linaro,optee-tz > > + > > + method: > > + description: The method of calling the OP-TEE Trusted OS. > > + oneOf: > > + - description: | > > + SMC #0, with the register assignments specified > > + in drivers/tee/optee/optee_smc.h > > + items: > > + - const: smc > > + - description: | > > + HVC #0, with the register assignments specified > > + in drivers/tee/optee/optee_smc.h > > + items: > > + - const: hvc > > Please just do 'enum: [ smc, hvc ]' and rework to a single description. Sure, will do. thanks for the comments. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B08DFC433ED for ; Thu, 22 Apr 2021 14:22:05 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F276613CD for ; Thu, 22 Apr 2021 14:22:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F276613CD Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OBnZf1u0S/8WJn8Wzq32VZbacPaVDXyT8gNTEVHKzMg=; b=US3SP12PUzFBa1d8T5sHVrRwh ZcOjZKuaAYWUvlf7ZTzdJfTymG5SpeAx35sOLkalaSz1759tWHIgwUGgtxorgJQwZg+5M6TaiS+F/ 4fpjyzX6oPXGZmnvdi8hSh4k89hYFKJUd5Z+MJlVoxhbOWzgTZwE4V5gseUSOf0mjXOutzZSKtVXf tupZExtPhkwVEioUPyESrv0A8ltMntcqpeHf6k4ZDgQpxFHxWUvRBq+GXCOK15sJzbV3EcbswvH3D 1azs4Qy3zwK1Fz/B6D6Y8RglUevfTZfCQxRVg89PWbGoE2TzuHyQWOsdApkIL4g+ww57rSvigHT89 iCsC+KYZQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lZaBp-00Gsyj-Gt; Thu, 22 Apr 2021 14:20:22 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZaBm-00Gsy8-Mm for linux-arm-kernel@desiato.infradead.org; Thu, 22 Apr 2021 14:20:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:CC:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=eLCNEeT9z0g1L4VWRS3pYMec87wOC2TuVWX5CHcWjjc=; b=F4togy9qcT49lXVd0ZNfuAjeSf Y1xG/1KdrvTJjuk9NzFMxds9/wd0DlkJHGB8bA1K4PwtQByagS2kAJ5KF3ibA71Cf4WSaVUU98+2u Y6Uu/4jC3ulJe0yZXPkeQuYkRx1xeBBU0+YvG9UjbByDaNCmazEmFICM9SAvadyKB7CiuL7KQGCzp /+j5rjnVo8k8lVHmPwhoOAI2H0Y8ivFSRLArx56RKw1oe1F9SEewYLxov+cF37nKmUou1rPcChZLr dWEwtHl3nF06fD+G2NYvFT9vrly0O37XLll0NvI5sHHejznca5ononEZvq0j6ypnqE9HhOMLw3BS3 lyrO9xsA==; Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZaBj-00DkmH-Si for linux-arm-kernel@lists.infradead.org; Thu, 22 Apr 2021 14:20:17 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 13MEKClj074412; Thu, 22 Apr 2021 09:20:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1619101212; bh=eLCNEeT9z0g1L4VWRS3pYMec87wOC2TuVWX5CHcWjjc=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=JX2Qi2RVy+cgLm4xZG0ELG0EljMsR2mUXfYv3oa+z9aF47wFE+SjUecuwFEDCfDjs dNO0AKFSR98+cG6xBzfyj7/P9Hqx9TLyBW/4dyc+pC+xazht9tuLnGETnlgs0+f3hC Uq6Yj9jzR0cLlz5qf1PW6nAiSFl7DCv5dX9Z7Tek= Received: from DFLE115.ent.ti.com (dfle115.ent.ti.com [10.64.6.36]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 13MEKCYg067110 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 22 Apr 2021 09:20:12 -0500 Received: from DFLE108.ent.ti.com (10.64.6.29) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Thu, 22 Apr 2021 09:20:12 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Thu, 22 Apr 2021 09:20:12 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 13MEKCNu104239; Thu, 22 Apr 2021 09:20:12 -0500 Date: Thu, 22 Apr 2021 09:20:12 -0500 From: Nishanth Menon To: Rob Herring CC: Jens Wiklander , , , Subject: Re: [PATCH] dt-bindings: arm: firmware: Convert linaro,optee-tz to json schema Message-ID: <20210422142012.lcjiy2gaoqllzlna@nervy> References: <20210416222518.15801-1-nm@ti.com> <20210421225212.GB1750844@robh.at.kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210421225212.GB1750844@robh.at.kernel.org> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210422_072016_028626_6A3B6A55 X-CRM114-Status: GOOD ( 17.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17:52-20210421, Rob Herring wrote: > On Fri, Apr 16, 2021 at 05:25:18PM -0500, Nishanth Menon wrote: > > Convert linaro,optee-tz to json schema format for better documentation > > and error checks. > > > > NOTE: > > 1. This change does introduce a stricter naming convention for > > optee nodes. > > 2. We do have false positive checkpatch warning with this patch: > > "DT binding docs and includes should be a separate patch" > > Not really something that needs to be in the commit msg. I'm aware of > the issue, just haven't gotten around to fixing it. sure, thanks.. In this patch and my previous patches as well, I will move them all to diffstat comment. > > +properties: > > + $nodename: > > + const: 'optee' > > Don't need quotes. aarrgh.. yes, ofcourse. > > > + > > + compatible: > > + const: linaro,optee-tz > > + > > + method: > > + description: The method of calling the OP-TEE Trusted OS. > > + oneOf: > > + - description: | > > + SMC #0, with the register assignments specified > > + in drivers/tee/optee/optee_smc.h > > + items: > > + - const: smc > > + - description: | > > + HVC #0, with the register assignments specified > > + in drivers/tee/optee/optee_smc.h > > + items: > > + - const: hvc > > Please just do 'enum: [ smc, hvc ]' and rework to a single description. Sure, will do. thanks for the comments. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel