All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Kuldeep Singh <kuldeep.singh@nxp.com>
Cc: Han Xu <han.xu@nxp.com>, Rob Herring <robh+dt@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Rob Herring <robh@kernel.org>
Subject: Re: [EXT] Re: [PATCH] dt-bindings: spi: Convert Freescale QSPI binding to json schema
Date: Thu, 22 Apr 2021 16:45:55 +0100	[thread overview]
Message-ID: <20210422154555.GJ4572@sirena.org.uk> (raw)
In-Reply-To: <DB6PR0402MB275836552946D34CBEA47C48E0469@DB6PR0402MB2758.eurprd04.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]

On Thu, Apr 22, 2021 at 11:09:19AM +0000, Kuldeep Singh wrote:

> Apologies for content free pings.
> This patch has already been reviewed by Rob and can be accepted if no further changes required.

Whenever I complain about content free pings I also point out that
resends are helpful, it's not just don't ping it's also that having a
copy of the patch helps if anything went wrong:

Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so 
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  If there have been
review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, so sending again is generally a better approach though there are
some other maintainers who like them - if in doubt look at how patches
for the subsystem are normally handled.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2021-04-22 15:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-12  5:40 [PATCH] dt-bindings: spi: Convert Freescale QSPI binding to json schema Kuldeep Singh
2021-03-24 15:24 ` Rob Herring
2021-04-22 11:09   ` [EXT] " Kuldeep Singh
2021-04-22 15:45     ` Mark Brown [this message]
2021-04-26 15:09 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210422154555.GJ4572@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=han.xu@nxp.com \
    --cc=kuldeep.singh@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.