All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm-bsp/n1sdp/scp-firmware: Enabling coresight debug non-secure access
@ 2021-04-22 16:06 Khasim Mohammed
  2021-04-22 21:49 ` [meta-arm] " Ross Burton
  0 siblings, 1 reply; 3+ messages in thread
From: Khasim Mohammed @ 2021-04-22 16:06 UTC (permalink / raw)
  To: meta-arm; +Cc: nd, Khasim Mohammed

From: Khasim Mohammed <khasim.mohammed@arm.com>

This patch enables coresight to work with n1sdp c2c profile.

Change-Id: Id3a5f92cc1f99cd907111ea858aad4efe561179e
Signed-off-by: Khasim Syed Mohammed <khasim.mohammed@arm.com>
---
 ...ng-coresight-debug-non-secure-access.patch | 38 +++++++++++++++++++
 .../scp-firmware/scp-firmware-n1sdp.inc       |  6 +++
 2 files changed, 44 insertions(+)
 create mode 100644 meta-arm-bsp/recipes-bsp/scp-firmware/files/n1sdp/enabling-coresight-debug-non-secure-access.patch

diff --git a/meta-arm-bsp/recipes-bsp/scp-firmware/files/n1sdp/enabling-coresight-debug-non-secure-access.patch b/meta-arm-bsp/recipes-bsp/scp-firmware/files/n1sdp/enabling-coresight-debug-non-secure-access.patch
new file mode 100644
index 0000000..713f4a5
--- /dev/null
+++ b/meta-arm-bsp/recipes-bsp/scp-firmware/files/n1sdp/enabling-coresight-debug-non-secure-access.patch
@@ -0,0 +1,38 @@
+[PATCH] n1sdp: Enabling CoreSight debug non-secure access
+
+Upstream-Status: Pending [Not submitted to upstream yet]
+
+Signed-off-by: Khasim Syed Mohammed <khasim.mohammed@arm.com>
+
+From 194e6239737272c3fadb202deb8015cb6e8df6ec Mon Sep 17 00:00:00 2001
+From: Khasim Mohammed <khasim.mohammed@arm.com>
+Date: Thu, 22 Apr 2021 15:48:02 +0100
+Subject: [PATCH] n1sdp: Enabling CoreSight debug non-secure access
+
+This patch enables coresight to work with n1sdp c2c profile.
+
+Signed-off-by: Khasim Syed Mohammed <khasim.mohammed@arm.com>
+---
+ product/n1sdp/module/n1sdp_system/src/mod_n1sdp_system.c | 6 ++++++
+ 1 file changed, 6 insertions(+)
+
+diff --git a/product/n1sdp/module/n1sdp_system/src/mod_n1sdp_system.c b/product/n1sdp/module/n1sdp_system/src/mod_n1sdp_system.c
+index 70e2ec3f..ff380ae2 100644
+--- a/product/n1sdp/module/n1sdp_system/src/mod_n1sdp_system.c
++++ b/product/n1sdp/module/n1sdp_system/src/mod_n1sdp_system.c
+@@ -466,6 +466,12 @@ static int n1sdp_system_init_primary_core(void)
+             return status;
+     }
+ 
++    else {
++        /* Enable non-secure CoreSight debug access */
++        FWK_LOG_INFO("N1SDP SYSTEM] Enabling CoreSight debug non-secure access");
++        *(volatile uint32_t *)(AP_SCP_SRAM_OFFSET +
++                               NIC_400_SEC_0_CSAPBM_OFFSET) = 0xFFFFFFFF;
++    }
+     return FWK_SUCCESS;
+ }
+ 
+-- 
+2.17.1
+
diff --git a/meta-arm-bsp/recipes-bsp/scp-firmware/scp-firmware-n1sdp.inc b/meta-arm-bsp/recipes-bsp/scp-firmware/scp-firmware-n1sdp.inc
index fa3403d..65034d2 100644
--- a/meta-arm-bsp/recipes-bsp/scp-firmware/scp-firmware-n1sdp.inc
+++ b/meta-arm-bsp/recipes-bsp/scp-firmware/scp-firmware-n1sdp.inc
@@ -6,6 +6,12 @@ SCP_LOG_LEVEL = "INFO"
 LIC_FILES_CHKSUM = "file://license.md;beginline=5;md5=9db9e3d2fb8d9300a6c3d15101b19731 \
                     file://contrib/cmsis/git/LICENSE.txt;md5=e3fc50a88d0a364313df4b21ef20c29e"
 
+FILESEXTRAPATHS_prepend := "${THISDIR}/files/:"
+
+SRC_URI_append = " \
+   file://enabling-coresight-debug-non-secure-access.patch \
+   "
+
 SRCREV  = "6c15afb1b37d0728482c598b063cd69bfc733e93"
 PV = "2.7.0+git${SRCPV}"
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [meta-arm] [PATCH] arm-bsp/n1sdp/scp-firmware: Enabling coresight debug non-secure access
  2021-04-22 16:06 [PATCH] arm-bsp/n1sdp/scp-firmware: Enabling coresight debug non-secure access Khasim Mohammed
@ 2021-04-22 21:49 ` Ross Burton
  2021-04-22 23:18   ` Khasim Mohammed
  0 siblings, 1 reply; 3+ messages in thread
From: Ross Burton @ 2021-04-22 21:49 UTC (permalink / raw)
  To: Khasim Mohammed; +Cc: meta-arm

Is this intended for the hardknott release (next week), or is it okay
to merge this just into the master branch after hardknott has
diverged?

Ross

On Thu, 22 Apr 2021 at 17:07, Khasim Mohammed <khasim.mohammed@arm.com> wrote:
>
> From: Khasim Mohammed <khasim.mohammed@arm.com>
>
> This patch enables coresight to work with n1sdp c2c profile.
>
> Change-Id: Id3a5f92cc1f99cd907111ea858aad4efe561179e
> Signed-off-by: Khasim Syed Mohammed <khasim.mohammed@arm.com>
> ---
>  ...ng-coresight-debug-non-secure-access.patch | 38 +++++++++++++++++++
>  .../scp-firmware/scp-firmware-n1sdp.inc       |  6 +++
>  2 files changed, 44 insertions(+)
>  create mode 100644 meta-arm-bsp/recipes-bsp/scp-firmware/files/n1sdp/enabling-coresight-debug-non-secure-access.patch
>
> diff --git a/meta-arm-bsp/recipes-bsp/scp-firmware/files/n1sdp/enabling-coresight-debug-non-secure-access.patch b/meta-arm-bsp/recipes-bsp/scp-firmware/files/n1sdp/enabling-coresight-debug-non-secure-access.patch
> new file mode 100644
> index 0000000..713f4a5
> --- /dev/null
> +++ b/meta-arm-bsp/recipes-bsp/scp-firmware/files/n1sdp/enabling-coresight-debug-non-secure-access.patch
> @@ -0,0 +1,38 @@
> +[PATCH] n1sdp: Enabling CoreSight debug non-secure access
> +
> +Upstream-Status: Pending [Not submitted to upstream yet]
> +
> +Signed-off-by: Khasim Syed Mohammed <khasim.mohammed@arm.com>
> +
> +From 194e6239737272c3fadb202deb8015cb6e8df6ec Mon Sep 17 00:00:00 2001
> +From: Khasim Mohammed <khasim.mohammed@arm.com>
> +Date: Thu, 22 Apr 2021 15:48:02 +0100
> +Subject: [PATCH] n1sdp: Enabling CoreSight debug non-secure access
> +
> +This patch enables coresight to work with n1sdp c2c profile.
> +
> +Signed-off-by: Khasim Syed Mohammed <khasim.mohammed@arm.com>
> +---
> + product/n1sdp/module/n1sdp_system/src/mod_n1sdp_system.c | 6 ++++++
> + 1 file changed, 6 insertions(+)
> +
> +diff --git a/product/n1sdp/module/n1sdp_system/src/mod_n1sdp_system.c b/product/n1sdp/module/n1sdp_system/src/mod_n1sdp_system.c
> +index 70e2ec3f..ff380ae2 100644
> +--- a/product/n1sdp/module/n1sdp_system/src/mod_n1sdp_system.c
> ++++ b/product/n1sdp/module/n1sdp_system/src/mod_n1sdp_system.c
> +@@ -466,6 +466,12 @@ static int n1sdp_system_init_primary_core(void)
> +             return status;
> +     }
> +
> ++    else {
> ++        /* Enable non-secure CoreSight debug access */
> ++        FWK_LOG_INFO("N1SDP SYSTEM] Enabling CoreSight debug non-secure access");
> ++        *(volatile uint32_t *)(AP_SCP_SRAM_OFFSET +
> ++                               NIC_400_SEC_0_CSAPBM_OFFSET) = 0xFFFFFFFF;
> ++    }
> +     return FWK_SUCCESS;
> + }
> +
> +--
> +2.17.1
> +
> diff --git a/meta-arm-bsp/recipes-bsp/scp-firmware/scp-firmware-n1sdp.inc b/meta-arm-bsp/recipes-bsp/scp-firmware/scp-firmware-n1sdp.inc
> index fa3403d..65034d2 100644
> --- a/meta-arm-bsp/recipes-bsp/scp-firmware/scp-firmware-n1sdp.inc
> +++ b/meta-arm-bsp/recipes-bsp/scp-firmware/scp-firmware-n1sdp.inc
> @@ -6,6 +6,12 @@ SCP_LOG_LEVEL = "INFO"
>  LIC_FILES_CHKSUM = "file://license.md;beginline=5;md5=9db9e3d2fb8d9300a6c3d15101b19731 \
>                      file://contrib/cmsis/git/LICENSE.txt;md5=e3fc50a88d0a364313df4b21ef20c29e"
>
> +FILESEXTRAPATHS_prepend := "${THISDIR}/files/:"
> +
> +SRC_URI_append = " \
> +   file://enabling-coresight-debug-non-secure-access.patch \
> +   "
> +
>  SRCREV  = "6c15afb1b37d0728482c598b063cd69bfc733e93"
>  PV = "2.7.0+git${SRCPV}"
>
> --
> 2.17.1
>
>
> 
>

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [meta-arm] [PATCH] arm-bsp/n1sdp/scp-firmware: Enabling coresight debug non-secure access
  2021-04-22 21:49 ` [meta-arm] " Ross Burton
@ 2021-04-22 23:18   ` Khasim Mohammed
  0 siblings, 0 replies; 3+ messages in thread
From: Khasim Mohammed @ 2021-04-22 23:18 UTC (permalink / raw)
  To: Ross Burton; +Cc: meta-arm

Hi Ross,

We need this on master as soon as possible for an official N1SDP release. If it can get into hardknott that will be good as well.

Regards,
Khasim

________________________________________
From: Ross Burton <ross@burtonini.com>
Sent: Friday, April 23, 2021 3:19 AM
To: Khasim Mohammed
Cc: meta-arm@lists.yoctoproject.org
Subject: Re: [meta-arm] [PATCH] arm-bsp/n1sdp/scp-firmware: Enabling coresight debug non-secure access

Is this intended for the hardknott release (next week), or is it okay
to merge this just into the master branch after hardknott has
diverged?

Ross

On Thu, 22 Apr 2021 at 17:07, Khasim Mohammed <khasim.mohammed@arm.com> wrote:
>
> From: Khasim Mohammed <khasim.mohammed@arm.com>
>
> This patch enables coresight to work with n1sdp c2c profile.
>
> Change-Id: Id3a5f92cc1f99cd907111ea858aad4efe561179e
> Signed-off-by: Khasim Syed Mohammed <khasim.mohammed@arm.com>
> ---
>  ...ng-coresight-debug-non-secure-access.patch | 38 +++++++++++++++++++
>  .../scp-firmware/scp-firmware-n1sdp.inc       |  6 +++
>  2 files changed, 44 insertions(+)
>  create mode 100644 meta-arm-bsp/recipes-bsp/scp-firmware/files/n1sdp/enabling-coresight-debug-non-secure-access.patch
>
> diff --git a/meta-arm-bsp/recipes-bsp/scp-firmware/files/n1sdp/enabling-coresight-debug-non-secure-access.patch b/meta-arm-bsp/recipes-bsp/scp-firmware/files/n1sdp/enabling-coresight-debug-non-secure-access.patch
> new file mode 100644
> index 0000000..713f4a5
> --- /dev/null
> +++ b/meta-arm-bsp/recipes-bsp/scp-firmware/files/n1sdp/enabling-coresight-debug-non-secure-access.patch
> @@ -0,0 +1,38 @@
> +[PATCH] n1sdp: Enabling CoreSight debug non-secure access
> +
> +Upstream-Status: Pending [Not submitted to upstream yet]
> +
> +Signed-off-by: Khasim Syed Mohammed <khasim.mohammed@arm.com>
> +
> +From 194e6239737272c3fadb202deb8015cb6e8df6ec Mon Sep 17 00:00:00 2001
> +From: Khasim Mohammed <khasim.mohammed@arm.com>
> +Date: Thu, 22 Apr 2021 15:48:02 +0100
> +Subject: [PATCH] n1sdp: Enabling CoreSight debug non-secure access
> +
> +This patch enables coresight to work with n1sdp c2c profile.
> +
> +Signed-off-by: Khasim Syed Mohammed <khasim.mohammed@arm.com>
> +---
> + product/n1sdp/module/n1sdp_system/src/mod_n1sdp_system.c | 6 ++++++
> + 1 file changed, 6 insertions(+)
> +
> +diff --git a/product/n1sdp/module/n1sdp_system/src/mod_n1sdp_system.c b/product/n1sdp/module/n1sdp_system/src/mod_n1sdp_system.c
> +index 70e2ec3f..ff380ae2 100644
> +--- a/product/n1sdp/module/n1sdp_system/src/mod_n1sdp_system.c
> ++++ b/product/n1sdp/module/n1sdp_system/src/mod_n1sdp_system.c
> +@@ -466,6 +466,12 @@ static int n1sdp_system_init_primary_core(void)
> +             return status;
> +     }
> +
> ++    else {
> ++        /* Enable non-secure CoreSight debug access */
> ++        FWK_LOG_INFO("N1SDP SYSTEM] Enabling CoreSight debug non-secure access");
> ++        *(volatile uint32_t *)(AP_SCP_SRAM_OFFSET +
> ++                               NIC_400_SEC_0_CSAPBM_OFFSET) = 0xFFFFFFFF;
> ++    }
> +     return FWK_SUCCESS;
> + }
> +
> +--
> +2.17.1
> +
> diff --git a/meta-arm-bsp/recipes-bsp/scp-firmware/scp-firmware-n1sdp.inc b/meta-arm-bsp/recipes-bsp/scp-firmware/scp-firmware-n1sdp.inc
> index fa3403d..65034d2 100644
> --- a/meta-arm-bsp/recipes-bsp/scp-firmware/scp-firmware-n1sdp.inc
> +++ b/meta-arm-bsp/recipes-bsp/scp-firmware/scp-firmware-n1sdp.inc
> @@ -6,6 +6,12 @@ SCP_LOG_LEVEL = "INFO"
>  LIC_FILES_CHKSUM = "file://license.md;beginline=5;md5=9db9e3d2fb8d9300a6c3d15101b19731 \
>                      file://contrib/cmsis/git/LICENSE.txt;md5=e3fc50a88d0a364313df4b21ef20c29e"
>
> +FILESEXTRAPATHS_prepend := "${THISDIR}/files/:"
> +
> +SRC_URI_append = " \
> +   file://enabling-coresight-debug-non-secure-access.patch \
> +   "
> +
>  SRCREV  = "6c15afb1b37d0728482c598b063cd69bfc733e93"
>  PV = "2.7.0+git${SRCPV}"
>
> --
> 2.17.1
>
>
> 
>

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-22 23:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-22 16:06 [PATCH] arm-bsp/n1sdp/scp-firmware: Enabling coresight debug non-secure access Khasim Mohammed
2021-04-22 21:49 ` [meta-arm] " Ross Burton
2021-04-22 23:18   ` Khasim Mohammed

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.