From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 019BDC433ED for ; Thu, 22 Apr 2021 16:42:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C981B613DC for ; Thu, 22 Apr 2021 16:42:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237928AbhDVQn2 (ORCPT ); Thu, 22 Apr 2021 12:43:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:39490 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236058AbhDVQn1 (ORCPT ); Thu, 22 Apr 2021 12:43:27 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7A69D61421; Thu, 22 Apr 2021 16:42:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619109772; bh=VWYw7Sltah44/Ja+aYGG6HIokHXaqHuG1J2aj6+8UXE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kkjlkA5BwtIFA0Y+oBUR75w0/8UGTUne77MWvBJ1Tp2WuttOhmmJB/TBJZAixXYA5 BK3yjl+Rio2Bpv3vsvCUSliRdOcElGAL4Gh2QUQcd5WTirA7BN6BoM36fHBuQoe/2o U7+1KAsMt1eQvLAOeOc2ZeN0mDFvszZHWYnkiz8daQLKWmDZGKYufgiFqd2fWxGrNk 5xnWfCsVYNXjdSZgZLVkOzWZG1+JCTOXT8QGjUnmXG4//XdbcwTAwXt4ucXEAvQU7h lOgOG1SXOY02wHMbe7vo6/UacWIaGDm1xRlO3r9SDvUJpmqwLqbBtEcWkJz7z3K3/D hu8YTXI0YylGA== Date: Thu, 22 Apr 2021 17:42:23 +0100 From: Mark Brown To: Joe Burmeister Cc: Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , linux-spi@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] spi: bcm2835: Fix buffer overflow with CS able to go beyond limit. Message-ID: <20210422164223.GA36209@sirena.org.uk> References: <20210420083402.6950-1-joe.burmeister@devtank.co.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="sdtB3X0nJg68CQEu" Content-Disposition: inline In-Reply-To: <20210420083402.6950-1-joe.burmeister@devtank.co.uk> X-Cookie: When in doubt, lead trump. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --sdtB3X0nJg68CQEu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 20, 2021 at 09:34:02AM +0100, Joe Burmeister wrote: > It was previoulsy possible to have a device tree with more chips than > the driver supports and go off the end of CS arrays. >=20 > This patches inforces CS limit but sets that limit to the max of the > default limit and what is in the device tree when driver is loaded. This doesn't apply against current code, please check and resend. Also s/previoulsy/previously/ and s/inforces/enforces/ --sdtB3X0nJg68CQEu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmCBp28ACgkQJNaLcl1U h9D2oQf/dFMngIVq1ZtQumO+zpDp+HuYqh2dCl8/it2x59tSXNC4kp9W3IxDOlTm n7Dkzo+NaHCFXWs1gwPIFlxBMGXnDDeFvX0Bmhd1lb/1MYvxEjrECMnGvYh8bcTG YoLIAX1lkQ+ycPb5zWZnKgMtk6jAAtFFDPIswtMGxR0tmqLHVDUO8WVHcwLGLivf A4qRhMW+QW2jGTQcVq3HJTcpNp//K7azHa805wvZ5odjanf6kT3mKxCY2lkl4ogl 3KoHk0TThoCd9B1PmpQmgWFf4OROAL3zYJFbqe6hVvTns4YgYb/siX3MsWGGt1k9 RgQH64s0I+XfsUjL8K5kt3w+ETA/OA== =L/zF -----END PGP SIGNATURE----- --sdtB3X0nJg68CQEu-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6133FC433ED for ; Thu, 22 Apr 2021 16:44:34 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 10831613DC for ; Thu, 22 Apr 2021 16:44:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 10831613DC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lkaM+b2hL8yNKmZAu+zH6g552PaldX+Ic+XLsV7NhVU=; b=h2iJ5yawCtbAc6ts4v41e7YGo 8EU3QHV1pSzu0/IOMoLkDWpJUHu/+AD6jZ4ca3Uwp3US9gAI02csjc1X2OT6HYS5/7T0xrl/cfdtB PFwHNPFjWAEauiSeKldQPJKbtwvfes+Y0k0HIuXOjJ9B8Av9gu3RKHsvPJ3Lh7zit04jw6dRYs39Y cvDkwEK7W1nJ/yk35HniV4Z6av1+46QqJSE3pGWkpQUnQQShbk9LOSD+leSZ+kBsliwdGkTXIaguW Kuw/UF9qsvblAY0l+hhOVEWvwrZVKQqbs8EU1cAjSrsamUgjwlwXJk3ZPz1staHtw7WqIfryg9Dla yJU2BFZZw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lZcPs-00H7Im-Cp; Thu, 22 Apr 2021 16:43:00 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZcPn-00H725-2J; Thu, 22 Apr 2021 16:42:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VWYw7Sltah44/Ja+aYGG6HIokHXaqHuG1J2aj6+8UXE=; b=xifJheEja7mA8/kmn9F0iBAqMZ lxWcmotdlfyiELz4w+YXWKU1usHGHXwn5TWOqY1p7zc2H5LM5Je7sV7b8pWJQ7BP7D2PKg/ebzyWB gckFWSkIgNOXtINAve28xyedSHnO9/d2deLToMT0FGoNvmQsExc/+XqeN/gIVLVEz/BNDwSkQc5QG g50h9xKD/phT1KDK5QVk88rEfS0H78OKLx+WFFQwu3b45j4bRhevGaOcDsgw4VcrknuZc9R4Cqh2m K/CZ/1nf/6usii76zq3H2+GqXpmBDLc0930AD1QP6b/hjl3kjVgfMWWyWVIhCXvTGtu1evjM/I5GX kE6i17/A==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZcPk-00Dr7l-M9; Thu, 22 Apr 2021 16:42:53 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7A69D61421; Thu, 22 Apr 2021 16:42:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619109772; bh=VWYw7Sltah44/Ja+aYGG6HIokHXaqHuG1J2aj6+8UXE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kkjlkA5BwtIFA0Y+oBUR75w0/8UGTUne77MWvBJ1Tp2WuttOhmmJB/TBJZAixXYA5 BK3yjl+Rio2Bpv3vsvCUSliRdOcElGAL4Gh2QUQcd5WTirA7BN6BoM36fHBuQoe/2o U7+1KAsMt1eQvLAOeOc2ZeN0mDFvszZHWYnkiz8daQLKWmDZGKYufgiFqd2fWxGrNk 5xnWfCsVYNXjdSZgZLVkOzWZG1+JCTOXT8QGjUnmXG4//XdbcwTAwXt4ucXEAvQU7h lOgOG1SXOY02wHMbe7vo6/UacWIaGDm1xRlO3r9SDvUJpmqwLqbBtEcWkJz7z3K3/D hu8YTXI0YylGA== Date: Thu, 22 Apr 2021 17:42:23 +0100 From: Mark Brown To: Joe Burmeister Cc: Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , linux-spi@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] spi: bcm2835: Fix buffer overflow with CS able to go beyond limit. Message-ID: <20210422164223.GA36209@sirena.org.uk> References: <20210420083402.6950-1-joe.burmeister@devtank.co.uk> MIME-Version: 1.0 In-Reply-To: <20210420083402.6950-1-joe.burmeister@devtank.co.uk> X-Cookie: When in doubt, lead trump. User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210422_094252_769694_772A17BB X-CRM114-Status: GOOD ( 12.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4489645414326888057==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4489645414326888057== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="sdtB3X0nJg68CQEu" Content-Disposition: inline --sdtB3X0nJg68CQEu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 20, 2021 at 09:34:02AM +0100, Joe Burmeister wrote: > It was previoulsy possible to have a device tree with more chips than > the driver supports and go off the end of CS arrays. >=20 > This patches inforces CS limit but sets that limit to the max of the > default limit and what is in the device tree when driver is loaded. This doesn't apply against current code, please check and resend. Also s/previoulsy/previously/ and s/inforces/enforces/ --sdtB3X0nJg68CQEu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmCBp28ACgkQJNaLcl1U h9D2oQf/dFMngIVq1ZtQumO+zpDp+HuYqh2dCl8/it2x59tSXNC4kp9W3IxDOlTm n7Dkzo+NaHCFXWs1gwPIFlxBMGXnDDeFvX0Bmhd1lb/1MYvxEjrECMnGvYh8bcTG YoLIAX1lkQ+ycPb5zWZnKgMtk6jAAtFFDPIswtMGxR0tmqLHVDUO8WVHcwLGLivf A4qRhMW+QW2jGTQcVq3HJTcpNp//K7azHa805wvZ5odjanf6kT3mKxCY2lkl4ogl 3KoHk0TThoCd9B1PmpQmgWFf4OROAL3zYJFbqe6hVvTns4YgYb/siX3MsWGGt1k9 RgQH64s0I+XfsUjL8K5kt3w+ETA/OA== =L/zF -----END PGP SIGNATURE----- --sdtB3X0nJg68CQEu-- --===============4489645414326888057== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4489645414326888057==--