All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Josh Poimboeuf <jpoimboe@redhat.com>,
	Jason Baron <jbaron@akamai.com>, Ard Biesheuvel <ardb@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] static_call: Fix unused variable warning
Date: Thu, 22 Apr 2021 11:01:49 -0700	[thread overview]
Message-ID: <20210422180149.GA107132@roeck-us.net> (raw)
In-Reply-To: <YIGgrMeudHobfDYQ@hirez.programming.kicks-ass.net>

On Thu, Apr 22, 2021 at 06:13:32PM +0200, Peter Zijlstra wrote:
> On Thu, Apr 22, 2021 at 07:01:47AM -0700, Guenter Roeck wrote:
> > On 4/22/21 12:20 AM, Peter Zijlstra wrote:
> > > On Wed, Apr 21, 2021 at 08:41:39PM -0400, Steven Rostedt wrote:
> > >>
> > >> Second patch with the exact same update. Perhaps we should take one
> > >> before we get more of them ;-)
> > >>
> > > 
> > > I thought we already fixed that...
> > 
> > Not in v5.12-rc8-6-g4bdafe832681, which is ToT right now.
> > 
> > Ah, I do see it in -next, but that doesn't help me in mainline,
> > nor in stable branches where the patch introducing the problem
> > has been backported to.
> 
> Given it's a silly warning I didn't figure it was urgent material. I
> suppose we can backport it if someone (you apperntly) cares.

We build release images with -Werror, and some of those images have
CONFIG_MODULES=n. So this wasn't silly for us. It was catastrophic
for the affected images. We already applied my proposed fix, so it
isn't specifically urgent for us anymore. However, the presence of
such "silly" warnings in stable releases (and backporting of patches
introducing such warnings into stable releases) gives ammunition
to those arguing that we should not merge stable releases because
they introduce regressions. And your statement that the warning is
"silly" doesn't help either, sorry.

Guenter

  reply	other threads:[~2021-04-22 18:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-22  0:33 [PATCH] static_call: Fix unused variable warning Guenter Roeck
2021-04-22  0:41 ` Steven Rostedt
2021-04-22  1:24   ` Guenter Roeck
2021-04-22  1:33     ` Steven Rostedt
2021-04-22  1:45       ` Guenter Roeck
2021-04-22  2:38         ` Steven Rostedt
2021-04-22  7:20   ` Peter Zijlstra
2021-04-22 14:01     ` Guenter Roeck
2021-04-22 16:13       ` Peter Zijlstra
2021-04-22 18:01         ` Guenter Roeck [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-04-16 19:43 [PATCH] static_call: fix " Carlos Llamas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210422180149.GA107132@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=ardb@kernel.org \
    --cc=jbaron@akamai.com \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.