All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] package/uftrace: new package
Date: Thu, 22 Apr 2021 22:51:49 +0200	[thread overview]
Message-ID: <20210422225149.25af3320@windsurf> (raw)
In-Reply-To: <20210408194631.313188-1-asafka7@gmail.com>

Hello Asaf,

On Thu,  8 Apr 2021 22:46:31 +0300
Asaf Kahlon <asafka7@gmail.com> wrote:

> diff --git a/package/uftrace/uftrace.mk b/package/uftrace/uftrace.mk
> new file mode 100644
> index 0000000000..20425a9c48
> --- /dev/null
> +++ b/package/uftrace/uftrace.mk
> @@ -0,0 +1,26 @@
> +################################################################################
> +#
> +# uftrace
> +#
> +################################################################################
> +
> +UFTRACE_VERSION = 0.9.4
> +UFTRACE_SITE = $(call github,namhyung,uftrace,v$(UFTRACE_VERSION))
> +UFTRACE_LICENSE = GPL-2.0
> +UFTRACE_LICENSE_FILES = COPYING
> +
> +# uftrace always compiles a small test program to check if elfutils exists, so
> +# there's no special flag for it, we just need to make sure it's installed.
> +ifeq ($(BR2_PACKAGE_ELFUTILS),y)
> +UFTRACE_DEPENDENCIES += elfutils
> +endif

> +
> +define UFTRACE_BUILD_CMDS
> +	$(TARGET_CONFIGURE_OPTS) ARCH=$(BR2_ARCH) $(MAKE) -C $(@D)
> +endef

Why don't you use the configure script? It is not autotools-based, but
the official build instructions suggest to use it:

    $ ./configure
    $ make
    $ sudo make install

The configure script allows to explicit disable unused feature, using
--without-<foo> options.

Could you have a look at this?

Also, the manual says that on ARM, only ARM >= v6 is supported. So this
probably means that:

config BR2_PACKAGE_UFTRACE_ARCH_SUPPORTS
        bool
        default y if BR2_arm

should instead be:

	default y if BR2_ARM_CPU_ARMV6 || BR2_ARM_CPU_ARMV7A

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2021-04-22 20:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-08 19:46 [Buildroot] [PATCH v2 1/1] package/uftrace: new package Asaf Kahlon
2021-04-22 20:51 ` Thomas Petazzoni [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-10-27  9:36 [Buildroot] [PATCH " Thomas Petazzoni
2020-10-27 15:14 ` [Buildroot] [PATCH v2 " Giacomo Longo
2020-11-03 20:31   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210422225149.25af3320@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.