From: Klaus Jensen <its@irrelevant.dk>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Klaus Jensen <k.jensen@samsung.com>,
Max Reitz <mreitz@redhat.com>, Klaus Jensen <its@irrelevant.dk>,
Keith Busch <kbusch@kernel.org>
Subject: [PATCH for-6.0 v2 0/2] hw/block/nvme: fix msix uninit
Date: Fri, 23 Apr 2021 07:21:25 +0200 [thread overview]
Message-ID: <20210423052127.512489-1-its@irrelevant.dk> (raw)
From: Klaus Jensen <k.jensen@samsung.com>
First patch fixes a regression where msix is not correctly uninit'ed
when an nvme device is hotplugged with device_del. When viewed in
conjunction with the commit that introduced the bug (commit
1901b4967c3f), I think the fix looks relatively obvious.
Second patch disables hotplugging for nvme controllers that are
connected to subsystems since the way namespaces are connected to the
nvme controller bus is messed up by removing the device. This bug causes
a segfault but is *not* a regression and is related to an experimental
feature.
v2:
- remove memory subregion as well
- add (possible) patch to disable hotplugging on subsystem connected
controllers
Klaus Jensen (2):
hw/block/nvme: fix invalid msix exclusive uninit
hw/block/nvme: disable hotplugging for subsystem-linked controllers
hw/block/nvme.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
--
2.31.1
next reply other threads:[~2021-04-23 5:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 5:21 Klaus Jensen [this message]
2021-04-23 5:21 ` [PATCH for-6.0 v2 1/2] hw/block/nvme: fix invalid msix exclusive uninit Klaus Jensen
2021-04-23 15:46 ` Peter Maydell
2021-04-26 4:40 ` Klaus Jensen
2021-04-26 9:27 ` Philippe Mathieu-Daudé
2021-04-26 9:39 ` Klaus Jensen
2021-04-26 13:08 ` Michael S. Tsirkin
2021-04-26 15:23 ` Peter Maydell
2021-04-23 5:21 ` [PATCH for-6.0 v2 2/2] hw/block/nvme: disable hotplugging for subsystem-linked controllers Klaus Jensen
2021-04-23 13:21 ` Peter Maydell
2021-04-23 13:25 ` Klaus Jensen
2021-04-23 13:25 ` Peter Maydell
2021-04-23 13:33 ` Klaus Jensen
2021-04-23 10:38 ` [PATCH for-6.0 v2 0/2] hw/block/nvme: fix msix uninit Klaus Jensen
2021-04-23 10:50 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210423052127.512489-1-its@irrelevant.dk \
--to=its@irrelevant.dk \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.