From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C00AC433B4 for ; Sat, 24 Apr 2021 08:27:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3856261463 for ; Sat, 24 Apr 2021 08:27:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236252AbhDXI1q (ORCPT ); Sat, 24 Apr 2021 04:27:46 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:39115 "EHLO relay9-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233128AbhDXIZ2 (ORCPT ); Sat, 24 Apr 2021 04:25:28 -0400 X-Originating-IP: 93.61.96.190 Received: from uno.localdomain (93-61-96-190.ip145.fastwebnet.it [93.61.96.190]) (Authenticated sender: jacopo@jmondi.org) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id ADE6FFF805; Sat, 24 Apr 2021 08:24:12 +0000 (UTC) Date: Sat, 24 Apr 2021 10:24:54 +0200 From: Jacopo Mondi To: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Hans Verkuil , Jacopo Mondi , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH 38/78] media: i2c: mt9m001: use pm_runtime_resume_and_get() Message-ID: <20210424082454.2ciold3j3h2jw47m@uno.localdomain> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mauro, On Sat, Apr 24, 2021 at 08:44:48AM +0200, Mauro Carvalho Chehab wrote: > Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") > added pm_runtime_resume_and_get() in order to automatically handle > dev->power.usage_count decrement on errors. > > Use the new API, in order to cleanup the error check logic. > > Signed-off-by: Mauro Carvalho Chehab Thanks Acked-by: Jacopo Mondi I should re-work the error handling sequence there on top of this patch as right now it's not the best, that 'done' label bothers me... anyway, for later. > --- > drivers/media/i2c/mt9m001.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/i2c/mt9m001.c b/drivers/media/i2c/mt9m001.c > index 3b0ba8ed5233..57e15a291ebd 100644 > --- a/drivers/media/i2c/mt9m001.c > +++ b/drivers/media/i2c/mt9m001.c > @@ -217,9 +217,9 @@ static int mt9m001_s_stream(struct v4l2_subdev *sd, int enable) > goto done; > > if (enable) { > - ret = pm_runtime_get_sync(&client->dev); > + ret = pm_runtime_resume_and_get(&client->dev); > if (ret < 0) > - goto put_unlock; > + goto unlock; > > ret = mt9m001_apply_selection(sd); > if (ret) > @@ -247,6 +247,7 @@ static int mt9m001_s_stream(struct v4l2_subdev *sd, int enable) > > put_unlock: > pm_runtime_put(&client->dev); > +unlock: > mutex_unlock(&mt9m001->mutex); > > return ret; > @@ -834,7 +835,7 @@ static int mt9m001_remove(struct i2c_client *client) > { > struct mt9m001 *mt9m001 = to_mt9m001(client); > > - pm_runtime_get_sync(&client->dev); > + pm_runtime_resume_and_get(&client->dev); > > v4l2_async_unregister_subdev(&mt9m001->subdev); > media_entity_cleanup(&mt9m001->subdev.entity); > -- > 2.30.2 >