All of lore.kernel.org
 help / color / mirror / Atom feed
From: Erik Flodin <erik@flodin.me>
To: unlisted-recipients:; (no To-header on input)
Cc: Erik Flodin <erik@flodin.me>,
	Oliver Hartkopp <socketcan@hartkopp.net>,
	Marc Kleine-Budde <mkl@pengutronix.de>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	linux-can@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH] can: fix proc/can/net/rcvlist_* header alignment on 64-bit system
Date: Sun, 25 Apr 2021 10:49:29 +0200	[thread overview]
Message-ID: <20210425084950.171529-1-erik@flodin.me> (raw)

Before this fix, the function and userdata columns weren't aligned:
  device   can_id   can_mask  function  userdata   matches  ident
   vcan0  92345678  9fffffff  0000000000000000  0000000000000000         0  raw
   vcan0     123    00000123  0000000000000000  0000000000000000         0  raw

After the fix they are:
  device   can_id   can_mask      function          userdata       matches  ident
   vcan0  92345678  9fffffff  0000000000000000  0000000000000000         0  raw
   vcan0     123    00000123  0000000000000000  0000000000000000         0  raw

Signed-off-by: Erik Flodin <erik@flodin.me>
---
 net/can/proc.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/net/can/proc.c b/net/can/proc.c
index 5ea8695f507e..97901e56c429 100644
--- a/net/can/proc.c
+++ b/net/can/proc.c
@@ -205,8 +205,11 @@ static void can_print_recv_banner(struct seq_file *m)
 	 *                  can1.  00000000  00000000  00000000
 	 *                 .......          0  tp20
 	 */
-	seq_puts(m, "  device   can_id   can_mask  function"
-			"  userdata   matches  ident\n");
+	const char *pad = sizeof(void *) == 8 ? "    " : "";
+
+	seq_printf(m, "  device   can_id   can_mask  %sfunction%s"
+		   "  %suserdata%s   matches  ident\n",
+		   pad, pad, pad, pad);
 }
 
 static int can_stats_proc_show(struct seq_file *m, void *v)
-- 
2.31.0


             reply	other threads:[~2021-04-25  8:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-25  8:49 Erik Flodin [this message]
2021-04-25  9:07 ` [PATCH] can: fix proc/can/net/rcvlist_* header alignment on 64-bit system Marc Kleine-Budde
2021-04-25  9:52   ` [PATCH] can: proc: fix rcvlist_* " Erik Flodin
2021-04-25 11:40     ` Erik Flodin
2021-04-25 12:05       ` Vincent MAILHOL
2021-04-25 12:09         ` Marc Kleine-Budde
2021-04-25 12:22     ` [PATCH v3] " Erik Flodin
2021-04-25 12:27       ` Marc Kleine-Budde
2021-04-25 14:16         ` Erik Flodin
2021-04-25 14:14     ` [PATCH] " Erik Flodin
2021-04-25  9:56   ` [PATCH] can: fix proc/can/net/rcvlist_* " Erik Flodin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210425084950.171529-1-erik@flodin.me \
    --to=erik@flodin.me \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=socketcan@hartkopp.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.