All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/pipewire: bump to version 0.3.6
Date: Sun, 25 Apr 2021 21:52:57 +0200	[thread overview]
Message-ID: <20210425195257.GC298901@scaer> (raw)
In-Reply-To: <CADvTj4oiaTvOJOF9HVmmfPieG_+LAQ3z2R_K+vtP_wiPtAjwEQ@mail.gmail.com>

James, All,

Sorry to come back so late on that one...

On 2020-10-15 23:50 -0600, James Hilliard spake thusly:
> On Thu, Aug 27, 2020 at 3:48 PM Thomas Petazzoni
> <thomas.petazzoni@bootlin.com> wrote:
> > On Sun,  5 Jul 2020 19:04:44 -0600
> > James Hilliard <james.hilliard1@gmail.com> wrote:
> > > Add pipewire optional dependencies/configurations.
> > >
> > > Remove BR2_PACKAGE_PIPEWIRE_GSTREAMER config option and enable
> > > automatically based on dependencies to avoid recursive dependency
> > > error caused by the gobject-introspection python3 dependency.
> > Could you give more details about this recursive dependency ?
[--SNIP--]
> > > diff --git a/Config.in.legacy b/Config.in.legacy
> > > index 7a5435188b..4541acc979 100644
> > > --- a/Config.in.legacy
> > > +++ b/Config.in.legacy
> > > @@ -146,6 +146,16 @@ endif
> > >
> > >  comment "Legacy options removed in 2020.08"
> > >
> > > +config BR2_PACKAGE_PIPEWIRE_GSTREAMER
> > > +     bool "pipewire gstreamer option removed"
> > > +     select BR2_LEGACY
> > > +     select BR2_PACKAGE_GOBJECT_INTROSPECTION
> > > +     select BR2_PACKAGE_GSTREAMER1
> > > +     select BR2_PACKAGE_GST1_PLUGINS_BASE
> >
> > But isn't that going to cause that circular dependency you're trying to
> > prevent, since you're selecting BR2_PACKAGE_GOBJECT_INTROSPECTION here ?
> Looks to be related to a conflict involving these:
> https://github.com/buildroot/buildroot/blob/master/package/python-gobject/Config.in
> https://github.com/buildroot/buildroot/blob/master/package/gstreamer1/gst1-python/Config.in

Sorry, but this answer is too terse to try and understand the issue... :-(
In the meantime, pipewire has had new releases.

To ease acceptance, could you split the patch in a small series:

 1. a first patch that drops the option and relies on pacjages being
    enabled

 2. a bump still keeping v4l2 mandatory, and disabling all new features
    that have dependencies

 3. a new option for enabling v4l2 support

 4. as many patches as needed to add new options for new optional
    features that have dependencies

This should make for simpler patches, easier to review.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2021-04-25 19:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-06  1:04 [Buildroot] [PATCH 1/1] package/pipewire: bump to version 0.3.6 James Hilliard
2020-08-27 21:48 ` Thomas Petazzoni
2020-10-16  5:50   ` James Hilliard
2021-04-25 19:52     ` Yann E. MORIN [this message]
2021-04-25 20:02       ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210425195257.GC298901@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.