From: Naohiro Aota <naohiro.aota@wdc.com>
To: dsterba@suse.cz
Cc: Karel Zak <kzak@redhat.com>,
util-linux@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
Damien Le Moal <damien.lemoal@wdc.com>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: Re: [PATCH v2 2/3] blkid: add magic and probing for zoned btrfs
Date: Mon, 26 Apr 2021 10:38:27 +0900 [thread overview]
Message-ID: <20210426013827.rijm2p2gba7wonlx@naota-xeon> (raw)
In-Reply-To: <20210416155241.GY7604@twin.jikos.cz>
On Fri, Apr 16, 2021 at 05:52:41PM +0200, David Sterba wrote:
> On Wed, Apr 14, 2021 at 10:33:38AM +0900, Naohiro Aota wrote:
> > It also supports temporary magic ("!BHRfS_M") in zone #0. The mkfs.btrfs
> > first writes the temporary superblock to the zone during the mkfs process.
> > It will survive there until the zones are filled up and reset. So, we also
> > need to detect this temporary magic.
>
> > + /*
> > + * For zoned btrfs, we also need to detect a temporary superblock
> > + * at zone #0. Mkfs.btrfs creates it in the initialize process.
> > + * It persits until both zones are filled up then reset.
> > + */
> > + { .magic = "!BHRfS_M", .len = 8, .sboff = 0x40,
> > + .is_zoned = 1, .zonenum = 0, .kboff_inzone = 0 },
>
> Should we rather reset the zone twice so the initial superblock does not
> have the temporary signature?
OK, sure. I'll modify the mkfs.btrfs to reset the superblock log zone
before writing out final superblock.
> For the primary superblock at offset 64K and as a fallback the signature
> should be valid for detection purposes (ie. not necessarily to get the
> latest superblock).
next prev parent reply other threads:[~2021-04-26 1:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 1:33 [PATCH v2 0/3] implement zone-aware probing/wiping for zoned btrfs Naohiro Aota
2021-04-14 1:33 ` [PATCH v2 1/3] blkid: implement zone-aware probing Naohiro Aota
2021-04-14 9:14 ` Damien Le Moal
2021-04-14 9:17 ` Johannes Thumshirn
2021-04-14 13:31 ` Karel Zak
2021-04-14 15:03 ` Naohiro Aota
2021-04-14 1:33 ` [PATCH v2 2/3] blkid: add magic and probing for zoned btrfs Naohiro Aota
2021-04-14 9:49 ` Johannes Thumshirn
2021-04-14 13:47 ` Karel Zak
2021-04-14 15:08 ` Naohiro Aota
2021-04-16 15:52 ` David Sterba
2021-04-26 1:38 ` Naohiro Aota [this message]
2021-04-14 1:33 ` [PATCH v2 3/3] blkid: support zone reset for wipefs Naohiro Aota
2021-04-14 9:13 ` Damien Le Moal
2021-04-14 9:50 ` Johannes Thumshirn
2021-04-14 13:57 ` Karel Zak
2021-04-16 16:04 ` David Sterba
2021-04-14 14:09 ` [PATCH v2 0/3] implement zone-aware probing/wiping for zoned btrfs Karel Zak
2021-04-14 22:04 ` Damien Le Moal
2021-04-22 14:41 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210426013827.rijm2p2gba7wonlx@naota-xeon \
--to=naohiro.aota@wdc.com \
--cc=damien.lemoal@wdc.com \
--cc=dsterba@suse.cz \
--cc=johannes.thumshirn@wdc.com \
--cc=kzak@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.