All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Christian Brauner <brauner@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Aleksa Sarai <cyphar@cyphar.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel@vger.kernel.org,
	Richard Guy Briggs <rgb@redhat.com>,
	Christian Brauner <christian.brauner@ubuntu.com>
Subject: Re: [PATCH 2/3] open: don't silently ignore unknown O-flags in openat2()
Date: Mon, 26 Apr 2021 15:34:56 +0200	[thread overview]
Message-ID: <20210426133456.GB14812@lst.de> (raw)
In-Reply-To: <20210423111037.3590242-2-brauner@kernel.org>

On Fri, Apr 23, 2021 at 01:10:36PM +0200, Christian Brauner wrote:
> There's a snafu here though stripping FMODE_* directly from flags would
> cause the upper 32 bits to be truncated as well due to integer promotion
> rules since FMODE_* is unsigned int, O_* are signed ints (yuck).
> 
> This change shouldn't regress old open syscalls since they silently
> truncate any unknown values.

So, this is a change in behavior for openat.  But given how new it is
and there are not flags defined yet in the truncated range I think
we should be fine:

Reviewed-by: Christoph Hellwig <hch@lst.de>

  parent reply	other threads:[~2021-04-26 13:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-23 11:10 [PATCH 1/3] fcntl: remove unused VALID_UPGRADE_FLAGS Christian Brauner
2021-04-23 11:10 ` [PATCH 2/3] open: don't silently ignore unknown O-flags in openat2() Christian Brauner
2021-04-23 13:50   ` Richard Guy Briggs
2021-04-26 13:34   ` Christoph Hellwig [this message]
2021-05-01  0:53   ` Aleksa Sarai
2021-04-23 11:10 ` [PATCH 3/3] test: add openat2() test for invalid upper 32 bit flag value Christian Brauner
2021-04-30 15:24   ` Richard Guy Briggs
2021-04-30 16:09     ` Christian Brauner
2021-04-30 16:46       ` Richard Guy Briggs
2021-04-30 17:08         ` Christian Brauner
2021-04-30 17:22           ` Richard Guy Briggs
2021-04-23 12:36 ` [PATCH 1/3] fcntl: remove unused VALID_UPGRADE_FLAGS Richard Guy Briggs
2021-04-26 13:33 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210426133456.GB14812@lst.de \
    --to=hch@lst.de \
    --cc=brauner@kernel.org \
    --cc=christian.brauner@ubuntu.com \
    --cc=cyphar@cyphar.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=rgb@redhat.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.