All of lore.kernel.org
 help / color / mirror / Atom feed
* drivers/dma/qcom/gpi.c:2210:3-10: line 2210 is redundant because platform_get_irq() already prints an error
@ 2021-04-26  5:40 kernel test robot
  2021-04-26  5:40 ` [PATCH] dmaengine: qcom: fix platform_get_irq.cocci warnings kernel test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2021-04-26  5:40 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 1129 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Nathan Chancellor <natechancellor@gmail.com>
CC: Vinod Koul <vkoul@kernel.org>

Hi Nathan,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   9f4ad9e425a1d3b6a34617b8ea226d56a119a717
commit: 0a6d3038d914b51d6860f23ea2b508590e8340de dmaengine: qcom: Always inline gpi_update_reg
date:   3 months ago
:::::: branch date: 9 hours ago
:::::: commit date: 3 months ago
config: arm64-randconfig-c003-20210426 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


cocci warnings: (new ones prefixed by >>)
>> drivers/dma/qcom/gpi.c:2210:3-10: line 2210 is redundant because platform_get_irq() already prints an error

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 44553 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH] dmaengine: qcom: fix platform_get_irq.cocci warnings
  2021-04-26  5:40 drivers/dma/qcom/gpi.c:2210:3-10: line 2210 is redundant because platform_get_irq() already prints an error kernel test robot
@ 2021-04-26  5:40 ` kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-04-26  5:40 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 1630 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Nathan Chancellor <natechancellor@gmail.com>
CC: Vinod Koul <vkoul@kernel.org>
CC: Andy Gross <agross@kernel.org>
CC: Bjorn Andersson <bjorn.andersson@linaro.org>
CC: Dan Williams <dan.j.williams@intel.com>
CC: linux-arm-msm(a)vger.kernel.org
CC: dmaengine(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/dma/qcom/gpi.c:2210:3-10: line 2210 is redundant because platform_get_irq() already prints an error

 Remove dev_err() messages after platform_get_irq*() failures
Generated by: scripts/coccinelle/api/platform_get_irq.cocci

Fixes: 0a6d3038d914 ("dmaengine: qcom: Always inline gpi_update_reg")
CC: Nathan Chancellor <natechancellor@gmail.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   9f4ad9e425a1d3b6a34617b8ea226d56a119a717
commit: 0a6d3038d914b51d6860f23ea2b508590e8340de dmaengine: qcom: Always inline gpi_update_reg
:::::: branch date: 9 hours ago
:::::: commit date: 3 months ago

Please take the patch only if it's a positive warning. Thanks!

 gpi.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/dma/qcom/gpi.c
+++ b/drivers/dma/qcom/gpi.c
@@ -2207,7 +2207,6 @@ static int gpi_probe(struct platform_dev
 		/* set up irq */
 		ret = platform_get_irq(pdev, i);
 		if (ret < 0) {
-			dev_err(gpi_dev->dev, "platform_get_irq failed for %d:%d\n", i, ret);
 			return ret;
 		}
 		gpii->irq = ret;

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-26  5:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-26  5:40 drivers/dma/qcom/gpi.c:2210:3-10: line 2210 is redundant because platform_get_irq() already prints an error kernel test robot
2021-04-26  5:40 ` [PATCH] dmaengine: qcom: fix platform_get_irq.cocci warnings kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.