From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [bvanassche:scsi-remove-done-callback 83/83] drivers/scsi/aha1542.c:364:27: error: 'struct scsi_cmnd' has no member named 'scsi_done'
Date: Mon, 26 Apr 2021 14:31:40 +0800 [thread overview]
Message-ID: <202104261435.FL6a1vLd-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 4551 bytes --]
tree: https://github.com/bvanassche/linux scsi-remove-done-callback
head: 0fcbd84b06fef935eeac38e0677f03ddbc69cab0
commit: 0fcbd84b06fef935eeac38e0677f03ddbc69cab0 [83/83] Remove the scsi_done member from struct scsi_cmnd
config: i386-randconfig-m021-20210426 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/bvanassche/linux/commit/0fcbd84b06fef935eeac38e0677f03ddbc69cab0
git remote add bvanassche https://github.com/bvanassche/linux
git fetch --no-tags bvanassche scsi-remove-done-callback
git checkout 0fcbd84b06fef935eeac38e0677f03ddbc69cab0
# save the attached .config to linux build tree
make W=1 W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/scsi/aha1542.c: In function 'aha1542_test_port':
drivers/scsi/aha1542.c:206:5: warning: variable 'inquiry_result' set but not used [-Wunused-but-set-variable]
206 | u8 inquiry_result[4];
| ^~~~~~~~~~~~~~
drivers/scsi/aha1542.c: In function 'aha1542_interrupt':
>> drivers/scsi/aha1542.c:364:27: error: 'struct scsi_cmnd' has no member named 'scsi_done'
364 | if (!tmp_cmd || !tmp_cmd->scsi_done) {
| ^~
drivers/scsi/aha1542.c:371:20: error: 'struct scsi_cmnd' has no member named 'scsi_done'
371 | my_done = tmp_cmd->scsi_done;
| ^~
vim +364 drivers/scsi/aha1542.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 361
55b28f9fc033f9 Ondrej Zary 2015-02-06 362 tmp_cmd = aha1542->int_cmds[mbo];
^1da177e4c3f41 Linus Torvalds 2005-04-16 363
55b28f9fc033f9 Ondrej Zary 2015-02-06 @364 if (!tmp_cmd || !tmp_cmd->scsi_done) {
1b0224b0ec6003 Ondrej Zary 2015-02-06 365 spin_unlock_irqrestore(sh->host_lock, flags);
2906b3ceb1bfc4 Ondrej Zary 2015-02-06 366 shost_printk(KERN_WARNING, sh, "Unexpected interrupt\n");
2906b3ceb1bfc4 Ondrej Zary 2015-02-06 367 shost_printk(KERN_WARNING, sh, "tarstat=%x, hastat=%x idlun=%x ccb#=%d\n", ccb[mbo].tarstat,
^1da177e4c3f41 Linus Torvalds 2005-04-16 368 ccb[mbo].hastat, ccb[mbo].idlun, mbo);
1b0224b0ec6003 Ondrej Zary 2015-02-06 369 return IRQ_HANDLED;
^1da177e4c3f41 Linus Torvalds 2005-04-16 370 }
55b28f9fc033f9 Ondrej Zary 2015-02-06 371 my_done = tmp_cmd->scsi_done;
1794ef2b150dd5 Christoph Hellwig 2018-11-10 372 aha1542_free_cmd(tmp_cmd);
e4da5feb094c3a Sergey Shtylyov 2021-01-10 373 /*
e4da5feb094c3a Sergey Shtylyov 2021-01-10 374 * Fetch the sense data, and tuck it away, in the required slot. The
e4da5feb094c3a Sergey Shtylyov 2021-01-10 375 * Adaptec automatically fetches it, and there is no guarantee that
e4da5feb094c3a Sergey Shtylyov 2021-01-10 376 * we will still have it in the cdb when we come back
e4da5feb094c3a Sergey Shtylyov 2021-01-10 377 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 378 if (ccb[mbo].tarstat == 2)
55b28f9fc033f9 Ondrej Zary 2015-02-06 379 memcpy(tmp_cmd->sense_buffer, &ccb[mbo].cdb[ccb[mbo].cdblen],
b80ca4f7ee36c2 FUJITA Tomonori 2008-01-13 380 SCSI_SENSE_BUFFERSIZE);
^1da177e4c3f41 Linus Torvalds 2005-04-16 381
^1da177e4c3f41 Linus Torvalds 2005-04-16 382
^1da177e4c3f41 Linus Torvalds 2005-04-16 383 /* is there mail :-) */
^1da177e4c3f41 Linus Torvalds 2005-04-16 384
^1da177e4c3f41 Linus Torvalds 2005-04-16 385 /* more error checking left out here */
^1da177e4c3f41 Linus Torvalds 2005-04-16 386 if (mbistatus != 1)
^1da177e4c3f41 Linus Torvalds 2005-04-16 387 /* This is surely wrong, but I don't know what's right */
^1da177e4c3f41 Linus Torvalds 2005-04-16 388 errstatus = makecode(ccb[mbo].hastat, ccb[mbo].tarstat);
^1da177e4c3f41 Linus Torvalds 2005-04-16 389 else
^1da177e4c3f41 Linus Torvalds 2005-04-16 390 errstatus = 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 391
:::::: The code at line 364 was first introduced by commit
:::::: 55b28f9fc033f9af090a58ea97063ca51552a2a6 aha1524: Use struct scsi_cmnd
:::::: TO: Ondrej Zary <linux@rainbow-software.org>
:::::: CC: James Bottomley <JBottomley@Odin.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 41523 bytes --]
reply other threads:[~2021-04-26 6:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202104261435.FL6a1vLd-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.