From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58541C43460 for ; Mon, 26 Apr 2021 12:42:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 23ECD6127A for ; Mon, 26 Apr 2021 12:42:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233362AbhDZMnF (ORCPT ); Mon, 26 Apr 2021 08:43:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:57916 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232364AbhDZMnB (ORCPT ); Mon, 26 Apr 2021 08:43:01 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8106D611CE; Mon, 26 Apr 2021 12:42:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619440939; bh=6CTY4exOmL7l22aXrPfGFjlNeMqnCUXrgJOGfHlDDfo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VWTJ3W71PmyDqp2EIS/gk2qcSkPxTNg1O0TT+qg7l1CRzIQpx4x8gsLGCNeg8hde6 LLDLmGKzWciNzTnd4C+6dzY5zEounZxBbd9JgOYs5KCHTIlFzr0JImy7G9qczdd0FR qhtq4lWhv+/8FcQmtwsRDLXIJvtQRRIsqO1vl59SXtWthmgmlsJzAPNXEgoco4RVrw Ia6nGezETvVK1HyU80csrp7r0GLCF6hIwxruTJo96NyGn/7UM1uUm9LYfjZPBy/5bu SPqi4+DDkZ+3U0VKbxA/UxJ26R/9NcfdWZIqjUnt7SlVIouV29c7DIheCkQFZXiXFA iInt69scoTQrw== Date: Mon, 26 Apr 2021 14:42:12 +0200 From: Mauro Carvalho Chehab To: Ezequiel Garcia Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Greg Kroah-Hartman , Mauro Carvalho Chehab , Philipp Zabel , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH 13/78] staging: media: hantro_drv: use pm_runtime_resume_and_get() Message-ID: <20210426144212.1f8430ce@coco.lan> In-Reply-To: <20210426143327.4f9fb6ea@coco.lan> References: <0021158fb27035a56089683ee712fb3ed6f6032d.1619191723.git.mchehab+huawei@kernel.org> <780afdc9b263928ed378dfbd3eaa8a5509a59a35.camel@collabora.com> <20210426143327.4f9fb6ea@coco.lan> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, 26 Apr 2021 14:33:27 +0200 Mauro Carvalho Chehab escreveu: > Em Sat, 24 Apr 2021 20:23:53 -0300 > Ezequiel Garcia escreveu: >=20 > > Hi Mauro, > >=20 > > On Sat, 2021-04-24 at 08:44 +0200, Mauro Carvalho Chehab wrote: =20 > > > Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to d= eal with usage counter") > > > added pm_runtime_resume_and_get() in order to automatically handle > > > dev->power.usage_count decrement on errors. > > >=20 > > > Use the new API, in order to cleanup the error check logic. > > >=20 > > > Signed-off-by: Mauro Carvalho Chehab > > > --- > > > =C2=A0drivers/staging/media/hantro/hantro_drv.c | 2 +- > > > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) > > >=20 > > > diff --git a/drivers/staging/media/hantro/hantro_drv.c b/drivers/stag= ing/media/hantro/hantro_drv.c > > > index 595e82a82728..3147dcbebeb9 100644 > > > --- a/drivers/staging/media/hantro/hantro_drv.c > > > +++ b/drivers/staging/media/hantro/hantro_drv.c > > > @@ -155,7 +155,7 @@ static void device_run(void *priv) > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0ret =3D clk_bulk_enab= le(ctx->dev->variant->num_clocks, ctx->dev->clocks); > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (ret) > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0goto err_cancel_job; > > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0ret =3D pm_runtime_get_syn= c(ctx->dev->dev); > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0ret =3D pm_runtime_resume_= and_get(ctx->dev->dev); > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (ret < 0) > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0goto err_cancel_job; > > > =C2=A0 =20 > >=20 > > Seems this one needs a different fix: err_cancel_job > > will call hantro_job_finish which has a pm_runtime put. =20 >=20 > Good point. Thanks for reviewing it! >=20 > It sounds that this is a place where the best seems > to keep using pm_runtime_get_sync(), but let's at least add a > comment explaining why it should be kept here. This should > help to avoid people to copy-and-paste the code on situations > where pm_runtime_resume_and_get() should be used instead. >=20 > See enclosed patch. >=20 > Thanks, > Mauro >=20 > [PATCH] media: hantro: document the usage of pm_runtime_get_sync() >=20 > Despite other *_get()/*_put() functions, where usage count is > incremented only if not errors, the pm_runtime_get_sync() has > a different behavior, incrementing the counter *even* on > errors. >=20 > That's an error prone behavior, as people often forget to > decrement the usage counter. >=20 > However, the hantro driver depends on this behavior, as it > will decrement the usage_count unconditionally at the m2m > job finish time, which makes sense. >=20 > So, intead of using the pm_runtime_resume_and_get() that > would decrement the counter on error, keep the current > API, but add a documentation explaining the rationale for > keep using pm_runtime_get_sync(). >=20 > Signed-off-by: Mauro Carvalho Chehab Hmm... maybe it can, instead, use the same solution as the rkvdec driver does, having a job_finish_no_pm() plus the normal job_finish(). What do you think? Regards, Mauro >=20 > diff --git a/drivers/staging/media/hantro/hantro_drv.c b/drivers/staging/= media/hantro/hantro_drv.c > index 595e82a82728..96f940c1c85c 100644 > --- a/drivers/staging/media/hantro/hantro_drv.c > +++ b/drivers/staging/media/hantro/hantro_drv.c > @@ -155,6 +155,13 @@ static void device_run(void *priv) > ret =3D clk_bulk_enable(ctx->dev->variant->num_clocks, ctx->dev->clocks= ); > if (ret) > goto err_cancel_job; > + > + /* > + * The pm_runtime_get_sync() will increment dev->power.usage_count, > + * even on errors. That's the expected behavior here, since the > + * hantro_job_finish() function at the error handling code > + * will internally call pm_runtime_put_autosuspend(). > + */ > ret =3D pm_runtime_get_sync(ctx->dev->dev); > if (ret < 0) > goto err_cancel_job; >=20 >=20 Thanks, Mauro From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57E50C433B4 for ; Mon, 26 Apr 2021 12:42:24 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E43466109E for ; Mon, 26 Apr 2021 12:42:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E43466109E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 7CB5E834BB; Mon, 26 Apr 2021 12:42:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JvoBBIge660f; Mon, 26 Apr 2021 12:42:22 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 5E0FD8350A; Mon, 26 Apr 2021 12:42:22 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 2250C1BF34C for ; Mon, 26 Apr 2021 12:42:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 0AA748350A for ; Mon, 26 Apr 2021 12:42:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9G_n1_q3Ctkw for ; Mon, 26 Apr 2021 12:42:20 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp1.osuosl.org (Postfix) with ESMTPS id 65981834BB for ; Mon, 26 Apr 2021 12:42:20 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 8106D611CE; Mon, 26 Apr 2021 12:42:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619440939; bh=6CTY4exOmL7l22aXrPfGFjlNeMqnCUXrgJOGfHlDDfo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VWTJ3W71PmyDqp2EIS/gk2qcSkPxTNg1O0TT+qg7l1CRzIQpx4x8gsLGCNeg8hde6 LLDLmGKzWciNzTnd4C+6dzY5zEounZxBbd9JgOYs5KCHTIlFzr0JImy7G9qczdd0FR qhtq4lWhv+/8FcQmtwsRDLXIJvtQRRIsqO1vl59SXtWthmgmlsJzAPNXEgoco4RVrw Ia6nGezETvVK1HyU80csrp7r0GLCF6hIwxruTJo96NyGn/7UM1uUm9LYfjZPBy/5bu SPqi4+DDkZ+3U0VKbxA/UxJ26R/9NcfdWZIqjUnt7SlVIouV29c7DIheCkQFZXiXFA iInt69scoTQrw== Date: Mon, 26 Apr 2021 14:42:12 +0200 From: Mauro Carvalho Chehab To: Ezequiel Garcia Subject: Re: [PATCH 13/78] staging: media: hantro_drv: use pm_runtime_resume_and_get() Message-ID: <20210426144212.1f8430ce@coco.lan> In-Reply-To: <20210426143327.4f9fb6ea@coco.lan> References: <0021158fb27035a56089683ee712fb3ed6f6032d.1619191723.git.mchehab+huawei@kernel.org> <780afdc9b263928ed378dfbd3eaa8a5509a59a35.camel@collabora.com> <20210426143327.4f9fb6ea@coco.lan> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , linuxarm@huawei.com, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Philipp Zabel , mauro.chehab@huawei.com, Mauro Carvalho Chehab , linux-media@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" RW0gTW9uLCAyNiBBcHIgMjAyMSAxNDozMzoyNyArMDIwMApNYXVybyBDYXJ2YWxobyBDaGVoYWIg PG1jaGVoYWIraHVhd2VpQGtlcm5lbC5vcmc+IGVzY3JldmV1OgoKPiBFbSBTYXQsIDI0IEFwciAy MDIxIDIwOjIzOjUzIC0wMzAwCj4gRXplcXVpZWwgR2FyY2lhIDxlemVxdWllbEBjb2xsYWJvcmEu Y29tPiBlc2NyZXZldToKPiAKPiA+IEhpIE1hdXJvLAo+ID4gCj4gPiBPbiBTYXQsIDIwMjEtMDQt MjQgYXQgMDg6NDQgKzAyMDAsIE1hdXJvIENhcnZhbGhvIENoZWhhYiB3cm90ZTogIAo+ID4gPiBD b21taXQgZGQ4MDg4ZDVhODk2ICgiUE06IHJ1bnRpbWU6IEFkZCBwbV9ydW50aW1lX3Jlc3VtZV9h bmRfZ2V0IHRvIGRlYWwgd2l0aCB1c2FnZSBjb3VudGVyIikKPiA+ID4gYWRkZWQgcG1fcnVudGlt ZV9yZXN1bWVfYW5kX2dldCgpIGluIG9yZGVyIHRvIGF1dG9tYXRpY2FsbHkgaGFuZGxlCj4gPiA+ IGRldi0+cG93ZXIudXNhZ2VfY291bnQgZGVjcmVtZW50IG9uIGVycm9ycy4KPiA+ID4gCj4gPiA+ IFVzZSB0aGUgbmV3IEFQSSwgaW4gb3JkZXIgdG8gY2xlYW51cCB0aGUgZXJyb3IgY2hlY2sgbG9n aWMuCj4gPiA+IAo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBNYXVybyBDYXJ2YWxobyBDaGVoYWIgPG1j aGVoYWIraHVhd2VpQGtlcm5lbC5vcmc+Cj4gPiA+IC0tLQo+ID4gPiDCoGRyaXZlcnMvc3RhZ2lu Zy9tZWRpYS9oYW50cm8vaGFudHJvX2Rydi5jIHwgMiArLQo+ID4gPiDCoDEgZmlsZSBjaGFuZ2Vk LCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQo+ID4gPiAKPiA+ID4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvc3RhZ2luZy9tZWRpYS9oYW50cm8vaGFudHJvX2Rydi5jIGIvZHJpdmVycy9zdGFn aW5nL21lZGlhL2hhbnRyby9oYW50cm9fZHJ2LmMKPiA+ID4gaW5kZXggNTk1ZTgyYTgyNzI4Li4z MTQ3ZGNiZWJlYjkgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvc3RhZ2luZy9tZWRpYS9oYW50 cm8vaGFudHJvX2Rydi5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvc3RhZ2luZy9tZWRpYS9oYW50cm8v aGFudHJvX2Rydi5jCj4gPiA+IEBAIC0xNTUsNyArMTU1LDcgQEAgc3RhdGljIHZvaWQgZGV2aWNl X3J1bih2b2lkICpwcml2KQo+ID4gPiDCoMKgwqDCoMKgwqDCoMKgcmV0ID0gY2xrX2J1bGtfZW5h YmxlKGN0eC0+ZGV2LT52YXJpYW50LT5udW1fY2xvY2tzLCBjdHgtPmRldi0+Y2xvY2tzKTsKPiA+ ID4gwqDCoMKgwqDCoMKgwqDCoGlmIChyZXQpCj4gPiA+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgZ290byBlcnJfY2FuY2VsX2pvYjsKPiA+ID4gLcKgwqDCoMKgwqDCoMKgcmV0ID0g cG1fcnVudGltZV9nZXRfc3luYyhjdHgtPmRldi0+ZGV2KTsKPiA+ID4gK8KgwqDCoMKgwqDCoMKg cmV0ID0gcG1fcnVudGltZV9yZXN1bWVfYW5kX2dldChjdHgtPmRldi0+ZGV2KTsKPiA+ID4gwqDC oMKgwqDCoMKgwqDCoGlmIChyZXQgPCAwKQo+ID4gPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoGdvdG8gZXJyX2NhbmNlbF9qb2I7Cj4gPiA+IMKgICAgIAo+ID4gCj4gPiBTZWVtcyB0 aGlzIG9uZSBuZWVkcyBhIGRpZmZlcmVudCBmaXg6IGVycl9jYW5jZWxfam9iCj4gPiB3aWxsIGNh bGwgaGFudHJvX2pvYl9maW5pc2ggd2hpY2ggaGFzIGEgcG1fcnVudGltZSBwdXQuICAKPiAKPiBH b29kIHBvaW50LiBUaGFua3MgZm9yIHJldmlld2luZyBpdCEKPiAKPiBJdCBzb3VuZHMgdGhhdCB0 aGlzIGlzIGEgcGxhY2Ugd2hlcmUgdGhlIGJlc3Qgc2VlbXMKPiB0byBrZWVwIHVzaW5nIHBtX3J1 bnRpbWVfZ2V0X3N5bmMoKSwgYnV0IGxldCdzIGF0IGxlYXN0IGFkZCBhCj4gY29tbWVudCBleHBs YWluaW5nIHdoeSBpdCBzaG91bGQgYmUga2VwdCBoZXJlLiBUaGlzIHNob3VsZAo+IGhlbHAgdG8g YXZvaWQgcGVvcGxlIHRvIGNvcHktYW5kLXBhc3RlIHRoZSBjb2RlIG9uIHNpdHVhdGlvbnMKPiB3 aGVyZSBwbV9ydW50aW1lX3Jlc3VtZV9hbmRfZ2V0KCkgc2hvdWxkIGJlIHVzZWQgaW5zdGVhZC4K PiAKPiBTZWUgZW5jbG9zZWQgcGF0Y2guCj4gCj4gVGhhbmtzLAo+IE1hdXJvCj4gCj4gW1BBVENI XSBtZWRpYTogaGFudHJvOiBkb2N1bWVudCB0aGUgdXNhZ2Ugb2YgcG1fcnVudGltZV9nZXRfc3lu YygpCj4gCj4gRGVzcGl0ZSBvdGhlciAqX2dldCgpLypfcHV0KCkgZnVuY3Rpb25zLCB3aGVyZSB1 c2FnZSBjb3VudCBpcwo+IGluY3JlbWVudGVkIG9ubHkgaWYgbm90IGVycm9ycywgdGhlIHBtX3J1 bnRpbWVfZ2V0X3N5bmMoKSBoYXMKPiBhIGRpZmZlcmVudCBiZWhhdmlvciwgaW5jcmVtZW50aW5n IHRoZSBjb3VudGVyICpldmVuKiBvbgo+IGVycm9ycy4KPiAKPiBUaGF0J3MgYW4gZXJyb3IgcHJv bmUgYmVoYXZpb3IsIGFzIHBlb3BsZSBvZnRlbiBmb3JnZXQgdG8KPiBkZWNyZW1lbnQgdGhlIHVz YWdlIGNvdW50ZXIuCj4gCj4gSG93ZXZlciwgdGhlIGhhbnRybyBkcml2ZXIgZGVwZW5kcyBvbiB0 aGlzIGJlaGF2aW9yLCBhcyBpdAo+IHdpbGwgZGVjcmVtZW50IHRoZSB1c2FnZV9jb3VudCB1bmNv bmRpdGlvbmFsbHkgYXQgdGhlIG0ybQo+IGpvYiBmaW5pc2ggdGltZSwgd2hpY2ggbWFrZXMgc2Vu c2UuCj4gCj4gU28sIGludGVhZCBvZiB1c2luZyB0aGUgcG1fcnVudGltZV9yZXN1bWVfYW5kX2dl dCgpIHRoYXQKPiB3b3VsZCBkZWNyZW1lbnQgdGhlIGNvdW50ZXIgb24gZXJyb3IsIGtlZXAgdGhl IGN1cnJlbnQKPiBBUEksIGJ1dCBhZGQgYSBkb2N1bWVudGF0aW9uIGV4cGxhaW5pbmcgdGhlIHJh dGlvbmFsZSBmb3IKPiBrZWVwIHVzaW5nIHBtX3J1bnRpbWVfZ2V0X3N5bmMoKS4KPiAKPiBTaWdu ZWQtb2ZmLWJ5OiBNYXVybyBDYXJ2YWxobyBDaGVoYWIgPG1jaGVoYWIraHVhd2VpQGtlcm5lbC5v cmc+CgpIbW0uLi4gbWF5YmUgaXQgY2FuLCBpbnN0ZWFkLCB1c2UgdGhlIHNhbWUgc29sdXRpb24g YXMgdGhlCnJrdmRlYyBkcml2ZXIgZG9lcywgaGF2aW5nIGEgam9iX2ZpbmlzaF9ub19wbSgpIHBs dXMgdGhlIG5vcm1hbApqb2JfZmluaXNoKCkuCgpXaGF0IGRvIHlvdSB0aGluaz8KClJlZ2FyZHMs Ck1hdXJvCgo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3N0YWdpbmcvbWVkaWEvaGFudHJvL2hh bnRyb19kcnYuYyBiL2RyaXZlcnMvc3RhZ2luZy9tZWRpYS9oYW50cm8vaGFudHJvX2Rydi5jCj4g aW5kZXggNTk1ZTgyYTgyNzI4Li45NmY5NDBjMWM4NWMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9z dGFnaW5nL21lZGlhL2hhbnRyby9oYW50cm9fZHJ2LmMKPiArKysgYi9kcml2ZXJzL3N0YWdpbmcv bWVkaWEvaGFudHJvL2hhbnRyb19kcnYuYwo+IEBAIC0xNTUsNiArMTU1LDEzIEBAIHN0YXRpYyB2 b2lkIGRldmljZV9ydW4odm9pZCAqcHJpdikKPiAgCXJldCA9IGNsa19idWxrX2VuYWJsZShjdHgt PmRldi0+dmFyaWFudC0+bnVtX2Nsb2NrcywgY3R4LT5kZXYtPmNsb2Nrcyk7Cj4gIAlpZiAocmV0 KQo+ICAJCWdvdG8gZXJyX2NhbmNlbF9qb2I7Cj4gKwo+ICsJLyoKPiArCSAqIFRoZSBwbV9ydW50 aW1lX2dldF9zeW5jKCkgd2lsbCBpbmNyZW1lbnQgZGV2LT5wb3dlci51c2FnZV9jb3VudCwKPiAr CSAqIGV2ZW4gb24gZXJyb3JzLiBUaGF0J3MgdGhlIGV4cGVjdGVkIGJlaGF2aW9yIGhlcmUsIHNp bmNlIHRoZQo+ICsJICogaGFudHJvX2pvYl9maW5pc2goKSBmdW5jdGlvbiBhdCB0aGUgZXJyb3Ig aGFuZGxpbmcgY29kZQo+ICsJICogd2lsbCBpbnRlcm5hbGx5IGNhbGwgcG1fcnVudGltZV9wdXRf YXV0b3N1c3BlbmQoKS4KPiArCSAqLwo+ICAJcmV0ID0gcG1fcnVudGltZV9nZXRfc3luYyhjdHgt PmRldi0+ZGV2KTsKPiAgCWlmIChyZXQgPCAwKQo+ICAJCWdvdG8gZXJyX2NhbmNlbF9qb2I7Cj4g Cj4gCgoKClRoYW5rcywKTWF1cm8KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KZGV2ZWwgbWFpbGluZyBsaXN0CmRldmVsQGxpbnV4ZHJpdmVycHJvamVjdC5v cmcKaHR0cDovL2RyaXZlcmRldi5saW51eGRyaXZlcnByb2plY3Qub3JnL21haWxtYW4vbGlzdGlu Zm8vZHJpdmVyZGV2LWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DB45C433B4 for ; Mon, 26 Apr 2021 12:42:34 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EBA7B61263 for ; Mon, 26 Apr 2021 12:42:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EBA7B61263 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dnc9zgGIbTRZN67hpuYSSRO4ClabpPU+Z82AueKuD+4=; b=Gj2Ntq+8aqRTM9rOQAdQ+eRYu 3N+f7Xnx5Pn7mS3wE/uz3FSmYaF327OEy53hVmulXcC+9e6wjBpZQAQPfcjBG58ABFOCHWLDcyfbB r2tM8RaPcFIha+NeiFBWgIx+02pLsdCauzJM8s+vV1maDrhJ7ic/ZxszUJhSXDVyR6XBchfHvu/MH la5hN/jX6Nvterh7Hr+wwHva/jDT7u4zVrZcz8CZNibKZPjz0bbXZJ7E4Xq082dxwmtha2kC3xesJ daChT1nadHXudxAlO88Iga5WLlipIG42xVtigkKfZTg1oPzGnk5L03rPRtQmV97iuv2cJjSLG9owG akA9hiP3g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lb0ZG-007dTf-US; Mon, 26 Apr 2021 12:42:27 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lb0ZE-007dTW-Iq for linux-rockchip@desiato.infradead.org; Mon, 26 Apr 2021 12:42:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Sender:Reply-To:Content-ID:Content-Description; bh=07IAhHyPYzDExQX32JC/1TDcttcZVe/1No0c9fa0Of8=; b=B0vjVEL5xfx+HnsIT+P26jGSlJ maN4l6P6+IagAl/8K3tJt/GgP5Y6TN+XNNsPTfAJi0SWvaEQTIpDKKkLDSmCIgmWprveE6kWm47co fwytgHsX354BdD6TtYcvwUT8EJPJQLMrEoAr9HpugHh3XDCh0qloaooL9Cw7iwzGUqOZf631NhYoO j/g+/oTWMMYnjJWqvfOqXdQ9eq1+cdbdF7TanXbZR0eQ5/mXmUuJhpWHM4+VbPzoCzAV2fB8nfA3O CiUP1qBQ52PT/NichgXlnKe5zExf0VbK/5zM+71A7fqcYgbBxrqLbut39k1UblCt3JBdrargd6ePh VXKWkpyQ==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lb0ZB-00Fxjh-OY for linux-rockchip@lists.infradead.org; Mon, 26 Apr 2021 12:42:23 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8106D611CE; Mon, 26 Apr 2021 12:42:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619440939; bh=6CTY4exOmL7l22aXrPfGFjlNeMqnCUXrgJOGfHlDDfo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VWTJ3W71PmyDqp2EIS/gk2qcSkPxTNg1O0TT+qg7l1CRzIQpx4x8gsLGCNeg8hde6 LLDLmGKzWciNzTnd4C+6dzY5zEounZxBbd9JgOYs5KCHTIlFzr0JImy7G9qczdd0FR qhtq4lWhv+/8FcQmtwsRDLXIJvtQRRIsqO1vl59SXtWthmgmlsJzAPNXEgoco4RVrw Ia6nGezETvVK1HyU80csrp7r0GLCF6hIwxruTJo96NyGn/7UM1uUm9LYfjZPBy/5bu SPqi4+DDkZ+3U0VKbxA/UxJ26R/9NcfdWZIqjUnt7SlVIouV29c7DIheCkQFZXiXFA iInt69scoTQrw== Date: Mon, 26 Apr 2021 14:42:12 +0200 From: Mauro Carvalho Chehab To: Ezequiel Garcia Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Greg Kroah-Hartman , Mauro Carvalho Chehab , Philipp Zabel , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH 13/78] staging: media: hantro_drv: use pm_runtime_resume_and_get() Message-ID: <20210426144212.1f8430ce@coco.lan> In-Reply-To: <20210426143327.4f9fb6ea@coco.lan> References: <0021158fb27035a56089683ee712fb3ed6f6032d.1619191723.git.mchehab+huawei@kernel.org> <780afdc9b263928ed378dfbd3eaa8a5509a59a35.camel@collabora.com> <20210426143327.4f9fb6ea@coco.lan> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210426_054221_910182_1C9CA42C X-CRM114-Status: GOOD ( 26.97 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org RW0gTW9uLCAyNiBBcHIgMjAyMSAxNDozMzoyNyArMDIwMApNYXVybyBDYXJ2YWxobyBDaGVoYWIg PG1jaGVoYWIraHVhd2VpQGtlcm5lbC5vcmc+IGVzY3JldmV1OgoKPiBFbSBTYXQsIDI0IEFwciAy MDIxIDIwOjIzOjUzIC0wMzAwCj4gRXplcXVpZWwgR2FyY2lhIDxlemVxdWllbEBjb2xsYWJvcmEu Y29tPiBlc2NyZXZldToKPiAKPiA+IEhpIE1hdXJvLAo+ID4gCj4gPiBPbiBTYXQsIDIwMjEtMDQt MjQgYXQgMDg6NDQgKzAyMDAsIE1hdXJvIENhcnZhbGhvIENoZWhhYiB3cm90ZTogIAo+ID4gPiBD b21taXQgZGQ4MDg4ZDVhODk2ICgiUE06IHJ1bnRpbWU6IEFkZCBwbV9ydW50aW1lX3Jlc3VtZV9h bmRfZ2V0IHRvIGRlYWwgd2l0aCB1c2FnZSBjb3VudGVyIikKPiA+ID4gYWRkZWQgcG1fcnVudGlt ZV9yZXN1bWVfYW5kX2dldCgpIGluIG9yZGVyIHRvIGF1dG9tYXRpY2FsbHkgaGFuZGxlCj4gPiA+ IGRldi0+cG93ZXIudXNhZ2VfY291bnQgZGVjcmVtZW50IG9uIGVycm9ycy4KPiA+ID4gCj4gPiA+ IFVzZSB0aGUgbmV3IEFQSSwgaW4gb3JkZXIgdG8gY2xlYW51cCB0aGUgZXJyb3IgY2hlY2sgbG9n aWMuCj4gPiA+IAo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBNYXVybyBDYXJ2YWxobyBDaGVoYWIgPG1j aGVoYWIraHVhd2VpQGtlcm5lbC5vcmc+Cj4gPiA+IC0tLQo+ID4gPiDCoGRyaXZlcnMvc3RhZ2lu Zy9tZWRpYS9oYW50cm8vaGFudHJvX2Rydi5jIHwgMiArLQo+ID4gPiDCoDEgZmlsZSBjaGFuZ2Vk LCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQo+ID4gPiAKPiA+ID4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvc3RhZ2luZy9tZWRpYS9oYW50cm8vaGFudHJvX2Rydi5jIGIvZHJpdmVycy9zdGFn aW5nL21lZGlhL2hhbnRyby9oYW50cm9fZHJ2LmMKPiA+ID4gaW5kZXggNTk1ZTgyYTgyNzI4Li4z MTQ3ZGNiZWJlYjkgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvc3RhZ2luZy9tZWRpYS9oYW50 cm8vaGFudHJvX2Rydi5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvc3RhZ2luZy9tZWRpYS9oYW50cm8v aGFudHJvX2Rydi5jCj4gPiA+IEBAIC0xNTUsNyArMTU1LDcgQEAgc3RhdGljIHZvaWQgZGV2aWNl X3J1bih2b2lkICpwcml2KQo+ID4gPiDCoMKgwqDCoMKgwqDCoMKgcmV0ID0gY2xrX2J1bGtfZW5h YmxlKGN0eC0+ZGV2LT52YXJpYW50LT5udW1fY2xvY2tzLCBjdHgtPmRldi0+Y2xvY2tzKTsKPiA+ ID4gwqDCoMKgwqDCoMKgwqDCoGlmIChyZXQpCj4gPiA+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgZ290byBlcnJfY2FuY2VsX2pvYjsKPiA+ID4gLcKgwqDCoMKgwqDCoMKgcmV0ID0g cG1fcnVudGltZV9nZXRfc3luYyhjdHgtPmRldi0+ZGV2KTsKPiA+ID4gK8KgwqDCoMKgwqDCoMKg cmV0ID0gcG1fcnVudGltZV9yZXN1bWVfYW5kX2dldChjdHgtPmRldi0+ZGV2KTsKPiA+ID4gwqDC oMKgwqDCoMKgwqDCoGlmIChyZXQgPCAwKQo+ID4gPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoGdvdG8gZXJyX2NhbmNlbF9qb2I7Cj4gPiA+IMKgICAgIAo+ID4gCj4gPiBTZWVtcyB0 aGlzIG9uZSBuZWVkcyBhIGRpZmZlcmVudCBmaXg6IGVycl9jYW5jZWxfam9iCj4gPiB3aWxsIGNh bGwgaGFudHJvX2pvYl9maW5pc2ggd2hpY2ggaGFzIGEgcG1fcnVudGltZSBwdXQuICAKPiAKPiBH b29kIHBvaW50LiBUaGFua3MgZm9yIHJldmlld2luZyBpdCEKPiAKPiBJdCBzb3VuZHMgdGhhdCB0 aGlzIGlzIGEgcGxhY2Ugd2hlcmUgdGhlIGJlc3Qgc2VlbXMKPiB0byBrZWVwIHVzaW5nIHBtX3J1 bnRpbWVfZ2V0X3N5bmMoKSwgYnV0IGxldCdzIGF0IGxlYXN0IGFkZCBhCj4gY29tbWVudCBleHBs YWluaW5nIHdoeSBpdCBzaG91bGQgYmUga2VwdCBoZXJlLiBUaGlzIHNob3VsZAo+IGhlbHAgdG8g YXZvaWQgcGVvcGxlIHRvIGNvcHktYW5kLXBhc3RlIHRoZSBjb2RlIG9uIHNpdHVhdGlvbnMKPiB3 aGVyZSBwbV9ydW50aW1lX3Jlc3VtZV9hbmRfZ2V0KCkgc2hvdWxkIGJlIHVzZWQgaW5zdGVhZC4K PiAKPiBTZWUgZW5jbG9zZWQgcGF0Y2guCj4gCj4gVGhhbmtzLAo+IE1hdXJvCj4gCj4gW1BBVENI XSBtZWRpYTogaGFudHJvOiBkb2N1bWVudCB0aGUgdXNhZ2Ugb2YgcG1fcnVudGltZV9nZXRfc3lu YygpCj4gCj4gRGVzcGl0ZSBvdGhlciAqX2dldCgpLypfcHV0KCkgZnVuY3Rpb25zLCB3aGVyZSB1 c2FnZSBjb3VudCBpcwo+IGluY3JlbWVudGVkIG9ubHkgaWYgbm90IGVycm9ycywgdGhlIHBtX3J1 bnRpbWVfZ2V0X3N5bmMoKSBoYXMKPiBhIGRpZmZlcmVudCBiZWhhdmlvciwgaW5jcmVtZW50aW5n IHRoZSBjb3VudGVyICpldmVuKiBvbgo+IGVycm9ycy4KPiAKPiBUaGF0J3MgYW4gZXJyb3IgcHJv bmUgYmVoYXZpb3IsIGFzIHBlb3BsZSBvZnRlbiBmb3JnZXQgdG8KPiBkZWNyZW1lbnQgdGhlIHVz YWdlIGNvdW50ZXIuCj4gCj4gSG93ZXZlciwgdGhlIGhhbnRybyBkcml2ZXIgZGVwZW5kcyBvbiB0 aGlzIGJlaGF2aW9yLCBhcyBpdAo+IHdpbGwgZGVjcmVtZW50IHRoZSB1c2FnZV9jb3VudCB1bmNv bmRpdGlvbmFsbHkgYXQgdGhlIG0ybQo+IGpvYiBmaW5pc2ggdGltZSwgd2hpY2ggbWFrZXMgc2Vu c2UuCj4gCj4gU28sIGludGVhZCBvZiB1c2luZyB0aGUgcG1fcnVudGltZV9yZXN1bWVfYW5kX2dl dCgpIHRoYXQKPiB3b3VsZCBkZWNyZW1lbnQgdGhlIGNvdW50ZXIgb24gZXJyb3IsIGtlZXAgdGhl IGN1cnJlbnQKPiBBUEksIGJ1dCBhZGQgYSBkb2N1bWVudGF0aW9uIGV4cGxhaW5pbmcgdGhlIHJh dGlvbmFsZSBmb3IKPiBrZWVwIHVzaW5nIHBtX3J1bnRpbWVfZ2V0X3N5bmMoKS4KPiAKPiBTaWdu ZWQtb2ZmLWJ5OiBNYXVybyBDYXJ2YWxobyBDaGVoYWIgPG1jaGVoYWIraHVhd2VpQGtlcm5lbC5v cmc+CgpIbW0uLi4gbWF5YmUgaXQgY2FuLCBpbnN0ZWFkLCB1c2UgdGhlIHNhbWUgc29sdXRpb24g YXMgdGhlCnJrdmRlYyBkcml2ZXIgZG9lcywgaGF2aW5nIGEgam9iX2ZpbmlzaF9ub19wbSgpIHBs dXMgdGhlIG5vcm1hbApqb2JfZmluaXNoKCkuCgpXaGF0IGRvIHlvdSB0aGluaz8KClJlZ2FyZHMs Ck1hdXJvCgo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3N0YWdpbmcvbWVkaWEvaGFudHJvL2hh bnRyb19kcnYuYyBiL2RyaXZlcnMvc3RhZ2luZy9tZWRpYS9oYW50cm8vaGFudHJvX2Rydi5jCj4g aW5kZXggNTk1ZTgyYTgyNzI4Li45NmY5NDBjMWM4NWMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9z dGFnaW5nL21lZGlhL2hhbnRyby9oYW50cm9fZHJ2LmMKPiArKysgYi9kcml2ZXJzL3N0YWdpbmcv bWVkaWEvaGFudHJvL2hhbnRyb19kcnYuYwo+IEBAIC0xNTUsNiArMTU1LDEzIEBAIHN0YXRpYyB2 b2lkIGRldmljZV9ydW4odm9pZCAqcHJpdikKPiAgCXJldCA9IGNsa19idWxrX2VuYWJsZShjdHgt PmRldi0+dmFyaWFudC0+bnVtX2Nsb2NrcywgY3R4LT5kZXYtPmNsb2Nrcyk7Cj4gIAlpZiAocmV0 KQo+ICAJCWdvdG8gZXJyX2NhbmNlbF9qb2I7Cj4gKwo+ICsJLyoKPiArCSAqIFRoZSBwbV9ydW50 aW1lX2dldF9zeW5jKCkgd2lsbCBpbmNyZW1lbnQgZGV2LT5wb3dlci51c2FnZV9jb3VudCwKPiAr CSAqIGV2ZW4gb24gZXJyb3JzLiBUaGF0J3MgdGhlIGV4cGVjdGVkIGJlaGF2aW9yIGhlcmUsIHNp bmNlIHRoZQo+ICsJICogaGFudHJvX2pvYl9maW5pc2goKSBmdW5jdGlvbiBhdCB0aGUgZXJyb3Ig aGFuZGxpbmcgY29kZQo+ICsJICogd2lsbCBpbnRlcm5hbGx5IGNhbGwgcG1fcnVudGltZV9wdXRf YXV0b3N1c3BlbmQoKS4KPiArCSAqLwo+ICAJcmV0ID0gcG1fcnVudGltZV9nZXRfc3luYyhjdHgt PmRldi0+ZGV2KTsKPiAgCWlmIChyZXQgPCAwKQo+ICAJCWdvdG8gZXJyX2NhbmNlbF9qb2I7Cj4g Cj4gCgoKClRoYW5rcywKTWF1cm8KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtcm9ja2NoaXAK