All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Zhengxun Li <zhengxunli@mxic.com.tw>
Cc: linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org,
	tudor.ambarus@microchip.com, miquel.raynal@bootlin.com,
	jaimeliao@mxic.com.tw
Subject: Re: [PATCH v3 3/3] spi: mxic: patch for octal DTR mode support
Date: Mon, 26 Apr 2021 17:53:58 +0100	[thread overview]
Message-ID: <20210426165358.GI4590@sirena.org.uk> (raw)
In-Reply-To: <1618900179-14546-4-git-send-email-zhengxunli@mxic.com.tw>

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

On Tue, Apr 20, 2021 at 02:29:39PM +0800, Zhengxun Li wrote:

> -	return spi_mem_default_supports_op(mem, op);
> +	all_false = !op->cmd.dtr && !op->addr.dtr && !op->dummy.dtr &&
> +		    !op->data.dtr;
> +
> +	if (all_false)

This feels like we might want a spi_mem_op_is_dtr() helper?  I can see
other controllers wanting a similar check.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Zhengxun Li <zhengxunli@mxic.com.tw>
Cc: linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org,
	tudor.ambarus@microchip.com, miquel.raynal@bootlin.com,
	jaimeliao@mxic.com.tw
Subject: Re: [PATCH v3 3/3] spi: mxic: patch for octal DTR mode support
Date: Mon, 26 Apr 2021 17:53:58 +0100	[thread overview]
Message-ID: <20210426165358.GI4590@sirena.org.uk> (raw)
In-Reply-To: <1618900179-14546-4-git-send-email-zhengxunli@mxic.com.tw>


[-- Attachment #1.1: Type: text/plain, Size: 340 bytes --]

On Tue, Apr 20, 2021 at 02:29:39PM +0800, Zhengxun Li wrote:

> -	return spi_mem_default_supports_op(mem, op);
> +	all_false = !op->cmd.dtr && !op->addr.dtr && !op->dummy.dtr &&
> +		    !op->data.dtr;
> +
> +	if (all_false)

This feels like we might want a spi_mem_op_is_dtr() helper?  I can see
other controllers wanting a similar check.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 144 bytes --]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2021-04-26 16:54 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-20  6:29 [PATCH v3 0/3] Add octal DTR support for Macronix flash Zhengxun Li
2021-04-20  6:29 ` Zhengxun Li
2021-04-20  6:29 ` [PATCH v3 1/3] mtd: spi-nor: macronix: add support for Macronix octal dtr operation Zhengxun Li
2021-04-20  6:29   ` Zhengxun Li
2021-04-27  2:36   ` Pratyush Yadav
2021-04-27  2:36     ` Pratyush Yadav
2021-05-04  5:31     ` zhengxunli
2021-05-04  5:31       ` zhengxunli
2021-05-04  7:42       ` Pratyush Yadav
2021-05-04  7:42         ` Pratyush Yadav
2021-05-05  8:29         ` zhengxunli
2021-05-05  8:29           ` zhengxunli
2021-04-20  6:29 ` [PATCH v3 2/3] mtd: spi-nor: macronix: add support for Macronix octaflash series Zhengxun Li
2021-04-20  6:29   ` Zhengxun Li
2021-04-27  2:47   ` Pratyush Yadav
2021-04-27  2:47     ` Pratyush Yadav
2021-05-04  5:38     ` zhengxunli
2021-05-04  5:38       ` zhengxunli
2021-04-20  6:29 ` [PATCH v3 3/3] spi: mxic: patch for octal DTR mode support Zhengxun Li
2021-04-20  6:29   ` Zhengxun Li
2021-04-26 16:53   ` Mark Brown [this message]
2021-04-26 16:53     ` Mark Brown
2021-04-27  1:48     ` zhengxunli
2021-04-27  1:48       ` zhengxunli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210426165358.GI4590@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=jaimeliao@mxic.com.tw \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=tudor.ambarus@microchip.com \
    --cc=zhengxunli@mxic.com.tw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.