From: Patrick Menschel <menschel.p@posteo.de>
To: Oliver Hartkopp <socketcan@hartkopp.net>,
Marc Kleine-Budde <mkl@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/3] can-isotp: Add more comprehensive error messages
Date: Tue, 27 Apr 2021 05:21:46 +0000 [thread overview]
Message-ID: <20210427052150.2308-1-menschel.p@posteo.de> (raw)
This patch series adds more comprehensive error messages to isotp.c by
using error pointers instead of decimal error numbers.
https://www.kernel.org/doc/html/latest/core-api/printk-formats.html#error-pointers
It also adds a more comprehensive error message in case txqueue is full
due to a burst transfer, telling the user to increase txqueuelen to
prevent this from happening.
Patrick Menschel (3):
can-isotp: Change error format from decimal to symbolic error names
can-isotp: Add symbolic error message to isotp_module_init()
can-isotp: Add error message if txqueuelen is too small
net/can/isotp.c | 20 +++++++++++---------
1 file changed, 11 insertions(+), 9 deletions(-)
--
2.17.1
next reply other threads:[~2021-04-27 5:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 5:21 Patrick Menschel [this message]
2021-04-27 5:21 ` [PATCH v2 1/3] can-isotp: Change error format from decimal to symbolic error names Patrick Menschel
2021-04-27 5:21 ` [PATCH v2 2/3] can-isotp: Add symbolic error message to isotp_module_init() Patrick Menschel
2021-04-27 5:21 ` [PATCH v2 3/3] can-isotp: Add error message if txqueuelen is too small Patrick Menschel
2021-04-27 7:16 ` Marc Kleine-Budde
2021-04-27 13:13 ` Patrick Menschel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210427052150.2308-1-menschel.p@posteo.de \
--to=menschel.p@posteo.de \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.