From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH 0/2] reset: fix reset_get_by_index_nodev index handling
Date: Tue, 27 Apr 2021 07:31:49 -0400 [thread overview]
Message-ID: <20210427113149.GQ17669@bill-the-cat> (raw)
In-Reply-To: <076e7fbd-94e4-606e-4d00-09c1f98fd7f5@baylibre.com>
On Tue, Apr 27, 2021 at 09:37:11AM +0200, Neil Armstrong wrote:
> Hi Tom, Simon,
>
> On 20/04/2021 10:42, Neil Armstrong wrote:
> > A regression weas detected on Amlogic G12A/G12B SoCs, where HDMI output was disable
> > even when Linux was booting.
> >
> > Bisect reports 139e4a1cbe ("drivers: reset: Add a managed API to get reset controllers from the DT")
> > as the offending commit.
> >
> > But the error is in ea9dc35aab ("reset: Get the RESET by index without device") where a spurius "> 0"
> > was added to the index handling.
> >
> > But the dm_test_reset_base() test did not catch it.
> >
> > The first commit extends the test to catch the regression, and the second patch fixes the regression.
>
> So you have any comment on the patch order here ? Should I push the fixed test after the fix ?
I'll grab these shortly, thanks for the reminder.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210427/f223429e/attachment.sig>
prev parent reply other threads:[~2021-04-27 11:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 8:42 [PATCH 0/2] reset: fix reset_get_by_index_nodev index handling Neil Armstrong
2021-04-20 8:42 ` Neil Armstrong
2021-04-20 8:42 ` [PATCH 1/2] test: reset: Extend base reset test to catch error Neil Armstrong
2021-04-20 8:42 ` Neil Armstrong
2021-04-27 16:46 ` Tom Rini
2021-04-20 8:42 ` [PATCH 2/2] reset: fix reset_get_by_index_nodev index handling Neil Armstrong
2021-04-20 8:42 ` Neil Armstrong
2021-04-27 16:46 ` Tom Rini
2021-04-27 7:37 ` [PATCH 0/2] " Neil Armstrong
2021-04-27 7:37 ` Neil Armstrong
2021-04-27 11:31 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210427113149.GQ17669@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.