From: Eduardo Habkost <ehabkost@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: thuth@redhat.com, "Michael S. Tsirkin" <mst@redhat.com>,
libvir-list@redhat.com, qemu-devel@nongnu.org,
pbonzini@redhat.com, philmd@redhat.com
Subject: Re: [PATCH] Deprecate pmem=on with non-DAX capable backend file
Date: Tue, 27 Apr 2021 16:48:48 -0400 [thread overview]
Message-ID: <20210427204848.ubgncujxjxcufpul@habkost.net> (raw)
In-Reply-To: <20210111203332.740815-1-imammedo@redhat.com>
On Mon, Jan 11, 2021 at 03:33:32PM -0500, Igor Mammedov wrote:
> It is not safe to pretend that emulated NVDIMM supports
> persistence while backend actually failed to enable it
> and used non-persistent mapping as fall back.
> Instead of falling-back, QEMU should be more strict and
> error out with clear message that it's not supported.
> So if user asks for persistence (pmem=on), they should
> store backing file on NVDIMM.
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
I'm queueing this for 6.1, after changing "since 6.0" to "since 6.1".
Sorry for letting it fall through the cracks.
--
Eduardo
next prev parent reply other threads:[~2021-04-27 20:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 20:33 [PATCH] Deprecate pmem=on with non-DAX capable backend file Igor Mammedov
2021-01-20 19:31 ` Igor Mammedov
2021-01-20 21:35 ` Philippe Mathieu-Daudé
2021-02-09 16:09 ` Igor Mammedov
2021-04-27 20:48 ` Eduardo Habkost [this message]
2021-04-28 16:29 ` Eduardo Habkost
2021-05-03 12:14 ` Igor Mammedov
-- strict thread matches above, loose matches on Subject: below --
2020-12-29 17:29 Igor Mammedov
2020-12-29 18:04 ` Philippe Mathieu-Daudé
2020-12-29 20:11 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210427204848.ubgncujxjxcufpul@habkost.net \
--to=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=libvir-list@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.