From: Christoph Hellwig <hch@lst.de>
To: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Tomasz Figa <tfiga@chromium.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Ricardo Ribalda <ribalda@chromium.org>,
Christoph Hellwig <hch@lst.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 8/8] videobuf2: handle non-contiguous DMA allocations
Date: Wed, 28 Apr 2021 08:14:51 +0200 [thread overview]
Message-ID: <20210428061451.GB5084@lst.de> (raw)
In-Reply-To: <20210427131344.139443-9-senozhatsky@chromium.org>
On Tue, Apr 27, 2021 at 10:13:43PM +0900, Sergey Senozhatsky wrote:
> This adds support for new noncontiguous DMA API, which
> requires allocators to have two execution branches: one
> for the current API, and one for the new one.
>
> Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
> [hch: untested conversion to the ne API]
> Signed-off-by: Christoph Hellwig <hch@lst.de>
I think you can skip my signoff and the note here for the trivial
conversion.
The code looks fine to me from the DMA API perspective:
Acked-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2021-04-28 6:14 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 13:13 [PATCHv2 0/8] videobuf2: support new noncontiguous DMA API Sergey Senozhatsky
2021-04-27 13:13 ` [PATCHv2 1/8] videobuf2: rework vb2_mem_ops API Sergey Senozhatsky
2021-04-27 13:13 ` [PATCHv2 2/8] videobuf2: inverse buffer cache_hints flags Sergey Senozhatsky
2021-04-27 13:13 ` [PATCHv2 3/8] videobuf2: split buffer cache_hints initialisation Sergey Senozhatsky
2021-04-27 13:13 ` [PATCHv2 4/8] videobuf2: move cache_hints handling to allocators Sergey Senozhatsky
2021-04-27 13:13 ` [PATCHv2 5/8] videobuf2: add V4L2_MEMORY_FLAG_NON_COHERENT flag Sergey Senozhatsky
2021-04-27 13:13 ` [PATCHv2 6/8] videobuf2: add queue memory coherency parameter Sergey Senozhatsky
2021-04-27 13:13 ` [PATCHv2 7/8] videobuf2: handle V4L2_MEMORY_FLAG_NON_COHERENT flag Sergey Senozhatsky
2021-05-01 3:48 ` Sergey Senozhatsky
2021-06-03 11:32 ` Hans Verkuil
2021-06-17 1:46 ` Sergey Senozhatsky
2021-04-27 13:13 ` [PATCHv2 8/8] videobuf2: handle non-contiguous DMA allocations Sergey Senozhatsky
2021-04-28 6:14 ` Christoph Hellwig [this message]
2021-06-03 11:59 ` Hans Verkuil
2021-06-17 7:56 ` Sergey Senozhatsky
2021-06-17 8:01 ` Christoph Hellwig
2021-06-17 8:30 ` Tomasz Figa
2021-06-17 8:52 ` Christoph Hellwig
2021-06-17 9:40 ` Tomasz Figa
2021-06-17 10:06 ` Christoph Hellwig
2021-06-18 3:21 ` Tomasz Figa
2021-06-18 4:25 ` Christoph Hellwig
2021-06-18 4:44 ` Tomasz Figa
2021-06-22 7:33 ` Christoph Hellwig
2021-07-07 12:42 ` Tomasz Figa
2021-06-25 3:10 ` Sergey Senozhatsky
2021-07-07 12:48 ` Tomasz Figa
2021-07-07 13:29 ` Sergey Senozhatsky
2021-07-07 14:10 ` Tomasz Figa
2021-07-09 7:20 ` Sergey Senozhatsky
2021-06-17 7:56 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210428061451.GB5084@lst.de \
--to=hch@lst.de \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ribalda@chromium.org \
--cc=senozhatsky@chromium.org \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.