From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CFD4C43460 for ; Wed, 28 Apr 2021 07:42:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 47644613EF for ; Wed, 28 Apr 2021 07:42:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236950AbhD1Hmo (ORCPT ); Wed, 28 Apr 2021 03:42:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:47288 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236816AbhD1Hmm (ORCPT ); Wed, 28 Apr 2021 03:42:42 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C2E67613F8; Wed, 28 Apr 2021 07:41:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619595718; bh=k2BZ9xZikA1qiwskEWEetLqBAKCp0Z9oJXFgxTUYmtw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Vi8Q41F1HdlBeYMrlKgVG2j609ljUqp7dOT+lug12/AGgDYNLVVa5LAIGQq4UN6qQ gypWfjQczW66W9iirusrFuTv6SQ6MmRRqf6sDs/KIVveWLpKorA4BtJr8CdFlxScQL mb3MszHz9ctWoPXXxLTqUua0QBFkJMNN/XgyRkkosY3K5dg1lpuSO5DrPYioom0LFv 9AQbNagmHL488T5TYbi2UXalXNcC+BrwSP2Frms+Q910aJoY8tlJ0pdiV6ZvevycU1 OdLILcanhaXgJzGGyu+huT70QFJgbL3T3ZsjtkvaVj/egYr23D+HilhkbOxiKznIL0 qz+UtpG9PSqAQ== Date: Wed, 28 Apr 2021 09:41:52 +0200 From: Mauro Carvalho Chehab To: Sylwester Nawrocki Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Hans Verkuil , Marek Szyprowski , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v3 13/79] media: s5p: fix pm_runtime_get_sync() usage count Message-ID: <20210428094152.0fbf3f15@coco.lan> In-Reply-To: References: X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, 27 Apr 2021 12:51:45 +0200 Sylwester Nawrocki escreveu: > On 27.04.2021 12:26, Mauro Carvalho Chehab wrote: > > The pm_runtime_get_sync() internally increments the > > dev->power.usage_count without decrementing it, even on errors. > > Replace it by the new pm_runtime_resume_and_get(), introduced by: > > commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") > > in order to properly decrement the usage counter and avoid memory > > leaks. > > > > While here, check if the PM runtime error was caught at > > s5p_cec_adap_enable(). > > > > Signed-off-by: Mauro Carvalho Chehab > > --- > > drivers/media/cec/platform/s5p/s5p_cec.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/media/cec/platform/s5p/s5p_cec.c b/drivers/media/cec/platform/s5p/s5p_cec.c > > index 2a3e7ffefe0a..2250c1cbc64e 100644 > > --- a/drivers/media/cec/platform/s5p/s5p_cec.c > > +++ b/drivers/media/cec/platform/s5p/s5p_cec.c > > @@ -35,10 +35,13 @@ MODULE_PARM_DESC(debug, "debug level (0-2)"); > > > > static int s5p_cec_adap_enable(struct cec_adapter *adap, bool enable) > > { > > + int ret; > > struct s5p_cec_dev *cec = cec_get_drvdata(adap); > > > > if (enable) { > > - pm_runtime_get_sync(cec->dev); > > + ret = pm_runtime_resume_and_get(cec->dev); > > + if (ret < 0) > > + return ret; > > > > s5p_cec_reset(cec); > > Reviewed-by: Sylwester Nawrocki > > Not related to this patch, it seems there is bug in the second > 'if (enable)' branch, where pm_runtime_disable() is used > instead of pm_runtime_put(_sync)(). Yeah. I'll add an additional patch before this series in order to fix the bug. Thanks! Regards, Mauro Thanks, Mauro