All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: linux-trace-devel@vger.kernel.org
Cc: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Subject: [PATCH v2 9/9] kernel-shark: Hide all plugin internals
Date: Wed, 28 Apr 2021 16:47:30 +0300	[thread overview]
Message-ID: <20210428134730.187533-10-y.karadz@gmail.com> (raw)
In-Reply-To: <20210428134730.187533-1-y.karadz@gmail.com>

Nothing except the plugin's interface must be visible outside.

Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
---
 src/plugins/MissedEvents.cpp | 2 +-
 src/plugins/SchedEvents.cpp  | 5 +++--
 src/plugins/sched_events.c   | 4 ++--
 3 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/plugins/MissedEvents.cpp b/src/plugins/MissedEvents.cpp
index cf0ed34..fdd47c8 100644
--- a/src/plugins/MissedEvents.cpp
+++ b/src/plugins/MissedEvents.cpp
@@ -89,7 +89,7 @@ static PlotObject *makeShape(std::vector<const Graph *> graph,
  * @param val: Process or CPU Id value.
  * @param draw_action: Draw action identifier.
  */
-void draw_missed_events(kshark_cpp_argv *argv_c,
+__hidden void draw_missed_events(kshark_cpp_argv *argv_c,
 			int sd, int val, int draw_action)
 {
 	KsCppArgV *argvCpp = KS_ARGV_TO_CPP(argv_c);
diff --git a/src/plugins/SchedEvents.cpp b/src/plugins/SchedEvents.cpp
index a81182e..b73e45f 100644
--- a/src/plugins/SchedEvents.cpp
+++ b/src/plugins/SchedEvents.cpp
@@ -30,7 +30,7 @@ static KsMainWindow *ks_ptr;
  * @brief Provide the plugin with a pointer to the KsMainWindow object (the GUI
  * itself) such that the plugin can manipulate the GUI.
  */
-void *plugin_set_gui_ptr(void *gui_ptr)
+__hidden void *plugin_set_gui_ptr(void *gui_ptr)
 {
 	ks_ptr = static_cast<KsMainWindow *>(gui_ptr);
 	return nullptr;
@@ -152,7 +152,8 @@ static void secondPass(plugin_sched_context *plugin_ctx)
  * @param pid: Process Id.
  * @param draw_action: Draw action identifier.
  */
-void plugin_draw(kshark_cpp_argv *argv_c, int sd, int pid, int draw_action)
+__hidden void plugin_draw(kshark_cpp_argv *argv_c,
+			  int sd, int pid, int draw_action)
 {
 	plugin_sched_context *plugin_ctx;
 
diff --git a/src/plugins/sched_events.c b/src/plugins/sched_events.c
index 64dff8d..659ecc3 100644
--- a/src/plugins/sched_events.c
+++ b/src/plugins/sched_events.c
@@ -47,7 +47,7 @@ static void plugin_sched_set_pid(ks_num_field_t *field,
  *
  * @param field: Input location for the data field.
  */
-int plugin_sched_get_pid(ks_num_field_t field)
+__hidden int plugin_sched_get_pid(ks_num_field_t field)
 {
 	return field & PID_MASK;
 }
@@ -67,7 +67,7 @@ static void plugin_sched_set_prev_state(ks_num_field_t *field,
  *
  * @param field: Input location for the data field.
  */
-int plugin_sched_get_prev_state(ks_num_field_t field)
+__hidden int plugin_sched_get_prev_state(ks_num_field_t field)
 {
 	tep_num_field_t mask = PREV_STATE_MASK << PREV_STATE_SHIFT;
 	return (field & mask) >> PREV_STATE_SHIFT;
-- 
2.27.0


  parent reply	other threads:[~2021-04-28 13:47 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-28 13:47 [PATCH v2 0/9] (Not so) Minor fixes toward KS 2.0 Yordan Karadzhov (VMware)
2021-04-28 13:47 ` [PATCH v2 1/9] kernel-shark: Fix the build for 32b systems Yordan Karadzhov (VMware)
2021-04-28 13:47 ` [PATCH v2 2/9] kernel-shark: Add "cron" job to workflows Yordan Karadzhov (VMware)
2021-04-28 13:47 ` [PATCH v2 3/9] kernel-shark: Fix KS_DEFINE_PLUGIN_CONTEXT macro Yordan Karadzhov (VMware)
2021-05-06 18:11   ` Steven Rostedt
2021-05-10 11:53     ` Yordan Karadzhov
2021-05-10 18:25       ` Steven Rostedt
2021-05-10 18:50         ` Yordan Karadzhov
2021-05-10 19:23           ` Steven Rostedt
2021-05-10 20:18             ` Yordan Karadzhov
2021-05-10 20:34             ` Yordan Karadzhov
2021-05-10 21:02               ` Steven Rostedt
2021-05-11 13:30                 ` Yordan Karadzhov
2021-04-28 13:47 ` [PATCH v2 4/9] kernel-shark: Add cleanup of all plugin contexts Yordan Karadzhov (VMware)
2021-04-28 13:47 ` [PATCH v2 5/9] kernel-shark: Fix memory leak in "sched events" plugin Yordan Karadzhov (VMware)
2021-04-28 13:47 ` [PATCH v2 6/9] kernel-shark: Disable the pop-up offset dialog Yordan Karadzhov (VMware)
2021-04-28 13:47 ` [PATCH v2 7/9] kernel-shark: Remove kvm_combo from the list of default plugins Yordan Karadzhov (VMware)
2021-05-06 18:25   ` Steven Rostedt
2021-05-10 12:15     ` Yordan Karadzhov
2021-04-28 13:47 ` [PATCH v2 8/9] kernel-shark: Remove debugging print out from plugins Yordan Karadzhov (VMware)
2021-04-28 13:47 ` Yordan Karadzhov (VMware) [this message]
2021-05-06 18:26 ` [PATCH v2 0/9] (Not so) Minor fixes toward KS 2.0 Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210428134730.187533-10-y.karadz@gmail.com \
    --to=y.karadz@gmail.com \
    --cc=linux-trace-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.