From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20E5AC433B4 for ; Wed, 28 Apr 2021 20:53:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C96416144C for ; Wed, 28 Apr 2021 20:53:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229931AbhD1UyU (ORCPT ); Wed, 28 Apr 2021 16:54:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:55214 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230072AbhD1UyG (ORCPT ); Wed, 28 Apr 2021 16:54:06 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DDF506140C; Wed, 28 Apr 2021 20:53:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619643201; bh=99aQgYpV6yLmeDba8HvEXO8wySN1Y1aGrrXQa8Wgmo0=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=Xtx+Tiuq+haypYskR8nkuJ8Ed/d9pf2Y1vPEY3G8ri86MjENkLr5+qDqPjxwReQ6t rO1SyNNyzeLQ4dUw6Ulje/pcBdcalOSjxHSxyXoHbaKjyPss4kDfWTZZPmQj4Ifod/ kwJCfnWfN7+A4HJ3jKjOh7d8N1s5IwIk4NmzUAG2OBA6tKUlKhuJIX5MWUA6xWO/jy Is6llTCoAJzJedVqYiNIlrGWEmAyGlYlftd/Zq14MsIGl7RirwTOZ/wx+t0inw6fxT G/g31r4Cxtr4acCme3yN9TMs5O4hHT3tZfHqcU12hKQ861xqI9O4KiCFbdBrMfCxZT OU5G9qBcTKglA== Date: Wed, 28 Apr 2021 15:53:19 -0500 From: Bjorn Helgaas To: Jim Quinlan Cc: Jim Quinlan , linux-pci@vger.kernel.org, Nicolas Saenz Julienne , bcm-kernel-feedback-list@broadcom.com, Florian Fainelli , Hans de Goede , Jens Axboe , Jim Quinlan , linux-arm-kernel@lists.infradead.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Lorenzo Pieralisi , Rob Herring , Amjad Ouled-Ameur , Philipp Zabel Subject: Re: [PATCH v5 0/2] ata: ahci_brcm: Fix use of BCM7216 reset controller Message-ID: <20210428205319.GA429792@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org [+cc Amjad, Philipp: possible issue with 557acb3d2cd9 ("reset: make shared pulsed reset controls re-triggerable") below; report at https://lore.kernel.org/linux-ide/20210428200058.GA366202@bjorn-Precision-5520/] On Wed, Apr 28, 2021 at 04:34:00PM -0400, Jim Quinlan wrote: > On Wed, Apr 28, 2021 at 4:01 PM Bjorn Helgaas wrote: > > On Fri, Mar 12, 2021 at 03:45:53PM -0500, Jim Quinlan wrote: > > > v5 -- Improved (I hope) commit description (Bjorn). > > > -- Rnamed error labels (Krzyszt). > > > -- Fixed typos. > > > > > > v4 -- does not rely on a pending commit, unlike v3. > > > > > > v3 -- discard commit from v2; instead rely on the new function > > > reset_control_rearm provided in a recent commit [1] applied > > > to reset/next. > > > -- New commit to correct pcie-brcmstb.c usage of a reset controller > > > to use reset/rearm verses deassert/assert. > > > > > > v2 -- refactor rescal-reset driver to implement assert/deassert rather than > > > reset because the reset call only fires once per lifetime and we need > > > to reset after every resume from S2 or S3. > > > -- Split the use of "ahci" and "rescal" controllers in separate fields > > > to keep things simple. > > > > > > v1 -- original > > > > > > Jim Quinlan (2): > > > ata: ahci_brcm: Fix use of BCM7216 reset controller > > > PCI: brcmstb: Use reset/rearm instead of deassert/assert > > > > > > drivers/ata/ahci_brcm.c | 46 +++++++++++++-------------- > > > drivers/pci/controller/pcie-brcmstb.c | 19 +++++++---- > > > 2 files changed, 36 insertions(+), 29 deletions(-) > > > > Tripped over these errors while build testing with the .config below. > > This is on the pci/brcmstb branch from > > git://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git > > > > Dropping the pci/brcmstb branch while we get this figured out. This will > > remove the following commits: > > > > a24fd1d6469f ("PCI: brcmstb: Use reset/rearm instead of deassert/assert") > > 92b9cb55a9b6 ("ata: ahci_brcm: Fix use of BCM7216 reset controller") > > b5d9209d5083 ("PCI: brcmstb: Fix error return code in brcm_pcie_probe()") > > Hi Bjorn, > > I believe the problem is that the commit > > 557acb3d2cd9c82de19f944f6cc967a347735385 > "reset: make shared pulsed reset controls re-triggerable" > > defined reset_control_rearm() for the CONFIG_RESET_CONTROLLER=y case > but forgot to define an empty function for the unset case. Your test > .config has this CONFIG unset. > > Would you like me to resubmit this with an additional commit that > fixes this? The fix could be a patch along those lines, or it could be a Kconfig change that makes this config impossible. I didn't look deeper to see what makes sense. But I don't think the fix should be "manually avoid this configuration." It looks like 557acb3d2cd9 ("reset: make shared pulsed reset controls re-triggerable") appeared in v5.11, so if a patch is the right thing, it should probably be marked for stable ("v5.11+"). Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDE8DC433ED for ; Wed, 28 Apr 2021 20:55:40 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2ACE36144C for ; Wed, 28 Apr 2021 20:55:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2ACE36144C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References:List-Owner; bh=QRgvJzrhwbrNNYvkIE5NlnEZlQ7K/6c7fN/1L/6uKLc=; b=R2XmyyU76AwUeaG0SIRjh4fPw LUeBcuzSU5WOH53plSy+6Eu+PWwH6a4iq21Q0NT7OlpET3yhlmP7HU0lPHbzV4pZFXMYcGllu91ZV rkrJSke4Ge3tRymjihkftcQof6+nvH0P5Xu0/1eVGS+IgDYFVc4safTLOq1P6txbBhPF7uT19h9Zr nR5ru0sWR2MkPfrnqCmWymqcWPA0QjNA+cYXUbuR0sMvu/1uxf7z+2kWSTAVUTzz3jEfRkO3xR5dk zYr1UiDYtabGq3lWYOp4NmRtCLD5GpHEnq1zLjLhE2/RaBCnFDJh/74FYjCC5XfXFUrgplqW6z2Ly fddhzsNcA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbrBW-004H5G-Qc; Wed, 28 Apr 2021 20:53:27 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbrBU-004H53-Ov; Wed, 28 Apr 2021 20:53:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding :Content-ID:Content-Description:References; bh=VHR9l+jkImghCFdmGYY8AehjizmSLoHnnd8bzSH5kho=; b=ohKwzqDZxRu+3tmRujYlTl1+NW 2W99gvyt6TIJIEwfjFD+/rwHvU+a8GX7T1/w+Ax2vFfh6QoRM3HA22hacXBpodTYeEZ+Dqr+6jLWW kfEAccS1ve3EmDmojOTTKF57MS209I939vKAGXJRCGwDQgtsCltmCdAqhn8K6dMiiGAshv6VDw98s CDPLfdvqmtAuTVTsIBH0a/g83tfcVxRvjgAirh0YHv3kWinlv8ThyrWKCd6WEG7osbbi9KSX7xxrs eSnp4DLk15qVHra9+CHiVthBdVqZ81huj23+IZNLkyiDwZtk5WW7Wp/74E5g67DPWxBkV1Xt6N6PQ 1bdVT/Nw==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbrBR-000Bdv-TK; Wed, 28 Apr 2021 20:53:23 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id DDF506140C; Wed, 28 Apr 2021 20:53:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619643201; bh=99aQgYpV6yLmeDba8HvEXO8wySN1Y1aGrrXQa8Wgmo0=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=Xtx+Tiuq+haypYskR8nkuJ8Ed/d9pf2Y1vPEY3G8ri86MjENkLr5+qDqPjxwReQ6t rO1SyNNyzeLQ4dUw6Ulje/pcBdcalOSjxHSxyXoHbaKjyPss4kDfWTZZPmQj4Ifod/ kwJCfnWfN7+A4HJ3jKjOh7d8N1s5IwIk4NmzUAG2OBA6tKUlKhuJIX5MWUA6xWO/jy Is6llTCoAJzJedVqYiNIlrGWEmAyGlYlftd/Zq14MsIGl7RirwTOZ/wx+t0inw6fxT G/g31r4Cxtr4acCme3yN9TMs5O4hHT3tZfHqcU12hKQ861xqI9O4KiCFbdBrMfCxZT OU5G9qBcTKglA== Date: Wed, 28 Apr 2021 15:53:19 -0500 From: Bjorn Helgaas To: Jim Quinlan Cc: Jim Quinlan , linux-pci@vger.kernel.org, Nicolas Saenz Julienne , bcm-kernel-feedback-list@broadcom.com, Florian Fainelli , Hans de Goede , Jens Axboe , Jim Quinlan , linux-arm-kernel@lists.infradead.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Lorenzo Pieralisi , Rob Herring , Amjad Ouled-Ameur , Philipp Zabel Subject: Re: [PATCH v5 0/2] ata: ahci_brcm: Fix use of BCM7216 reset controller Message-ID: <20210428205319.GA429792@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210428_135322_046150_2F220C3F X-CRM114-Status: GOOD ( 28.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org [+cc Amjad, Philipp: possible issue with 557acb3d2cd9 ("reset: make shared pulsed reset controls re-triggerable") below; report at https://lore.kernel.org/linux-ide/20210428200058.GA366202@bjorn-Precision-5520/] On Wed, Apr 28, 2021 at 04:34:00PM -0400, Jim Quinlan wrote: > On Wed, Apr 28, 2021 at 4:01 PM Bjorn Helgaas wrote: > > On Fri, Mar 12, 2021 at 03:45:53PM -0500, Jim Quinlan wrote: > > > v5 -- Improved (I hope) commit description (Bjorn). > > > -- Rnamed error labels (Krzyszt). > > > -- Fixed typos. > > > > > > v4 -- does not rely on a pending commit, unlike v3. > > > > > > v3 -- discard commit from v2; instead rely on the new function > > > reset_control_rearm provided in a recent commit [1] applied > > > to reset/next. > > > -- New commit to correct pcie-brcmstb.c usage of a reset controller > > > to use reset/rearm verses deassert/assert. > > > > > > v2 -- refactor rescal-reset driver to implement assert/deassert rather than > > > reset because the reset call only fires once per lifetime and we need > > > to reset after every resume from S2 or S3. > > > -- Split the use of "ahci" and "rescal" controllers in separate fields > > > to keep things simple. > > > > > > v1 -- original > > > > > > Jim Quinlan (2): > > > ata: ahci_brcm: Fix use of BCM7216 reset controller > > > PCI: brcmstb: Use reset/rearm instead of deassert/assert > > > > > > drivers/ata/ahci_brcm.c | 46 +++++++++++++-------------- > > > drivers/pci/controller/pcie-brcmstb.c | 19 +++++++---- > > > 2 files changed, 36 insertions(+), 29 deletions(-) > > > > Tripped over these errors while build testing with the .config below. > > This is on the pci/brcmstb branch from > > git://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git > > > > Dropping the pci/brcmstb branch while we get this figured out. This will > > remove the following commits: > > > > a24fd1d6469f ("PCI: brcmstb: Use reset/rearm instead of deassert/assert") > > 92b9cb55a9b6 ("ata: ahci_brcm: Fix use of BCM7216 reset controller") > > b5d9209d5083 ("PCI: brcmstb: Fix error return code in brcm_pcie_probe()") > > Hi Bjorn, > > I believe the problem is that the commit > > 557acb3d2cd9c82de19f944f6cc967a347735385 > "reset: make shared pulsed reset controls re-triggerable" > > defined reset_control_rearm() for the CONFIG_RESET_CONTROLLER=y case > but forgot to define an empty function for the unset case. Your test > .config has this CONFIG unset. > > Would you like me to resubmit this with an additional commit that > fixes this? The fix could be a patch along those lines, or it could be a Kconfig change that makes this config impossible. I didn't look deeper to see what makes sense. But I don't think the fix should be "manually avoid this configuration." It looks like 557acb3d2cd9 ("reset: make shared pulsed reset controls re-triggerable") appeared in v5.11, so if a patch is the right thing, it should probably be marked for stable ("v5.11+"). Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel