From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E78B7C43460 for ; Wed, 28 Apr 2021 22:42:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B09AA6143D for ; Wed, 28 Apr 2021 22:42:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235158AbhD1WnU (ORCPT ); Wed, 28 Apr 2021 18:43:20 -0400 Received: from elvis.franken.de ([193.175.24.41]:50467 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232065AbhD1WnT (ORCPT ); Wed, 28 Apr 2021 18:43:19 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1lbst6-00028h-00; Thu, 29 Apr 2021 00:42:32 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 0326BC0D06; Thu, 29 Apr 2021 00:41:53 +0200 (CEST) Date: Thu, 29 Apr 2021 00:41:53 +0200 From: Thomas Bogendoerfer To: Rob Herring Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Thomas Gleixner , Marc Zyngier , Rob Herring Subject: Re: [PATCH] dt-binding: interrupt-controller: Add missing interrupts property Message-ID: <20210428224153.GA15709@alpha.franken.de> References: <20210427224201.32285-1-tsbogend@alpha.franken.de> <1619648109.762240.4061025.nullmailer@robh.at.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1619648109.762240.4061025.nullmailer@robh.at.kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 28, 2021 at 05:15:09PM -0500, Rob Herring wrote: > On Wed, 28 Apr 2021 00:42:00 +0200, Thomas Bogendoerfer wrote: > > Interrupts property is required, so add it. > > > > Signed-off-by: Thomas Bogendoerfer > > --- > > .../bindings/interrupt-controller/idt,32434-pic.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun4i-a10-ic.example.dt.yaml: interrupt-controller@1c20400: 'oneOf' conditional failed, one must be fixed: > 'interrupts' is a required property > 'interrupts-extended' is a required property > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun4i-a10-ic.yaml now I'm confused... is this a problem of your test ? make dt_binding_check was ok with that change... Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]