Re: [RFC 3/3] media: rkvdec: Add the VP9 backend

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4306 bytes --]

Hi Andrzej,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on next-20210428]
[cannot apply to v5.12]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Andrzej-Pietrasiewicz/media-rkvdec-Fix-buf_prepare/20210421-175601
base:   git://linuxtv.org/media_tree.git master
config: x86_64-randconfig-a003-20210428 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 87fc97169e7901dfe56ca0da0d92da0c02d2ef48)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/df37e41d68d9ab1326f8a5a54d001d9a241b4079
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Andrzej-Pietrasiewicz/media-rkvdec-Fix-buf_prepare/20210421-175601
        git checkout df37e41d68d9ab1326f8a5a54d001d9a241b4079
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/staging/media/rkvdec/rkvdec-vp9.c:1357:50: warning: variable 'dec_params' set but not used [-Wunused-but-set-variable]
           const struct v4l2_ctrl_vp9_frame_decode_params *dec_params;
                                                           ^
   drivers/staging/media/rkvdec/rkvdec-vp9.c:1412:50: warning: variable 'dec_params' set but not used [-Wunused-but-set-variable]
           const struct v4l2_ctrl_vp9_frame_decode_params *dec_params;
                                                           ^
   2 warnings generated.


vim +/dec_params +1357 drivers/staging/media/rkvdec/rkvdec-vp9.c

  1353	
  1354	static void init_intra_only_probs(struct rkvdec_ctx *ctx,
  1355					  const struct rkvdec_vp9_run *run)
  1356	{
> 1357		const struct v4l2_ctrl_vp9_frame_decode_params *dec_params;
  1358		struct rkvdec_vp9_ctx *vp9_ctx = ctx->priv;
  1359		struct rkvdec_vp9_priv_tbl *tbl = vp9_ctx->priv_tbl.cpu;
  1360		struct rkvdec_vp9_intra_only_frame_probs *rkprobs;
  1361		const struct rkvdec_vp9_frame_context *probs;
  1362		unsigned int i, j, k, m;
  1363	
  1364		rkprobs = &tbl->probs.intra_only;
  1365		dec_params = run->decode_params;
  1366		probs = &vp9_ctx->probability_tables;
  1367	
  1368		/*
  1369		 * intra only 149 x 128 bits ,aligned to 152 x 128 bits coeff related
  1370		 * prob 64 x 128 bits
  1371		 */
  1372		for (i = 0; i < ARRAY_SIZE(probs->coef); i++) {
  1373			for (j = 0; j < ARRAY_SIZE(probs->coef[0]); j++)
  1374				write_coeff_plane(probs->coef[i][j][0],
  1375						  rkprobs->coef_intra[i][j]);
  1376		}
  1377	
  1378		/* intra mode prob  80 x 128 bits */
  1379		for (i = 0; i < ARRAY_SIZE(vp9_kf_y_mode_prob); i++) {
  1380			u32 byte_count = 0;
  1381			int idx = 0;
  1382	
  1383			/* vp9_kf_y_mode_prob */
  1384			for (j = 0; j < ARRAY_SIZE(vp9_kf_y_mode_prob[0]); j++) {
  1385				for (k = 0; k < ARRAY_SIZE(vp9_kf_y_mode_prob[0][0]);
  1386				     k++) {
  1387					u8 val = vp9_kf_y_mode_prob[i][j][k];
  1388	
  1389					rkprobs->intra_mode[i].y_mode[idx++] = val;
  1390					byte_count++;
  1391					if (byte_count == 27) {
  1392						byte_count = 0;
  1393						idx += 5;
  1394					}
  1395				}
  1396			}
  1397	
  1398			idx = 0;
  1399			if (i < 4) {
  1400				for (m = 0; m < (i < 3 ? 23 : 21); m++) {
  1401					const u8 *ptr = (const u8 *)kf_uv_mode_prob;
  1402	
  1403					rkprobs->intra_mode[i].uv_mode[idx++] = ptr[i * 23 + m];
  1404				}
  1405			}
  1406		}
  1407	}
  1408	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 44917 bytes --]